[GitHub] [pinot] walterddr commented on a diff in pull request #10971: [multistage][feature] pipeline breaker on broker reduce

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #10971:
URL: https://github.com/apache/pinot/pull/10971#discussion_r1240492928


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/QueryDispatcher.java:
##########
@@ -85,15 +87,15 @@ public QueryDispatcher() {
   }
 
   public ResultTable submitAndReduce(long requestId, DispatchableSubPlan dispatchableSubPlan,
-      MailboxService mailboxService, long timeoutMs,
+      MailboxService mailboxService, OpChainSchedulerService scheduler, long timeoutMs,
       Map<String, String> queryOptions, Map<Integer, ExecutionStatsAggregator> executionStatsAggregator,
       boolean traceEnabled)
       throws Exception {
     try {
       // submit all the distributed stages.
       int reduceStageId = submit(requestId, dispatchableSubPlan, timeoutMs, queryOptions);
       // run reduce stage and return result.
-      return runReducer(requestId, dispatchableSubPlan, reduceStageId, timeoutMs, mailboxService,
+      return runReducer(requestId, dispatchableSubPlan, reduceStageId, timeoutMs, mailboxService, scheduler,

Review Comment:
   @ankitsultana @tibrewalpratik17 can you guys verify if this resolves the broker busy wait issue you saw from your end?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org