You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Patrick Mueller (JIRA)" <ji...@apache.org> on 2014/08/30 22:31:53 UTC
[jira] [Commented] (CB-7438) weinre target not setting server url
when from script's src attribute for https
[ https://issues.apache.org/jira/browse/CB-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14116553#comment-14116553 ]
Patrick Mueller commented on CB-7438:
-------------------------------------
suggested fix
from:
pattern = /(http:\/\/(.*?)\/)/
to
pattern = /((https?:)?\/\/(.*?)\/)/
in the setWeinreServerURLFromScriptSrc() function in weinre.web/modules/weinre/target/Target.coffee
> weinre target not setting server url when from script's src attribute for https
> -------------------------------------------------------------------------------
>
> Key: CB-7438
> URL: https://issues.apache.org/jira/browse/CB-7438
> Project: Apache Cordova
> Issue Type: Bug
> Components: weinre
> Reporter: Patrick Mueller
> Assignee: Patrick Mueller
>
> The file weinre.web/modules/weinre/target/Target.coffee file calculates the weinre server URL based on the script src url, but only accepts http and not https.
> Reported by Sam Placette.
> PR: https://github.com/apache/cordova-weinre/pull/4
--
This message was sent by Atlassian JIRA
(v6.2#6252)