[GitHub] [shardingsphere] Lucas-307 commented on a change in pull request #7236: Refactor: overload the scaling MetaDataManager

[GitBox <gi...@apache.org>]

Lucas-307 commented on a change in pull request #7236:
URL: https://github.com/apache/shardingsphere/pull/7236#discussion_r482861272



##########
File path: shardingsphere-scaling/shardingsphere-scaling-core/src/main/java/org/apache/shardingsphere/scaling/core/metadata/MetaDataManager.java
##########
@@ -43,9 +43,20 @@
      * @return table meta data
      */
     public TableMetaData getTableMetaData(final String tableName) {
+        return getTableMetaData(tableName, "");

Review comment:
       Hi, if you add `getTableMetaData(final String tableName, final String databaseType)` function. This function do not have to exist. and you should update all quote.
   
   How do you know which function can use in which case?
   
   And `databaseType` only affect `Oracle` database, but we don't support `Oracle` in scaling.
   
   So, I suggest keep current code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org