You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/05/16 18:33:13 UTC

[GitHub] [zookeeper] dbwong commented on pull request #1692: ZOOKEEPER-4235 Java Client SendThread does not clean up created objects during constructor of SaslClient and Login

dbwong commented on pull request #1692:
URL: https://github.com/apache/zookeeper/pull/1692#issuecomment-841857467


   Overall looks okay to me.  Do you think it is worth making this code more testable via introduction of a factory pattern (or alternatively something like power mock)?  And verifying the shutdown paths now work/didn't work?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org