You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by DrJojo <gi...@git.apache.org> on 2014/11/21 08:28:51 UTC
[GitHub] cordova-plugin-geolocation pull request: Wrong parameter in Firefo...
GitHub user DrJojo opened a pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/31
Wrong parameter in Firefox OS plugin addWatch() function
Calling `geolocation.watchPosition()` in Firefox OS will return empty coords because `addWatch()` omits same position object conversion like in `getLocation()`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DrJojo/cordova-plugin-geolocation master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-geolocation/pull/31.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #31
----
commit 3b06100d419f550208a71581bf3a9ae44f461a75
Author: Jojo Degenhardt <jo...@gmail.com>
Date: 2014-11-21T07:24:23Z
Wrong parameter in Firefox OS plugin
Calling geolocation.watchPosition() in Firefox OS will return empty coords because addWatch() omits same position object conversion like in getLocation().
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Wrong parameter in Firefo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-geolocation/pull/31
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Wrong parameter in Firefo...
Posted by zalun <gi...@git.apache.org>.
Github user zalun commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/31#issuecomment-66492098
It would be good to have this in a separate branch. And by the way...
For some reason I can't pull master from you:
git remote add drjojo t@github.com:DrJojo/cordova-plugin-geolocation.git
git fetch drjojo
Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Wrong parameter in Firefo...
Posted by zalun <gi...@git.apache.org>.
Github user zalun commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/31#issuecomment-77323242
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-geolocation pull request: Wrong parameter in Firefo...
Posted by DrJojo <gi...@git.apache.org>.
Github user DrJojo commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/31#issuecomment-66934375
Sorry, but I'm new to git. The changes are now in a separate branch ([firefox-fix]
(https://github.com/DrJojo/cordova-plugin-geolocation/tree/firefox-fix)).
Not sure what this security error is all about. Perhaps a wrong or missing SSH-Key on your side?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org