You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by "Joerg Hoh (Jira)" <ji...@apache.org> on 2024/07/17 13:01:00 UTC

[jira] [Commented] (SLING-12369) ModelAdapterFactory: expose the number of RequestDisposableCallbacks as metric

    [ https://issues.apache.org/jira/browse/SLING-12369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17866747#comment-17866747 ] 

Joerg Hoh commented on SLING-12369:
-----------------------------------

SLING-12372 changes the way how disposables are stored until they are disposed, so this metric has been removed from the codebase.

> ModelAdapterFactory: expose the number of RequestDisposableCallbacks as metric
> ------------------------------------------------------------------------------
>
>                 Key: SLING-12369
>                 URL: https://issues.apache.org/jira/browse/SLING-12369
>             Project: Sling
>          Issue Type: Task
>          Components: Sling Models
>    Affects Versions: Models Implementation 1.7.0
>            Reporter: Joerg Hoh
>            Assignee: Joerg Hoh
>            Priority: Major
>             Fix For: Models Implementation 1.7.2
>
>
> We should expose the number of entries in the map of ModelAdapterFactory.RequestDisposableCallbacks; this would allow us to detect a constantly growing number of entries, which will end up with an OOM. With a metric we have the chance to detect those situations earlier.
> See also https://www.mail-archive.com/dev@sling.apache.org/msg131926.html and SLING-12279



--
This message was sent by Atlassian Jira
(v8.20.10#820010)