You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by David Robson <da...@quest.com> on 2015/11/19 07:50:33 UTC
Review Request 40470: Improve Oracle parameters
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40470/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-2699
https://issues.apache.org/jira/browse/SQOOP-2699
Repository: sqoop-sqoop2
Description
-------
Change Oracle parameters to use lists etc
Improve names of parameters
Add ability to filter columns in a table
Diffs
-----
connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcCommonInitializer.java 1fd95c0
connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcConnectorConstants.java 2215cf3
connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcExtractor.java df15fc2
connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcFromInitializer.java 62a0e84
connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcLoader.java b741dc8
connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcPartitioner.java 00c7752
connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcToInitializer.java f1d92f0
connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/configuration/ConnectionConfig.java c355a77
connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/configuration/FromJobConfig.java 38c808f
connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/configuration/ToJobConfig.java 939a87a
connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/util/OracleConnectionFactory.java 3ebb0d4
connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/util/OracleUtilities.java 4219af2
connector/connector-oracle-jdbc/src/main/resources/oracle-jdbc-connector-config.properties e0b9951
connector/connector-oracle-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/oracle/integration/OracleConnectionFactoryTest.java a4caa85
Diff: https://reviews.apache.org/r/40470/diff/
Testing
-------
Manually tested the changes
Thanks,
David Robson
Re: Review Request 40470: Improve Oracle parameters
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40470/#review107377
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Nov. 20, 2015, 2:06 a.m., David Robson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40470/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2015, 2:06 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2699
> https://issues.apache.org/jira/browse/SQOOP-2699
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Change Oracle parameters to use lists etc
> Improve names of parameters
> Add ability to filter columns in a table
>
>
> Diffs
> -----
>
> connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcCommonInitializer.java 1fd95c0
> connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcConnectorConstants.java 2215cf3
> connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcExtractor.java df15fc2
> connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcFromInitializer.java 62a0e84
> connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcLoader.java b741dc8
> connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcPartitioner.java 00c7752
> connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcToInitializer.java f1d92f0
> connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/configuration/ConnectionConfig.java c355a77
> connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/configuration/FromJobConfig.java 38c808f
> connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/configuration/ToJobConfig.java 939a87a
> connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/util/OracleConnectionFactory.java 3ebb0d4
> connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/util/OracleUtilities.java 4219af2
> connector/connector-oracle-jdbc/src/main/resources/oracle-jdbc-connector-config.properties e0b9951
> connector/connector-oracle-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/oracle/integration/OracleConnectionFactoryTest.java a4caa85
>
> Diff: https://reviews.apache.org/r/40470/diff/
>
>
> Testing
> -------
>
> Manually tested the changes
>
>
> Thanks,
>
> David Robson
>
>
Re: Review Request 40470: Improve Oracle parameters
Posted by David Robson <da...@quest.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40470/
-----------------------------------------------------------
(Updated Nov. 20, 2015, 2:06 a.m.)
Review request for Sqoop.
Changes
-------
Fix findbugs warning
Bugs: SQOOP-2699
https://issues.apache.org/jira/browse/SQOOP-2699
Repository: sqoop-sqoop2
Description
-------
Change Oracle parameters to use lists etc
Improve names of parameters
Add ability to filter columns in a table
Diffs (updated)
-----
connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcCommonInitializer.java 1fd95c0
connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcConnectorConstants.java 2215cf3
connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcExtractor.java df15fc2
connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcFromInitializer.java 62a0e84
connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcLoader.java b741dc8
connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcPartitioner.java 00c7752
connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/OracleJdbcToInitializer.java f1d92f0
connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/configuration/ConnectionConfig.java c355a77
connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/configuration/FromJobConfig.java 38c808f
connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/configuration/ToJobConfig.java 939a87a
connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/util/OracleConnectionFactory.java 3ebb0d4
connector/connector-oracle-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/oracle/util/OracleUtilities.java 4219af2
connector/connector-oracle-jdbc/src/main/resources/oracle-jdbc-connector-config.properties e0b9951
connector/connector-oracle-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/oracle/integration/OracleConnectionFactoryTest.java a4caa85
Diff: https://reviews.apache.org/r/40470/diff/
Testing
-------
Manually tested the changes
Thanks,
David Robson