You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Jerry Chen <ha...@intel.com> on 2016/04/01 04:40:28 UTC
Re: Review Request 34081: SENTRY-729: Update binding-hive for grant
user to role
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34081/#review126514
-----------------------------------------------------------
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java (line 237)
<https://reviews.apache.org/r/34081/#comment189522>
Suggest to use "name" instead of desc.getName() since name variable is there and used by other clauses.
- Jerry Chen
On May 12, 2015, 6:59 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34081/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 6:59 a.m.)
>
>
> Review request for sentry, Dapeng Sun, shen guoquan, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Update binding-hive for grant user to role
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java 2a60a23
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java 5898b7e
> sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java a50a40d
>
> Diff: https://reviews.apache.org/r/34081/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>