You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/08 20:53:13 UTC
[GitHub] [flink-docker] rmetzger opened a new pull request #46: [FLINK-20532] Use prope 'sed' in updated docker image + extend regex …
rmetzger opened a new pull request #46:
URL: https://github.com/apache/flink-docker/pull/46
The generated file was incorrect because the regex in the sed command didn't work as expected.
This was caused by using busybox' reduced 'sed'.
I updated the Docker image for building the stackbrew entries
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-docker] rmetzger closed pull request #46: [FLINK-20532] Use prope 'sed' in updated docker image + extend regex …
Posted by GitBox <gi...@apache.org>.
rmetzger closed pull request #46:
URL: https://github.com/apache/flink-docker/pull/46
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-docker] zentol commented on a change in pull request #46: [FLINK-20532] Use prope 'sed' in updated docker image + extend regex …
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #46:
URL: https://github.com/apache/flink-docker/pull/46#discussion_r539214984
##########
File path: generate-stackbrew-library.sh
##########
@@ -47,7 +47,7 @@ pruneTags() {
else
# remove "latest" and any "scala_" tag, unless it is the latest version
Review comment:
update the comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-docker] rmetzger commented on pull request #46: [FLINK-20532] Use prope 'sed' in updated docker image + extend regex …
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #46:
URL: https://github.com/apache/flink-docker/pull/46#issuecomment-741710573
Thx for the review. I updated the comment & merge it now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org