You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Sean Mackrory (JIRA)" <ji...@apache.org> on 2018/01/31 19:58:00 UTC

[jira] [Commented] (HADOOP-15199) hadoop_verify_confdir prevents previously valid log4j config file names

    [ https://issues.apache.org/jira/browse/HADOOP-15199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347512#comment-16347512 ] 

Sean Mackrory commented on HADOOP-15199:
----------------------------------------

CC'ing [~aw], in case you have any input.

> hadoop_verify_confdir prevents previously valid log4j config file names
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-15199
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15199
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Sean Mackrory
>            Priority: Major
>
> When starting a daemon, the shell scripts check that there's a log4j.properties file and logs an error if there isn't one. But there appear to be several instances of files named with a prefix or suffix (for example - I found this starting up HttpFS with httpfs-log4j.properties in a Bigtop-style deployment). We should probably loosen the check a little, something like this
> {code:java}
> diff --git a/hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh b/hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
> index 2dc1dc8..df82bd2 100755
> --- a/hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
> +++ b/hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
> @@ -651,7 +651,7 @@ function hadoop_verify_confdir
>  {
>    # Check only log4j.properties by default.
>    # --loglevel does not work without logger settings in log4j.log4j.properties.
> -  if [[ ! -f "${HADOOP_CONF_DIR}/log4j.properties" ]]; then
> +  if [[ ! -f "${HADOOP_CONF_DIR}/*log4j*.properties" ]]; then
>      hadoop_error "WARNING: log4j.properties is not found. HADOOP_CONF_DIR may be incomplete."
>    fi
>  }{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org