[GitHub] [spark] anchovYu commented on a diff in pull request #39269: [SPARK-41631][FOLLOWUP][SQL] Fix two issues in implicit lateral column alias resolution on Aggregate

[GitBox <gi...@apache.org>]

anchovYu commented on code in PR #39269:
URL: https://github.com/apache/spark/pull/39269#discussion_r1058716520


##########
sql/core/src/test/scala/org/apache/spark/sql/LateralColumnAliasSuite.scala:
##########
@@ -547,7 +547,8 @@ class LateralColumnAliasSuite extends LateralColumnAliasSuiteBase {
 
   test("Lateral alias of a complex type") {
     // test both Project and Aggregate
-    val querySuffixes = Seq("", s"FROM $testTable GROUP BY dept HAVING dept = 6")
+    // TODO(anchovyu): re-enable aggregate tests when fixed the having issue

Review Comment:
   It was already broken (this is the issue that I would like to discuss with you last week), and it just happened to work due to the twist in the resolution order.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org