[jira] [Comment Edited] (JCLOUDS-1330) Azure ARM orphaned networks not cleaned up when node deleted

["Ignasi Barrera (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCLOUDS-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142480#comment-16142480 ] 

Ignasi Barrera edited comment on JCLOUDS-1330 at 8/26/17 12:16 AM:
-------------------------------------------------------------------

This is intentional since the addition of the feature for attaching VMs to existing networks via the new Azure ARM specific template options. We don't want to delete what jclouds didn't create.
A good fix could be to do the same we do with the Availability Sets: tag the networks jclouds creates [here|https://github.com/jclouds/jclouds-labs/blob/master/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/strategy/CreateResourcesThenCreateNodes.java#L159] and only delete the tagged ones when cleaning up the resources.

If this makes sense, wanna try raising a PR with the fix? I'd be happy to help.


was (Author: nacx):
This is intentional since the addition of the feature for attaching VMs to existing networks via the new Azure ARM specific template options. We don't want to delete what jclouds didn't create.
A good fix could be to do the same we so with the Availability Sets: tag the networks jclouds creates [here|https://github.com/jclouds/jclouds-labs/blob/master/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/strategy/CreateResourcesThenCreateNodes.java#L159] and only delete the tagged ones when cleaning up the resources.

If this makes sense, wanna try raising a PR with the fix? I'd be happy to help.

> Azure ARM orphaned networks not cleaned up when node deleted
> ------------------------------------------------------------
>
>                 Key: JCLOUDS-1330
>                 URL: https://issues.apache.org/jira/browse/JCLOUDS-1330
>             Project: jclouds
>          Issue Type: Bug
>    Affects Versions: 2.0.2
>            Reporter: Duncan Grant
>            Priority: Minor
>
> Azure ARM orphaned networks not cleaned up when node deleted which also prevents the resource group from being removed.
> Not sure this is actually a bug.
> According to https://github.com/duncangrant/jclouds-labs/blob/dbadb279f14848f21879f7eb6c7136e1a5f11192/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/strategy/CleanupResources.java#L94-L95 the network should be cleaned up when the resource group is deleted.
> However this is not the case.  As can be seen here: https://github.com/duncangrant/jclouds-labs/blob/dbadb279f14848f21879f7eb6c7136e1a5f11192/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/strategy/CleanupResources.java#L207
> As the resource group contains the network this will prevent the resource group from being deleted leaving both the network and the resource group.
> I think that, assuming the network was created by jclouds at the same time as the resource group, it is reasonable to delete both here.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)