You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2016/07/25 05:25:31 UTC
[GitHub] zeppelin pull request #1225: [Zeppelin-1229] Add cache buster for zeppelin-w...
GitHub user corneadoug opened a pull request:
https://github.com/apache/zeppelin/pull/1225
[Zeppelin-1229] Add cache buster for zeppelin-web build
### What is this PR for?
In order to bust the cache when there is changes to the code of zeppelin-web after build, we are adding hashes at the end of the imported .js and .css files we use.
Every time there is changes in one of those file, the hash will change and the browser will use new file instead of cached one.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1229
### How should this be tested?
* Build zeppelin-web once and write down the HASH in `dist/scripts/scripts.HASH.js`
* After making a change inside a .js file of the application and building again, the hash in `dist/scripts/scripts.HASH.js` should be changed.
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1229
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1225.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1225
----
commit ebad0905783d172df947c4484540fabdb7559ea7
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-07-25T05:20:06Z
Add cache buster for .js and .css file in zeppelin-web production build
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1225: [Zeppelin-1229] Add cache buster for zeppelin-w...
Posted by corneadoug <gi...@git.apache.org>.
GitHub user corneadoug reopened a pull request:
https://github.com/apache/zeppelin/pull/1225
[Zeppelin-1229] Add cache buster for zeppelin-web build
### What is this PR for?
In order to bust the cache when there is changes to the code of zeppelin-web after build, we are adding hashes at the end of the imported .js and .css files we use.
Every time there is changes in one of those file, the hash will change and the browser will use new file instead of cached one.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1229
### How should this be tested?
* Build zeppelin-web once and write down the HASH in `dist/scripts/scripts.HASH.js`
* After making a change inside a .js file of the application and building again, the hash in `dist/scripts/scripts.HASH.js` should be changed.
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1229
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1225.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1225
----
commit ebad0905783d172df947c4484540fabdb7559ea7
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-07-25T05:20:06Z
Add cache buster for .js and .css file in zeppelin-web production build
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1225: [Zeppelin-1229] Add cache buster for zeppelin-web buil...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1225
LGTM. Can we merge it into branch-0.6 as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1225: [Zeppelin-1229] Add cache buster for zeppelin-web buil...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1225
CI Failure unrelated, Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1225: [Zeppelin-1229] Add cache buster for zeppelin-web buil...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1225
@Leemoonsoo in 0.6 or 0.6.1?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1225: [Zeppelin-1229] Add cache buster for zeppelin-w...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug closed the pull request at:
https://github.com/apache/zeppelin/pull/1225
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1225: [Zeppelin-1229] Add cache buster for zeppelin-w...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1225
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1225: [Zeppelin-1229] Add cache buster for zeppelin-web buil...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1225
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---