You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Dain Sundstrom <da...@iq80.com> on 2007/01/24 04:44:46 UTC

Re: svn commit: r499201 - in /geronimo/server/trunk/modules/geronimo-kernel/src: main/java/org/apache/geronimo/gbean/ main/java/org/apache/geronimo/gbean/runtime/ test/java/org/apache/geronimo/gbean/

I think this has broken some stuff.  This piece of code in  
PersistenceUnitReference is no longer working:

         entityManagerFactory = kernel.invoke(target,  
"getEntityManagerFactory");

I'll try to code around the problem for this instance, but you may  
want to roll back this commit.

-dain

On Jan 23, 2007, at 4:55 PM, hogstrom@apache.org wrote:

> Author: hogstrom
> Date: Tue Jan 23 16:55:35 2007
> New Revision: 499201
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=499201
> Log:
> GERONIMO-2607 : Deprecated old addOperation methods, added private
> addOperation methods
>                 updated GBeanInfoTest
>                 Modified GBeanOperation, this class is not serialized
>
> Modified:
>     geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/ 
> apache/geronimo/gbean/GBeanInfoBuilder.java
>     geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/ 
> apache/geronimo/gbean/GOperationInfo.java
>     geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/ 
> apache/geronimo/gbean/runtime/GBeanOperation.java
>     geronimo/server/trunk/modules/geronimo-kernel/src/test/java/org/ 
> apache/geronimo/gbean/GBeanInfoTest.java
>
> Modified: geronimo/server/trunk/modules/geronimo-kernel/src/main/ 
> java/org/apache/geronimo/gbean/GBeanInfoBuilder.java
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/ 
> geronimo-kernel/src/main/java/org/apache/geronimo/gbean/ 
> GBeanInfoBuilder.java?view=diff&rev=499201&r1=499200&r2=499201
> ====================================================================== 
> ========
> --- geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/ 
> apache/geronimo/gbean/GBeanInfoBuilder.java (original)
> +++ geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/ 
> apache/geronimo/gbean/GBeanInfoBuilder.java Tue Jan 23 16:55:35 2007
> @@ -403,23 +403,23 @@
>
>      /**
>       * @deprecated
> -     */
> +     */
>      public void addOperation(String name) {
> -        addOperation(new GOperationInfo(name, NO_ARGS, ""));
> +        //addOperation(new GOperationInfo(name, NO_ARGS, ""));
>      }
>
>      /**
>       * @deprecated
>       */
>      public void addOperation(String name, Class[] paramTypes) {
> -        addOperation(new GOperationInfo(name, paramTypes, ""));
> +        //addOperation(new GOperationInfo(name, paramTypes, ""));
>      }
>
> -    public void addOperation(String name, String returnType) {
> +    private void addOperation(String name, String returnType) {
>          addOperation(new GOperationInfo(name, NO_ARGS, returnType));
>      }
>
> -    public void addOperation(String name, Class[] paramTypes,  
> String returnType) {
> +    private void addOperation(String name, Class[] paramTypes,  
> String returnType) {
>          addOperation(new GOperationInfo(name, paramTypes,  
> returnType));
>      }
>
>
> Modified: geronimo/server/trunk/modules/geronimo-kernel/src/main/ 
> java/org/apache/geronimo/gbean/GOperationInfo.java
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/ 
> geronimo-kernel/src/main/java/org/apache/geronimo/gbean/ 
> GOperationInfo.java?view=diff&rev=499201&r1=499200&r2=499201
> ====================================================================== 
> ========
> --- geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/ 
> apache/geronimo/gbean/GOperationInfo.java (original)
> +++ geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/ 
> apache/geronimo/gbean/GOperationInfo.java Tue Jan 23 16:55:35 2007
> @@ -38,7 +38,7 @@
>      /**
>       * The return type of this method.
>       */
> -    private final String type;
> +    private final String returnType;
>
>      /**
>       * Parameters of this method.
> @@ -54,9 +54,9 @@
>          this(name, name, Collections.EMPTY_LIST, type);
>      }
>
> -    public GOperationInfo(String name, Class[] paramTypes, String  
> type) {
> +    public GOperationInfo(String name, Class[] paramTypes, String  
> returnType) {
>          this.name = this.methodName = name;
> -        this.type = type;
> +        this.returnType = returnType;
>          String[] args = new String[paramTypes.length];
>          for (int i = 0; i < args.length; i++) {
>              args[i] = paramTypes[i].getName();
> @@ -64,17 +64,17 @@
>          this.parameters = Collections.unmodifiableList 
> (Arrays.asList(args));
>      }
>
> -    public GOperationInfo(String name, String[] paramTypes, String  
> type) {
> -        this(name, name, Arrays.asList(paramTypes), type);
> +    public GOperationInfo(String name, String[] paramTypes, String  
> returnType) {
> +        this(name, name, Arrays.asList(paramTypes), returnType);
>      }
>
> -    public GOperationInfo(String name, List parameters, String  
> type) {
> -        this(name, name, parameters, type);
> +    public GOperationInfo(String name, List parameters, String  
> returnType) {
> +        this(name, name, parameters, returnType);
>      }
>
> -    public GOperationInfo(String name, String methodName, List  
> parameters, String type) {
> +    public GOperationInfo(String name, String methodName, List  
> parameters, String returnType) {
>          this.name = name;
> -        this.type = type;
> +        this.returnType = returnType;
>          this.methodName = methodName;
>          this.parameters = Collections.unmodifiableList(new  
> ArrayList(parameters));
>      }
> @@ -84,7 +84,7 @@
>      }
>
>      public String getReturnType() {
> -        return type;
> +        return returnType;
>      }
>
>      public String getMethodName() {
> @@ -96,6 +96,6 @@
>      }
>
>      public String toString() {
> -        return "[GOperationInfo: name=" + name + " parameters=" +  
> parameters + " type =" + type + "]";
> +        return "[GOperationInfo: name=" + name + " parameters=" +  
> parameters + " returnType =" + returnType + "]";
>      }
>  }
>
> Modified: geronimo/server/trunk/modules/geronimo-kernel/src/main/ 
> java/org/apache/geronimo/gbean/runtime/GBeanOperation.java
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/ 
> geronimo-kernel/src/main/java/org/apache/geronimo/gbean/runtime/ 
> GBeanOperation.java?view=diff&rev=499201&r1=499200&r2=499201
> ====================================================================== 
> ========
> --- geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/ 
> apache/geronimo/gbean/runtime/GBeanOperation.java (original)
> +++ geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/ 
> apache/geronimo/gbean/runtime/GBeanOperation.java Tue Jan 23  
> 16:55:35 2007
> @@ -22,7 +22,6 @@
>  import java.util.Collections;
>  import java.util.Iterator;
>  import java.util.List;
> -import java.io.Serializable;
>
>  import org.apache.geronimo.gbean.DynamicGBean;
>  import org.apache.geronimo.gbean.DynamicGOperationInfo;
> @@ -33,9 +32,7 @@
>  /**
>   * @version $Rev$ $Date$
>   */
> -public final class GBeanOperation implements Serializable {
> -    private static final long serialVersionUID =  
> -5185515581104192977L;
> -
> +public final class GBeanOperation {
>      private final GBeanInstance gbeanInstance;
>      private final String name;
>      private final List parameterTypes;
> @@ -43,7 +40,6 @@
>      private final boolean framework;
>      private final GOperationInfo operationInfo;
>
> -    // TODO - deprecate this and add returnType
>      static GBeanOperation createFrameworkOperation(GBeanInstance  
> gbeanInstance, String name, List parameterTypes, MethodInvoker  
> methodInvoker) {
>          return new GBeanOperation(gbeanInstance, name,  
> parameterTypes, methodInvoker);
>      }
> @@ -54,6 +50,7 @@
>          this.name = name;
>          this.parameterTypes = Collections.unmodifiableList(new  
> ArrayList(parameterTypes));
>          this.methodInvoker = methodInvoker;
> +        // this is not used
>          this.operationInfo = new GOperationInfo(this.name,  
> this.parameterTypes, "java.lang.Object");
>      }
>
>
> Modified: geronimo/server/trunk/modules/geronimo-kernel/src/test/ 
> java/org/apache/geronimo/gbean/GBeanInfoTest.java
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/ 
> geronimo-kernel/src/test/java/org/apache/geronimo/gbean/ 
> GBeanInfoTest.java?view=diff&rev=499201&r1=499200&r2=499201
> ====================================================================== 
> ========
> --- geronimo/server/trunk/modules/geronimo-kernel/src/test/java/org/ 
> apache/geronimo/gbean/GBeanInfoTest.java (original)
> +++ geronimo/server/trunk/modules/geronimo-kernel/src/test/java/org/ 
> apache/geronimo/gbean/GBeanInfoTest.java Tue Jan 23 16:55:35 2007
> @@ -85,7 +85,7 @@
>
>      public void testGetOperationsSet() {
>          Set gbeanOpSet = gbeanInfo.getOperations();
> -        assertEquals(1, gbeanOpSet.size());
> +        assertEquals(3, gbeanOpSet.size());
>          assertTrue(gbeanOpSet.contains(opInfo));
>      }
>
> @@ -155,7 +155,8 @@
>              infoFactory.addAttribute(persistentAttrInfo);
>
>              infoFactory.addOperation(opInfo);
> -
> +            infoFactory.addOperation("addSomething", new Class[] 
> {String.class}); // ignored
> +            infoFactory.addOperation("removeSomething", new Class[] 
> {String.class}); // ignored
>              infoFactory.addReference(refInfo);
>
>              infoFactory.addAttribute(CONSTRUCTOR_ARG_0,  
> String.class, true);
> @@ -175,6 +176,13 @@
>          }
>
>          public void setReference(String reference) {
> +        }
> +
> +        public void addSomething(String something){
> +        }
> +
> +        public String removeSomething(String something){
> +           return null;
>          }
>      }
>  }
>
>


Re: GBeanInfoBuilder [was Re: svn commit: r499201 - in /geronimo/server/trunk/modules/geronimo-kernel/src: main/java/org/apache/geronimo/gbean/ main/java/org/apache/geronimo/gbean/runtime/ test/java/org/apache/geronimo/gbean/

Posted by Dain Sundstrom <da...@iq80.com>.
Sounds good to me.  BTW, if you don't want the get/set methods to  
show up in a JMX console, just don't add them to the  MBeanInfo.

-dain

On Jun 5, 2007, at 5:23 PM, Anita Kulshreshtha wrote:

> Dain,
>    I was able to observe this problem on webconsole. I would like to
> reapply this patch with following modifications:
> 1. Leave addOperation(String ..) ASIS, i.e., getters/setters must be
> added as operation explicitly to be able to invoke them as operation.
> 2. Fix tests to demonstrate this behavior.
>    Any objections?
>
> Thanks
> Anita
>
>
> --- anita kulshreshtha <a_...@yahoo.com> wrote:
>
>>    We are not doing this at present. Please see:
>>
> http://www.nabble.com/Re%3A-svn-commit%3A-r499201---in--geronimo- 
> server-trunk-modules-geronimo-kernel-src%3A-main-java-org-apache- 
> geronimo-gbean--main-java-org-apache-geronimo-gbean-runtime--test- 
> java-org-apache-geronimo-gbean--p8769582.html
>>    The above output is for rev 502653 without my patch. The
>> getValue()
>> method is a valid getter.
>>
>> Thanks
>> Anita
>>
>> --- Dain Sundstrom <da...@iq80.com> wrote:
>>
>>> All methods regardless of if they are valid getters or setters
>> should
>>>
>>> be exposed via the invoke method (using an operation info).
>>>
>>> -dain
>
>
>
>
> ______________________________________________________________________ 
> ______________
> Looking for a deal? Find great prices on flights and hotels with  
> Yahoo! FareChase.
> http://farechase.yahoo.com/


GBeanInfoBuilder [was Re: svn commit: r499201 - in /geronimo/server/trunk/modules/geronimo-kernel/src: main/java/org/apache/geronimo/gbean/ main/java/org/apache/geronimo/gbean/runtime/ test/java/org/apache/geronimo/gbean/

Posted by Anita Kulshreshtha <a_...@yahoo.com>.
Dain,
   I was able to observe this problem on webconsole. I would like to
reapply this patch with following modifications:
1. Leave addOperation(String ..) ASIS, i.e., getters/setters must be
added as operation explicitly to be able to invoke them as operation.
2. Fix tests to demonstrate this behavior.
   Any objections?

Thanks
Anita
 
   
--- anita kulshreshtha <a_...@yahoo.com> wrote:

>    We are not doing this at present. Please see:
>
http://www.nabble.com/Re%3A-svn-commit%3A-r499201---in--geronimo-server-trunk-modules-geronimo-kernel-src%3A-main-java-org-apache-geronimo-gbean--main-java-org-apache-geronimo-gbean-runtime--test-java-org-apache-geronimo-gbean--p8769582.html
>    The above output is for rev 502653 without my patch. The
> getValue()
> method is a valid getter.
> 
> Thanks
> Anita
> 
> --- Dain Sundstrom <da...@iq80.com> wrote:
> 
> > All methods regardless of if they are valid getters or setters
> should
> >  
> > be exposed via the invoke method (using an operation info).
> > 
> > -dain



       
____________________________________________________________________________________
Looking for a deal? Find great prices on flights and hotels with Yahoo! FareChase.
http://farechase.yahoo.com/

Re: svn commit: r499201 - in /geronimo/server/trunk/modules/geronimo-kernel/src: main/java/org/apache/geronimo/gbean/ main/java/org/apache/geronimo/gbean/runtime/ test/java/org/apache/geronimo/gbean/

Posted by anita kulshreshtha <a_...@yahoo.com>.
Dain,
    If you get time.. could you please let me know if I am missing
something here?

Thanks
Anita
--- anita kulshreshtha <a_...@yahoo.com> wrote:

>    We are not doing this at present. Please see:
>
http://www.nabble.com/Re%3A-svn-commit%3A-r499201---in--geronimo-server-trunk-modules-geronimo-kernel-src%3A-main-java-org-apache-geronimo-gbean--main-java-org-apache-geronimo-gbean-runtime--test-java-org-apache-geronimo-gbean--p8769582.html
>    The above output is for rev 502653 without my patch. The
> getValue()
> method is a valid getter.
> 
> Thanks
> Anita
> 
> --- Dain Sundstrom <da...@iq80.com> wrote:
> 
> > All methods regardless of if they are valid getters or setters
> should
> >  
> > be exposed via the invoke method (using an operation info).
> > 
> > -dain
> > 
> > On Feb 2, 2007, at 7:02 AM, anita kulshreshtha wrote:
> > 
> > > Dain thanks! The test in
> org.apache.geronimo.kernel.SimpleGBeanTest
> >  
> > > was
> > > testing only the invocation of non getter/setter operations.
> Hence 
> > 
> > > this
> > > error did not show up. Surprisingly the rest of the server did
> not
> > use
> > > this! Any suggestions on how to handle this?
> > >
> > > Thanks
> > > Anita
> > >
> > > --- Dain Sundstrom <da...@iq80.com> wrote:
> > >
> > >> When that code used to be in the PersistenceUnitReference class
> > when
> > >>
> > >> you would deploy an application with a persistence unit
> reference
> > and
> > >>
> > >> you looked up that refernce... you would get an exception saying
> > that
> > >>
> > >> there is no operation named getEntityManagerFactory of that
> bean.
> > >>
> > >> You can most likely reproduce this by creating a standard gbean
> > like
> > >>
> > >> this:
> > >>
> > >> public class SomeGBean {
> > >>     private String foo;
> > >>     public String getFoo() { return foo; }
> > >>     public void setFoo(String foo { this.foo = foo; }
> > >> }
> > >>
> > >> then call this
> > >>
> > >> kernel.setAttribute(name, "foo", "bar");
> > >> assertEquals("bar", kernel.getAttribute(name, "foo"));
> > >> assertEquals("bar", kernel.invoke(name, "getFoo"));
> > >>
> > >> I'd guess that the second call will fail with your patch,
> because
> > the
> > >>
> > >> the getter and setters exposed as operations (just as an
> > attribute).
> > >>
> > >> This is just my guess.
> > >>
> > >> -dain
> > >>
> > >> On Feb 1, 2007, at 8:14 PM, anita kulshreshtha wrote:
> > >>
> > >>> Dain,
> > >>>    Could you please provide some information on how to
> reproduce
> > >> this
> > >>> failure?
> > >>>
> > >>> Thanks
> > >>> Anita
> > >>>
> > >>> --- Dain Sundstrom <da...@iq80.com> wrote:
> > >>>
> > >>>> I think this has broken some stuff.  This piece of code in
> > >>>> PersistenceUnitReference is no longer working:
> > >>>>
> > >>>>          entityManagerFactory = kernel.invoke(target,
> > >>>> "getEntityManagerFactory");
> > >>>>
> > >>>> I'll try to code around the problem for this instance, but you
> > may
> > >>>> want to roll back this commit.
> > >>>>
> > >>>> -dain
> > >>>>
> > >>>> On Jan 23, 2007, at 4:55 PM, hogstrom@apache.org wrote:
> > >>>>
> > >>>>> Author: hogstrom
> > >>>>> Date: Tue Jan 23 16:55:35 2007
> > >>>>> New Revision: 499201
> > >>>>>
> > >>>>> URL: http://svn.apache.org/viewvc?view=rev&rev=499201
> > >>>>> Log:
> > >>>>> GERONIMO-2607 : Deprecated old addOperation methods, added
> > >> private
> > >>>>> addOperation methods
> > >>>>>                 updated GBeanInfoTest
> > >>>>>                 Modified GBeanOperation, this class is not
> > >>>> serialized
> > >>>>>
> > >>>>> Modified:
> > >>>>>
> > >>>>
> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
> > >>>>> apache/geronimo/gbean/GBeanInfoBuilder.java
> > >>>>>
> > >>>>
> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
> > >>>>> apache/geronimo/gbean/GOperationInfo.java
> > >>>>>
> > >>>>
> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
> > >>>>> apache/geronimo/gbean/runtime/GBeanOperation.java
> > >>>>>
> > >>>>
> geronimo/server/trunk/modules/geronimo-kernel/src/test/java/org/
> > >>>>> apache/geronimo/gbean/GBeanInfoTest.java
> > >>>>>
> > >>>>> Modified:
> > geronimo/server/trunk/modules/geronimo-kernel/src/main/
> > >>>>> java/org/apache/geronimo/gbean/GBeanInfoBuilder.java
> > >>>>> URL:
> > http://svn.apache.org/viewvc/geronimo/server/trunk/modules/
> > >>>>> geronimo-kernel/src/main/java/org/apache/geronimo/gbean/
> > >>>>>
> GBeanInfoBuilder.java?view=diff&rev=499201&r1=499200&r2=499201
> > >>>>>
> > >>>>
> > >>>
> > >>
> > >
> >
>
======================================================================
> > >>>>
> > >>>>> ========
> > >>>>> ---
> > >>>>
> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
> > >>>>> apache/geronimo/gbean/GBeanInfoBuilder.java (original)
> > >>>>> +++
> > >>>>
> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
> > >>>>> apache/geronimo/gbean/GBeanInfoBuilder.java Tue Jan 23
> 16:55:35
> > >>>> 2007
> > >>>>> @@ -403,23 +403,23 @@
> > >>>>>
> > >>>>>      /**
> > >>>>>       * @deprecated
> > >>>>> -     */
> > >>>>> +     */
> > >>>>>      public void addOperation(String name) {
> > >>>>> -        addOperation(new GOperationInfo(name, NO_ARGS, ""));
> > >>>>> +        //addOperation(new GOperationInfo(name, NO_ARGS,
> ""));
> > >>>>>      }
> > >>>>>
> > >>>>>      /**
> > >>>>>       * @deprecated
> > >>>>>       */
> > >>>>>      public void addOperation(String name, Class[]
> paramTypes)
> > {
> > >>>>> -        addOperation(new GOperationInfo(name, paramTypes,
> > ""));
> > >>>>> +        //addOperation(new GOperationInfo(name, paramTypes,
> > >> ""));
> > >>>>>      }
> > >>>>>
> > >>>>> -    public void addOperation(String name, String returnType)
> {
> > >>>>> +    private void addOperation(String name, String
> returnType)
> > {
> > >>>>>          addOperation(new GOperationInfo(name, NO_ARGS,
> > >>>> returnType));
> > >>>>>      }
> > >>>>>
> > >>>>> -    public void addOperation(String name, Class[]
> paramTypes,
> > >>>>> String returnType) {
> > >>>>> +    private void addOperation(String name, Class[]
> paramTypes,
> 
=== message truncated ===




 
____________________________________________________________________________________
Need Mail bonding?
Go to the Yahoo! Mail Q&A for great tips from Yahoo! Answers users.
http://answers.yahoo.com/dir/?link=list&sid=396546091

Re: svn commit: r499201 - in /geronimo/server/trunk/modules/geronimo-kernel/src: main/java/org/apache/geronimo/gbean/ main/java/org/apache/geronimo/gbean/runtime/ test/java/org/apache/geronimo/gbean/

Posted by anita kulshreshtha <a_...@yahoo.com>.
   We are not doing this at present. Please see:
http://www.nabble.com/Re%3A-svn-commit%3A-r499201---in--geronimo-server-trunk-modules-geronimo-kernel-src%3A-main-java-org-apache-geronimo-gbean--main-java-org-apache-geronimo-gbean-runtime--test-java-org-apache-geronimo-gbean--p8769582.html
   The above output is for rev 502653 without my patch. The getValue()
method is a valid getter.

Thanks
Anita

--- Dain Sundstrom <da...@iq80.com> wrote:

> All methods regardless of if they are valid getters or setters should
>  
> be exposed via the invoke method (using an operation info).
> 
> -dain
> 
> On Feb 2, 2007, at 7:02 AM, anita kulshreshtha wrote:
> 
> > Dain thanks! The test in org.apache.geronimo.kernel.SimpleGBeanTest
>  
> > was
> > testing only the invocation of non getter/setter operations. Hence 
> 
> > this
> > error did not show up. Surprisingly the rest of the server did not
> use
> > this! Any suggestions on how to handle this?
> >
> > Thanks
> > Anita
> >
> > --- Dain Sundstrom <da...@iq80.com> wrote:
> >
> >> When that code used to be in the PersistenceUnitReference class
> when
> >>
> >> you would deploy an application with a persistence unit reference
> and
> >>
> >> you looked up that refernce... you would get an exception saying
> that
> >>
> >> there is no operation named getEntityManagerFactory of that bean.
> >>
> >> You can most likely reproduce this by creating a standard gbean
> like
> >>
> >> this:
> >>
> >> public class SomeGBean {
> >>     private String foo;
> >>     public String getFoo() { return foo; }
> >>     public void setFoo(String foo { this.foo = foo; }
> >> }
> >>
> >> then call this
> >>
> >> kernel.setAttribute(name, "foo", "bar");
> >> assertEquals("bar", kernel.getAttribute(name, "foo"));
> >> assertEquals("bar", kernel.invoke(name, "getFoo"));
> >>
> >> I'd guess that the second call will fail with your patch, because
> the
> >>
> >> the getter and setters exposed as operations (just as an
> attribute).
> >>
> >> This is just my guess.
> >>
> >> -dain
> >>
> >> On Feb 1, 2007, at 8:14 PM, anita kulshreshtha wrote:
> >>
> >>> Dain,
> >>>    Could you please provide some information on how to reproduce
> >> this
> >>> failure?
> >>>
> >>> Thanks
> >>> Anita
> >>>
> >>> --- Dain Sundstrom <da...@iq80.com> wrote:
> >>>
> >>>> I think this has broken some stuff.  This piece of code in
> >>>> PersistenceUnitReference is no longer working:
> >>>>
> >>>>          entityManagerFactory = kernel.invoke(target,
> >>>> "getEntityManagerFactory");
> >>>>
> >>>> I'll try to code around the problem for this instance, but you
> may
> >>>> want to roll back this commit.
> >>>>
> >>>> -dain
> >>>>
> >>>> On Jan 23, 2007, at 4:55 PM, hogstrom@apache.org wrote:
> >>>>
> >>>>> Author: hogstrom
> >>>>> Date: Tue Jan 23 16:55:35 2007
> >>>>> New Revision: 499201
> >>>>>
> >>>>> URL: http://svn.apache.org/viewvc?view=rev&rev=499201
> >>>>> Log:
> >>>>> GERONIMO-2607 : Deprecated old addOperation methods, added
> >> private
> >>>>> addOperation methods
> >>>>>                 updated GBeanInfoTest
> >>>>>                 Modified GBeanOperation, this class is not
> >>>> serialized
> >>>>>
> >>>>> Modified:
> >>>>>
> >>>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
> >>>>> apache/geronimo/gbean/GBeanInfoBuilder.java
> >>>>>
> >>>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
> >>>>> apache/geronimo/gbean/GOperationInfo.java
> >>>>>
> >>>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
> >>>>> apache/geronimo/gbean/runtime/GBeanOperation.java
> >>>>>
> >>>> geronimo/server/trunk/modules/geronimo-kernel/src/test/java/org/
> >>>>> apache/geronimo/gbean/GBeanInfoTest.java
> >>>>>
> >>>>> Modified:
> geronimo/server/trunk/modules/geronimo-kernel/src/main/
> >>>>> java/org/apache/geronimo/gbean/GBeanInfoBuilder.java
> >>>>> URL:
> http://svn.apache.org/viewvc/geronimo/server/trunk/modules/
> >>>>> geronimo-kernel/src/main/java/org/apache/geronimo/gbean/
> >>>>> GBeanInfoBuilder.java?view=diff&rev=499201&r1=499200&r2=499201
> >>>>>
> >>>>
> >>>
> >>
> >
>
======================================================================
> >>>>
> >>>>> ========
> >>>>> ---
> >>>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
> >>>>> apache/geronimo/gbean/GBeanInfoBuilder.java (original)
> >>>>> +++
> >>>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
> >>>>> apache/geronimo/gbean/GBeanInfoBuilder.java Tue Jan 23 16:55:35
> >>>> 2007
> >>>>> @@ -403,23 +403,23 @@
> >>>>>
> >>>>>      /**
> >>>>>       * @deprecated
> >>>>> -     */
> >>>>> +     */
> >>>>>      public void addOperation(String name) {
> >>>>> -        addOperation(new GOperationInfo(name, NO_ARGS, ""));
> >>>>> +        //addOperation(new GOperationInfo(name, NO_ARGS, ""));
> >>>>>      }
> >>>>>
> >>>>>      /**
> >>>>>       * @deprecated
> >>>>>       */
> >>>>>      public void addOperation(String name, Class[] paramTypes)
> {
> >>>>> -        addOperation(new GOperationInfo(name, paramTypes,
> ""));
> >>>>> +        //addOperation(new GOperationInfo(name, paramTypes,
> >> ""));
> >>>>>      }
> >>>>>
> >>>>> -    public void addOperation(String name, String returnType) {
> >>>>> +    private void addOperation(String name, String returnType)
> {
> >>>>>          addOperation(new GOperationInfo(name, NO_ARGS,
> >>>> returnType));
> >>>>>      }
> >>>>>
> >>>>> -    public void addOperation(String name, Class[] paramTypes,
> >>>>> String returnType) {
> >>>>> +    private void addOperation(String name, Class[] paramTypes,
> >>>>> String returnType) {
> >>>>>          addOperation(new GOperationInfo(name, paramTypes,
> >>>>> returnType));
> >>>>>      }
> >>>>>
> >>>>>
> >>>>> Modified:
> geronimo/server/trunk/modules/geronimo-kernel/src/main/
> >>>>> java/org/apache/geronimo/gbean/GOperationInfo.java
> >>>>> URL:
> http://svn.apache.org/viewvc/geronimo/server/trunk/modules/
> >>>>> geronimo-kernel/src/main/java/org/apache/geronimo/gbean/
> >>>>> GOperationInfo.java?view=diff&rev=499201&r1=499200&r2=499201
> >>>>>
> >>>>
> >>>
> >>
> >
>
======================================================================
> >>>>
> >>>>> ========
> >>>>> ---
> >>>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
> >>>>> apache/geronimo/gbean/GOperationInfo.java (original)
> >>>>> +++
> >>>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
> >>>>> apache/geronimo/gbean/GOperationInfo.java Tue Jan 23 16:55:35
> >> 2007
> >>>>> @@ -38,7 +38,7 @@
> >>>>>      /**
> >>>>>       * The return type of this method.
> >>>>>       */
> >>>>> -    private final String type;
> 
=== message truncated ===



 
____________________________________________________________________________________
Do you Yahoo!?
Everyone is raving about the all-new Yahoo! Mail beta.
http://new.mail.yahoo.com

Re: svn commit: r499201 - in /geronimo/server/trunk/modules/geronimo-kernel/src: main/java/org/apache/geronimo/gbean/ main/java/org/apache/geronimo/gbean/runtime/ test/java/org/apache/geronimo/gbean/

Posted by Dain Sundstrom <da...@iq80.com>.
All methods regardless of if they are valid getters or setters should  
be exposed via the invoke method (using an operation info).

-dain

On Feb 2, 2007, at 7:02 AM, anita kulshreshtha wrote:

> Dain thanks! The test in org.apache.geronimo.kernel.SimpleGBeanTest  
> was
> testing only the invocation of non getter/setter operations. Hence  
> this
> error did not show up. Surprisingly the rest of the server did not use
> this! Any suggestions on how to handle this?
>
> Thanks
> Anita
>
> --- Dain Sundstrom <da...@iq80.com> wrote:
>
>> When that code used to be in the PersistenceUnitReference class when
>>
>> you would deploy an application with a persistence unit reference and
>>
>> you looked up that refernce... you would get an exception saying that
>>
>> there is no operation named getEntityManagerFactory of that bean.
>>
>> You can most likely reproduce this by creating a standard gbean like
>>
>> this:
>>
>> public class SomeGBean {
>>     private String foo;
>>     public String getFoo() { return foo; }
>>     public void setFoo(String foo { this.foo = foo; }
>> }
>>
>> then call this
>>
>> kernel.setAttribute(name, "foo", "bar");
>> assertEquals("bar", kernel.getAttribute(name, "foo"));
>> assertEquals("bar", kernel.invoke(name, "getFoo"));
>>
>> I'd guess that the second call will fail with your patch, because the
>>
>> the getter and setters exposed as operations (just as an attribute).
>>
>> This is just my guess.
>>
>> -dain
>>
>> On Feb 1, 2007, at 8:14 PM, anita kulshreshtha wrote:
>>
>>> Dain,
>>>    Could you please provide some information on how to reproduce
>> this
>>> failure?
>>>
>>> Thanks
>>> Anita
>>>
>>> --- Dain Sundstrom <da...@iq80.com> wrote:
>>>
>>>> I think this has broken some stuff.  This piece of code in
>>>> PersistenceUnitReference is no longer working:
>>>>
>>>>          entityManagerFactory = kernel.invoke(target,
>>>> "getEntityManagerFactory");
>>>>
>>>> I'll try to code around the problem for this instance, but you may
>>>> want to roll back this commit.
>>>>
>>>> -dain
>>>>
>>>> On Jan 23, 2007, at 4:55 PM, hogstrom@apache.org wrote:
>>>>
>>>>> Author: hogstrom
>>>>> Date: Tue Jan 23 16:55:35 2007
>>>>> New Revision: 499201
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?view=rev&rev=499201
>>>>> Log:
>>>>> GERONIMO-2607 : Deprecated old addOperation methods, added
>> private
>>>>> addOperation methods
>>>>>                 updated GBeanInfoTest
>>>>>                 Modified GBeanOperation, this class is not
>>>> serialized
>>>>>
>>>>> Modified:
>>>>>
>>>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
>>>>> apache/geronimo/gbean/GBeanInfoBuilder.java
>>>>>
>>>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
>>>>> apache/geronimo/gbean/GOperationInfo.java
>>>>>
>>>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
>>>>> apache/geronimo/gbean/runtime/GBeanOperation.java
>>>>>
>>>> geronimo/server/trunk/modules/geronimo-kernel/src/test/java/org/
>>>>> apache/geronimo/gbean/GBeanInfoTest.java
>>>>>
>>>>> Modified: geronimo/server/trunk/modules/geronimo-kernel/src/main/
>>>>> java/org/apache/geronimo/gbean/GBeanInfoBuilder.java
>>>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/
>>>>> geronimo-kernel/src/main/java/org/apache/geronimo/gbean/
>>>>> GBeanInfoBuilder.java?view=diff&rev=499201&r1=499200&r2=499201
>>>>>
>>>>
>>>
>>
> ======================================================================
>>>>
>>>>> ========
>>>>> ---
>>>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
>>>>> apache/geronimo/gbean/GBeanInfoBuilder.java (original)
>>>>> +++
>>>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
>>>>> apache/geronimo/gbean/GBeanInfoBuilder.java Tue Jan 23 16:55:35
>>>> 2007
>>>>> @@ -403,23 +403,23 @@
>>>>>
>>>>>      /**
>>>>>       * @deprecated
>>>>> -     */
>>>>> +     */
>>>>>      public void addOperation(String name) {
>>>>> -        addOperation(new GOperationInfo(name, NO_ARGS, ""));
>>>>> +        //addOperation(new GOperationInfo(name, NO_ARGS, ""));
>>>>>      }
>>>>>
>>>>>      /**
>>>>>       * @deprecated
>>>>>       */
>>>>>      public void addOperation(String name, Class[] paramTypes) {
>>>>> -        addOperation(new GOperationInfo(name, paramTypes, ""));
>>>>> +        //addOperation(new GOperationInfo(name, paramTypes,
>> ""));
>>>>>      }
>>>>>
>>>>> -    public void addOperation(String name, String returnType) {
>>>>> +    private void addOperation(String name, String returnType) {
>>>>>          addOperation(new GOperationInfo(name, NO_ARGS,
>>>> returnType));
>>>>>      }
>>>>>
>>>>> -    public void addOperation(String name, Class[] paramTypes,
>>>>> String returnType) {
>>>>> +    private void addOperation(String name, Class[] paramTypes,
>>>>> String returnType) {
>>>>>          addOperation(new GOperationInfo(name, paramTypes,
>>>>> returnType));
>>>>>      }
>>>>>
>>>>>
>>>>> Modified: geronimo/server/trunk/modules/geronimo-kernel/src/main/
>>>>> java/org/apache/geronimo/gbean/GOperationInfo.java
>>>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/
>>>>> geronimo-kernel/src/main/java/org/apache/geronimo/gbean/
>>>>> GOperationInfo.java?view=diff&rev=499201&r1=499200&r2=499201
>>>>>
>>>>
>>>
>>
> ======================================================================
>>>>
>>>>> ========
>>>>> ---
>>>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
>>>>> apache/geronimo/gbean/GOperationInfo.java (original)
>>>>> +++
>>>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
>>>>> apache/geronimo/gbean/GOperationInfo.java Tue Jan 23 16:55:35
>> 2007
>>>>> @@ -38,7 +38,7 @@
>>>>>      /**
>>>>>       * The return type of this method.
>>>>>       */
>>>>> -    private final String type;
>>>>> +    private final String returnType;
>>>>>
>>>>>      /**
>>>>>       * Parameters of this method.
>>>>> @@ -54,9 +54,9 @@
>>>>>          this(name, name, Collections.EMPTY_LIST, type);
>>>>>      }
>>>>>
>>>>> -    public GOperationInfo(String name, Class[] paramTypes,
>> String
>>>>
>>>>> type) {
>>>>> +    public GOperationInfo(String name, Class[] paramTypes,
>> String
>>>>
>>>>> returnType) {
>>>>>          this.name = this.methodName = name;
>>>>> -        this.type = type;
>>>>> +        this.returnType = returnType;
>>>>>          String[] args = new String[paramTypes.length];
>>>>>          for (int i = 0; i < args.length; i++) {
>>>>>              args[i] = paramTypes[i].getName();
>>>>> @@ -64,17 +64,17 @@
>>>>>          this.parameters = Collections.unmodifiableList
>>>>> (Arrays.asList(args));
>>>>>      }
>>>>>
>>>>> -    public GOperationInfo(String name, String[] paramTypes,
>> String
>>>>
>>>>> type) {
>>>>> -        this(name, name, Arrays.asList(paramTypes), type);
>>>>> +    public GOperationInfo(String name, String[] paramTypes,
>> String
>>>>
>>>>> returnType) {
>>>>> +        this(name, name, Arrays.asList(paramTypes), returnType);
>>>>>      }
>>>>>
>>>>> -    public GOperationInfo(String name, List parameters, String
>>>>> type) {
>>
> === message truncated ===
>
>
>
>
> ______________________________________________________________________ 
> ______________
> It's here! Your new message!
> Get new email alerts with the free Yahoo! Toolbar.
> http://tools.search.yahoo.com/toolbar/features/mail/


Re: svn commit: r499201 - in /geronimo/server/trunk/modules/geronimo-kernel/src: main/java/org/apache/geronimo/gbean/ main/java/org/apache/geronimo/gbean/runtime/ test/java/org/apache/geronimo/gbean/

Posted by anita kulshreshtha <a_...@yahoo.com>.
Dain,
   I changed line 61 in SimpleGBeanTest to use getValue instead of
fetchValue, i.e. 
assertEquals("1234", kernel.invoke("MyBean", "getValue"));
  Here are the results with rev 502635:

-------------------------------------------------------------------------------
Test set: org.apache.geronimo.kernel.SimpleGBeanTest
-------------------------------------------------------------------------------
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.156
sec <<< FAILURE!
test(org.apache.geronimo.kernel.SimpleGBeanTest)  Time elapsed: 0.141
sec  <<< ERROR!
org.apache.geronimo.kernel.NoSuchOperationException: Unknown operation
getValue()
	at
org.apache.geronimo.gbean.runtime.GBeanInstance.invoke(GBeanInstance.java:840)
	at
org.apache.geronimo.kernel.basic.BasicKernel.invoke(BasicKernel.java:252)
	at
org.apache.geronimo.kernel.basic.BasicKernel.invoke(BasicKernel.java:221)
	at
org.apache.geronimo.kernel.SimpleGBeanTest.test(SimpleGBeanTest.java:61)

thanks
Anita

--- anita kulshreshtha <a_...@yahoo.com> wrote:

> Dain thanks! The test in org.apache.geronimo.kernel.SimpleGBeanTest
> was
> testing only the invocation of non getter/setter operations. Hence
> this
> error did not show up. Surprisingly the rest of the server did not
> use
> this! Any suggestions on how to handle this?
> 
> Thanks
> Anita
> 
> --- Dain Sundstrom <da...@iq80.com> wrote:
> 
> > When that code used to be in the PersistenceUnitReference class
> when 
> > 
> > you would deploy an application with a persistence unit reference
> and
> >  
> > you looked up that refernce... you would get an exception saying
> that
> >  
> > there is no operation named getEntityManagerFactory of that bean.
> > 
> > You can most likely reproduce this by creating a standard gbean
> like 
> > 
> > this:
> > 
> > public class SomeGBean {
> >     private String foo;
> >     public String getFoo() { return foo; }
> >     public void setFoo(String foo { this.foo = foo; }
> > }
> > 
> > then call this
> > 
> > kernel.setAttribute(name, "foo", "bar");
> > assertEquals("bar", kernel.getAttribute(name, "foo"));
> > assertEquals("bar", kernel.invoke(name, "getFoo"));
> > 
> > I'd guess that the second call will fail with your patch, because
> the
> >  
> > the getter and setters exposed as operations (just as an
> attribute). 
> >  
> > This is just my guess.
> > 
> > -dain
> > 
> > On Feb 1, 2007, at 8:14 PM, anita kulshreshtha wrote:
> > 
> > > Dain,
> > >    Could you please provide some information on how to reproduce
> > this
> > > failure?
> > >
> > > Thanks
> > > Anita
> > >
> > > --- Dain Sundstrom <da...@iq80.com> wrote:
> > >
> > >> I think this has broken some stuff.  This piece of code in
> > >> PersistenceUnitReference is no longer working:
> > >>
> > >>          entityManagerFactory = kernel.invoke(target,
> > >> "getEntityManagerFactory");
> > >>
> > >> I'll try to code around the problem for this instance, but you
> may
> > >> want to roll back this commit.
> > >>
> > >> -dain
> > >>
> > >> On Jan 23, 2007, at 4:55 PM, hogstrom@apache.org wrote:
> > >>
> > >>> Author: hogstrom
> > >>> Date: Tue Jan 23 16:55:35 2007
> > >>> New Revision: 499201
> > >>>
> > >>> URL: http://svn.apache.org/viewvc?view=rev&rev=499201
> > >>> Log:
> > >>> GERONIMO-2607 : Deprecated old addOperation methods, added
> > private
> > >>> addOperation methods
> > >>>                 updated GBeanInfoTest
> > >>>                 Modified GBeanOperation, this class is not
> > >> serialized
> > >>>
> > >>> Modified:
> > >>>
> > >> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
> > >>> apache/geronimo/gbean/GBeanInfoBuilder.java
> > >>>
> > >> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
> > >>> apache/geronimo/gbean/GOperationInfo.java
> > >>>
> > >> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
> > >>> apache/geronimo/gbean/runtime/GBeanOperation.java
> > >>>
> > >> geronimo/server/trunk/modules/geronimo-kernel/src/test/java/org/
> > >>> apache/geronimo/gbean/GBeanInfoTest.java
> > >>>
> > >>> Modified:
> geronimo/server/trunk/modules/geronimo-kernel/src/main/
> > >>> java/org/apache/geronimo/gbean/GBeanInfoBuilder.java
> > >>> URL:
> http://svn.apache.org/viewvc/geronimo/server/trunk/modules/
> > >>> geronimo-kernel/src/main/java/org/apache/geronimo/gbean/
> > >>> GBeanInfoBuilder.java?view=diff&rev=499201&r1=499200&r2=499201
> > >>>
> > >>
> > >
> >
>
======================================================================
> > >>
> > >>> ========
> > >>> ---
> > >> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
> > >>> apache/geronimo/gbean/GBeanInfoBuilder.java (original)
> > >>> +++
> > >> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
> > >>> apache/geronimo/gbean/GBeanInfoBuilder.java Tue Jan 23 16:55:35
> > >> 2007
> > >>> @@ -403,23 +403,23 @@
> > >>>
> > >>>      /**
> > >>>       * @deprecated
> > >>> -     */
> > >>> +     */
> > >>>      public void addOperation(String name) {
> > >>> -        addOperation(new GOperationInfo(name, NO_ARGS, ""));
> > >>> +        //addOperation(new GOperationInfo(name, NO_ARGS, ""));
> > >>>      }
> > >>>
> > >>>      /**
> > >>>       * @deprecated
> > >>>       */
> > >>>      public void addOperation(String name, Class[] paramTypes)
> {
> > >>> -        addOperation(new GOperationInfo(name, paramTypes,
> ""));
> > >>> +        //addOperation(new GOperationInfo(name, paramTypes,
> > ""));
> > >>>      }
> > >>>
> > >>> -    public void addOperation(String name, String returnType) {
> > >>> +    private void addOperation(String name, String returnType)
> {
> > >>>          addOperation(new GOperationInfo(name, NO_ARGS,
> > >> returnType));
> > >>>      }
> > >>>
> > >>> -    public void addOperation(String name, Class[] paramTypes,
> > >>> String returnType) {
> > >>> +    private void addOperation(String name, Class[] paramTypes,
> > >>> String returnType) {
> > >>>          addOperation(new GOperationInfo(name, paramTypes,
> > >>> returnType));
> > >>>      }
> > >>>
> > >>>
> > >>> Modified:
> geronimo/server/trunk/modules/geronimo-kernel/src/main/
> > >>> java/org/apache/geronimo/gbean/GOperationInfo.java
> > >>> URL:
> http://svn.apache.org/viewvc/geronimo/server/trunk/modules/
> > >>> geronimo-kernel/src/main/java/org/apache/geronimo/gbean/
> > >>> GOperationInfo.java?view=diff&rev=499201&r1=499200&r2=499201
> > >>>
> > >>
> > >
> >
>
======================================================================
> > >>
> > >>> ========
> > >>> ---
> > >> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
> > >>> apache/geronimo/gbean/GOperationInfo.java (original)
> > >>> +++
> > >> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
> > >>> apache/geronimo/gbean/GOperationInfo.java Tue Jan 23 16:55:35
> > 2007
> > >>> @@ -38,7 +38,7 @@
> > >>>      /**
> > >>>       * The return type of this method.
> > >>>       */
> > >>> -    private final String type;
> > >>> +    private final String returnType;
> > >>>
> > >>>      /**
> > >>>       * Parameters of this method.
> > >>> @@ -54,9 +54,9 @@
> > >>>          this(name, name, Collections.EMPTY_LIST, type);
> > >>>      }
> > >>>
> > >>> -    public GOperationInfo(String name, Class[] paramTypes,
> > String
> > >>
> > >>> type) {
> 
=== message truncated ===



 
____________________________________________________________________________________
Need a quick answer? Get one in minutes from people who know.
Ask your question on www.Answers.yahoo.com

Re: svn commit: r499201 - in /geronimo/server/trunk/modules/geronimo-kernel/src: main/java/org/apache/geronimo/gbean/ main/java/org/apache/geronimo/gbean/runtime/ test/java/org/apache/geronimo/gbean/

Posted by anita kulshreshtha <a_...@yahoo.com>.
Dain thanks! The test in org.apache.geronimo.kernel.SimpleGBeanTest was
testing only the invocation of non getter/setter operations. Hence this
error did not show up. Surprisingly the rest of the server did not use
this! Any suggestions on how to handle this?

Thanks
Anita

--- Dain Sundstrom <da...@iq80.com> wrote:

> When that code used to be in the PersistenceUnitReference class when 
> 
> you would deploy an application with a persistence unit reference and
>  
> you looked up that refernce... you would get an exception saying that
>  
> there is no operation named getEntityManagerFactory of that bean.
> 
> You can most likely reproduce this by creating a standard gbean like 
> 
> this:
> 
> public class SomeGBean {
>     private String foo;
>     public String getFoo() { return foo; }
>     public void setFoo(String foo { this.foo = foo; }
> }
> 
> then call this
> 
> kernel.setAttribute(name, "foo", "bar");
> assertEquals("bar", kernel.getAttribute(name, "foo"));
> assertEquals("bar", kernel.invoke(name, "getFoo"));
> 
> I'd guess that the second call will fail with your patch, because the
>  
> the getter and setters exposed as operations (just as an attribute). 
>  
> This is just my guess.
> 
> -dain
> 
> On Feb 1, 2007, at 8:14 PM, anita kulshreshtha wrote:
> 
> > Dain,
> >    Could you please provide some information on how to reproduce
> this
> > failure?
> >
> > Thanks
> > Anita
> >
> > --- Dain Sundstrom <da...@iq80.com> wrote:
> >
> >> I think this has broken some stuff.  This piece of code in
> >> PersistenceUnitReference is no longer working:
> >>
> >>          entityManagerFactory = kernel.invoke(target,
> >> "getEntityManagerFactory");
> >>
> >> I'll try to code around the problem for this instance, but you may
> >> want to roll back this commit.
> >>
> >> -dain
> >>
> >> On Jan 23, 2007, at 4:55 PM, hogstrom@apache.org wrote:
> >>
> >>> Author: hogstrom
> >>> Date: Tue Jan 23 16:55:35 2007
> >>> New Revision: 499201
> >>>
> >>> URL: http://svn.apache.org/viewvc?view=rev&rev=499201
> >>> Log:
> >>> GERONIMO-2607 : Deprecated old addOperation methods, added
> private
> >>> addOperation methods
> >>>                 updated GBeanInfoTest
> >>>                 Modified GBeanOperation, this class is not
> >> serialized
> >>>
> >>> Modified:
> >>>
> >> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
> >>> apache/geronimo/gbean/GBeanInfoBuilder.java
> >>>
> >> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
> >>> apache/geronimo/gbean/GOperationInfo.java
> >>>
> >> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
> >>> apache/geronimo/gbean/runtime/GBeanOperation.java
> >>>
> >> geronimo/server/trunk/modules/geronimo-kernel/src/test/java/org/
> >>> apache/geronimo/gbean/GBeanInfoTest.java
> >>>
> >>> Modified: geronimo/server/trunk/modules/geronimo-kernel/src/main/
> >>> java/org/apache/geronimo/gbean/GBeanInfoBuilder.java
> >>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/
> >>> geronimo-kernel/src/main/java/org/apache/geronimo/gbean/
> >>> GBeanInfoBuilder.java?view=diff&rev=499201&r1=499200&r2=499201
> >>>
> >>
> >
>
======================================================================
> >>
> >>> ========
> >>> ---
> >> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
> >>> apache/geronimo/gbean/GBeanInfoBuilder.java (original)
> >>> +++
> >> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
> >>> apache/geronimo/gbean/GBeanInfoBuilder.java Tue Jan 23 16:55:35
> >> 2007
> >>> @@ -403,23 +403,23 @@
> >>>
> >>>      /**
> >>>       * @deprecated
> >>> -     */
> >>> +     */
> >>>      public void addOperation(String name) {
> >>> -        addOperation(new GOperationInfo(name, NO_ARGS, ""));
> >>> +        //addOperation(new GOperationInfo(name, NO_ARGS, ""));
> >>>      }
> >>>
> >>>      /**
> >>>       * @deprecated
> >>>       */
> >>>      public void addOperation(String name, Class[] paramTypes) {
> >>> -        addOperation(new GOperationInfo(name, paramTypes, ""));
> >>> +        //addOperation(new GOperationInfo(name, paramTypes,
> ""));
> >>>      }
> >>>
> >>> -    public void addOperation(String name, String returnType) {
> >>> +    private void addOperation(String name, String returnType) {
> >>>          addOperation(new GOperationInfo(name, NO_ARGS,
> >> returnType));
> >>>      }
> >>>
> >>> -    public void addOperation(String name, Class[] paramTypes,
> >>> String returnType) {
> >>> +    private void addOperation(String name, Class[] paramTypes,
> >>> String returnType) {
> >>>          addOperation(new GOperationInfo(name, paramTypes,
> >>> returnType));
> >>>      }
> >>>
> >>>
> >>> Modified: geronimo/server/trunk/modules/geronimo-kernel/src/main/
> >>> java/org/apache/geronimo/gbean/GOperationInfo.java
> >>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/
> >>> geronimo-kernel/src/main/java/org/apache/geronimo/gbean/
> >>> GOperationInfo.java?view=diff&rev=499201&r1=499200&r2=499201
> >>>
> >>
> >
>
======================================================================
> >>
> >>> ========
> >>> ---
> >> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
> >>> apache/geronimo/gbean/GOperationInfo.java (original)
> >>> +++
> >> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
> >>> apache/geronimo/gbean/GOperationInfo.java Tue Jan 23 16:55:35
> 2007
> >>> @@ -38,7 +38,7 @@
> >>>      /**
> >>>       * The return type of this method.
> >>>       */
> >>> -    private final String type;
> >>> +    private final String returnType;
> >>>
> >>>      /**
> >>>       * Parameters of this method.
> >>> @@ -54,9 +54,9 @@
> >>>          this(name, name, Collections.EMPTY_LIST, type);
> >>>      }
> >>>
> >>> -    public GOperationInfo(String name, Class[] paramTypes,
> String
> >>
> >>> type) {
> >>> +    public GOperationInfo(String name, Class[] paramTypes,
> String
> >>
> >>> returnType) {
> >>>          this.name = this.methodName = name;
> >>> -        this.type = type;
> >>> +        this.returnType = returnType;
> >>>          String[] args = new String[paramTypes.length];
> >>>          for (int i = 0; i < args.length; i++) {
> >>>              args[i] = paramTypes[i].getName();
> >>> @@ -64,17 +64,17 @@
> >>>          this.parameters = Collections.unmodifiableList
> >>> (Arrays.asList(args));
> >>>      }
> >>>
> >>> -    public GOperationInfo(String name, String[] paramTypes,
> String
> >>
> >>> type) {
> >>> -        this(name, name, Arrays.asList(paramTypes), type);
> >>> +    public GOperationInfo(String name, String[] paramTypes,
> String
> >>
> >>> returnType) {
> >>> +        this(name, name, Arrays.asList(paramTypes), returnType);
> >>>      }
> >>>
> >>> -    public GOperationInfo(String name, List parameters, String
> >>> type) {
> 
=== message truncated ===



 
____________________________________________________________________________________
It's here! Your new message!  
Get new email alerts with the free Yahoo! Toolbar.
http://tools.search.yahoo.com/toolbar/features/mail/

Re: svn commit: r499201 - in /geronimo/server/trunk/modules/geronimo-kernel/src: main/java/org/apache/geronimo/gbean/ main/java/org/apache/geronimo/gbean/runtime/ test/java/org/apache/geronimo/gbean/

Posted by Dain Sundstrom <da...@iq80.com>.
When that code used to be in the PersistenceUnitReference class when  
you would deploy an application with a persistence unit reference and  
you looked up that refernce... you would get an exception saying that  
there is no operation named getEntityManagerFactory of that bean.

You can most likely reproduce this by creating a standard gbean like  
this:

public class SomeGBean {
    private String foo;
    public String getFoo() { return foo; }
    public void setFoo(String foo { this.foo = foo; }
}

then call this

kernel.setAttribute(name, "foo", "bar");
assertEquals("bar", kernel.getAttribute(name, "foo"));
assertEquals("bar", kernel.invoke(name, "getFoo"));

I'd guess that the second call will fail with your patch, because the  
the getter and setters exposed as operations (just as an attribute).   
This is just my guess.

-dain

On Feb 1, 2007, at 8:14 PM, anita kulshreshtha wrote:

> Dain,
>    Could you please provide some information on how to reproduce this
> failure?
>
> Thanks
> Anita
>
> --- Dain Sundstrom <da...@iq80.com> wrote:
>
>> I think this has broken some stuff.  This piece of code in
>> PersistenceUnitReference is no longer working:
>>
>>          entityManagerFactory = kernel.invoke(target,
>> "getEntityManagerFactory");
>>
>> I'll try to code around the problem for this instance, but you may
>> want to roll back this commit.
>>
>> -dain
>>
>> On Jan 23, 2007, at 4:55 PM, hogstrom@apache.org wrote:
>>
>>> Author: hogstrom
>>> Date: Tue Jan 23 16:55:35 2007
>>> New Revision: 499201
>>>
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=499201
>>> Log:
>>> GERONIMO-2607 : Deprecated old addOperation methods, added private
>>> addOperation methods
>>>                 updated GBeanInfoTest
>>>                 Modified GBeanOperation, this class is not
>> serialized
>>>
>>> Modified:
>>>
>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
>>> apache/geronimo/gbean/GBeanInfoBuilder.java
>>>
>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
>>> apache/geronimo/gbean/GOperationInfo.java
>>>
>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
>>> apache/geronimo/gbean/runtime/GBeanOperation.java
>>>
>> geronimo/server/trunk/modules/geronimo-kernel/src/test/java/org/
>>> apache/geronimo/gbean/GBeanInfoTest.java
>>>
>>> Modified: geronimo/server/trunk/modules/geronimo-kernel/src/main/
>>> java/org/apache/geronimo/gbean/GBeanInfoBuilder.java
>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/
>>> geronimo-kernel/src/main/java/org/apache/geronimo/gbean/
>>> GBeanInfoBuilder.java?view=diff&rev=499201&r1=499200&r2=499201
>>>
>>
> ======================================================================
>>
>>> ========
>>> ---
>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
>>> apache/geronimo/gbean/GBeanInfoBuilder.java (original)
>>> +++
>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
>>> apache/geronimo/gbean/GBeanInfoBuilder.java Tue Jan 23 16:55:35
>> 2007
>>> @@ -403,23 +403,23 @@
>>>
>>>      /**
>>>       * @deprecated
>>> -     */
>>> +     */
>>>      public void addOperation(String name) {
>>> -        addOperation(new GOperationInfo(name, NO_ARGS, ""));
>>> +        //addOperation(new GOperationInfo(name, NO_ARGS, ""));
>>>      }
>>>
>>>      /**
>>>       * @deprecated
>>>       */
>>>      public void addOperation(String name, Class[] paramTypes) {
>>> -        addOperation(new GOperationInfo(name, paramTypes, ""));
>>> +        //addOperation(new GOperationInfo(name, paramTypes, ""));
>>>      }
>>>
>>> -    public void addOperation(String name, String returnType) {
>>> +    private void addOperation(String name, String returnType) {
>>>          addOperation(new GOperationInfo(name, NO_ARGS,
>> returnType));
>>>      }
>>>
>>> -    public void addOperation(String name, Class[] paramTypes,
>>> String returnType) {
>>> +    private void addOperation(String name, Class[] paramTypes,
>>> String returnType) {
>>>          addOperation(new GOperationInfo(name, paramTypes,
>>> returnType));
>>>      }
>>>
>>>
>>> Modified: geronimo/server/trunk/modules/geronimo-kernel/src/main/
>>> java/org/apache/geronimo/gbean/GOperationInfo.java
>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/
>>> geronimo-kernel/src/main/java/org/apache/geronimo/gbean/
>>> GOperationInfo.java?view=diff&rev=499201&r1=499200&r2=499201
>>>
>>
> ======================================================================
>>
>>> ========
>>> ---
>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
>>> apache/geronimo/gbean/GOperationInfo.java (original)
>>> +++
>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
>>> apache/geronimo/gbean/GOperationInfo.java Tue Jan 23 16:55:35 2007
>>> @@ -38,7 +38,7 @@
>>>      /**
>>>       * The return type of this method.
>>>       */
>>> -    private final String type;
>>> +    private final String returnType;
>>>
>>>      /**
>>>       * Parameters of this method.
>>> @@ -54,9 +54,9 @@
>>>          this(name, name, Collections.EMPTY_LIST, type);
>>>      }
>>>
>>> -    public GOperationInfo(String name, Class[] paramTypes, String
>>
>>> type) {
>>> +    public GOperationInfo(String name, Class[] paramTypes, String
>>
>>> returnType) {
>>>          this.name = this.methodName = name;
>>> -        this.type = type;
>>> +        this.returnType = returnType;
>>>          String[] args = new String[paramTypes.length];
>>>          for (int i = 0; i < args.length; i++) {
>>>              args[i] = paramTypes[i].getName();
>>> @@ -64,17 +64,17 @@
>>>          this.parameters = Collections.unmodifiableList
>>> (Arrays.asList(args));
>>>      }
>>>
>>> -    public GOperationInfo(String name, String[] paramTypes, String
>>
>>> type) {
>>> -        this(name, name, Arrays.asList(paramTypes), type);
>>> +    public GOperationInfo(String name, String[] paramTypes, String
>>
>>> returnType) {
>>> +        this(name, name, Arrays.asList(paramTypes), returnType);
>>>      }
>>>
>>> -    public GOperationInfo(String name, List parameters, String
>>> type) {
>>> -        this(name, name, parameters, type);
>>> +    public GOperationInfo(String name, List parameters, String
>>> returnType) {
>>> +        this(name, name, parameters, returnType);
>>>      }
>>>
>>> -    public GOperationInfo(String name, String methodName, List
>>> parameters, String type) {
>>> +    public GOperationInfo(String name, String methodName, List
>>> parameters, String returnType) {
>>>          this.name = name;
>>> -        this.type = type;
>>> +        this.returnType = returnType;
>>>          this.methodName = methodName;
>>>          this.parameters = Collections.unmodifiableList(new
>>> ArrayList(parameters));
>>>      }
>>> @@ -84,7 +84,7 @@
>>>      }
>>>
>>>      public String getReturnType() {
>>> -        return type;
>>> +        return returnType;
>>>      }
>>>
>>>      public String getMethodName() {
>>> @@ -96,6 +96,6 @@
>>>      }
>>>
>>>      public String toString() {
>>> -        return "[GOperationInfo: name=" + name + " parameters=" +
>>
>>> parameters + " type =" + type + "]";
>>> +        return "[GOperationInfo: name=" + name + " parameters=" +
>>
>>> parameters + " returnType =" + returnType + "]";
>>>      }
>>>  }
>>>
>>> Modified: geronimo/server/trunk/modules/geronimo-kernel/src/main/
>>> java/org/apache/geronimo/gbean/runtime/GBeanOperation.java
>>> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/
>>> geronimo-kernel/src/main/java/org/apache/geronimo/gbean/runtime/
>>> GBeanOperation.java?view=diff&rev=499201&r1=499200&r2=499201
>>>
>>
> ======================================================================
>>
>>> ========
>>> ---
>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
>>> apache/geronimo/gbean/runtime/GBeanOperation.java (original)
>>> +++
>> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/
>>> apache/geronimo/gbean/runtime/GBeanOperation.java Tue Jan 23
>>> 16:55:35 2007
>>
> === message truncated ===
>
>
>
>
> ______________________________________________________________________ 
> ______________
> Sucker-punch spam with award-winning protection.
> Try the free Yahoo! Mail Beta.
> http://advision.webevents.yahoo.com/mailbeta/features_spam.html


Re: svn commit: r499201 - in /geronimo/server/trunk/modules/geronimo-kernel/src: main/java/org/apache/geronimo/gbean/ main/java/org/apache/geronimo/gbean/runtime/ test/java/org/apache/geronimo/gbean/

Posted by anita kulshreshtha <a_...@yahoo.com>.
Dain,
   Could you please provide some information on how to reproduce this
failure?

Thanks
Anita

--- Dain Sundstrom <da...@iq80.com> wrote:

> I think this has broken some stuff.  This piece of code in  
> PersistenceUnitReference is no longer working:
> 
>          entityManagerFactory = kernel.invoke(target,  
> "getEntityManagerFactory");
> 
> I'll try to code around the problem for this instance, but you may  
> want to roll back this commit.
> 
> -dain
> 
> On Jan 23, 2007, at 4:55 PM, hogstrom@apache.org wrote:
> 
> > Author: hogstrom
> > Date: Tue Jan 23 16:55:35 2007
> > New Revision: 499201
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=499201
> > Log:
> > GERONIMO-2607 : Deprecated old addOperation methods, added private
> > addOperation methods
> >                 updated GBeanInfoTest
> >                 Modified GBeanOperation, this class is not
> serialized
> >
> > Modified:
> >    
> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/ 
> > apache/geronimo/gbean/GBeanInfoBuilder.java
> >    
> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/ 
> > apache/geronimo/gbean/GOperationInfo.java
> >    
> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/ 
> > apache/geronimo/gbean/runtime/GBeanOperation.java
> >    
> geronimo/server/trunk/modules/geronimo-kernel/src/test/java/org/ 
> > apache/geronimo/gbean/GBeanInfoTest.java
> >
> > Modified: geronimo/server/trunk/modules/geronimo-kernel/src/main/ 
> > java/org/apache/geronimo/gbean/GBeanInfoBuilder.java
> > URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/ 
> > geronimo-kernel/src/main/java/org/apache/geronimo/gbean/ 
> > GBeanInfoBuilder.java?view=diff&rev=499201&r1=499200&r2=499201
> >
>
======================================================================
> 
> > ========
> > ---
> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/ 
> > apache/geronimo/gbean/GBeanInfoBuilder.java (original)
> > +++
> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/ 
> > apache/geronimo/gbean/GBeanInfoBuilder.java Tue Jan 23 16:55:35
> 2007
> > @@ -403,23 +403,23 @@
> >
> >      /**
> >       * @deprecated
> > -     */
> > +     */
> >      public void addOperation(String name) {
> > -        addOperation(new GOperationInfo(name, NO_ARGS, ""));
> > +        //addOperation(new GOperationInfo(name, NO_ARGS, ""));
> >      }
> >
> >      /**
> >       * @deprecated
> >       */
> >      public void addOperation(String name, Class[] paramTypes) {
> > -        addOperation(new GOperationInfo(name, paramTypes, ""));
> > +        //addOperation(new GOperationInfo(name, paramTypes, ""));
> >      }
> >
> > -    public void addOperation(String name, String returnType) {
> > +    private void addOperation(String name, String returnType) {
> >          addOperation(new GOperationInfo(name, NO_ARGS,
> returnType));
> >      }
> >
> > -    public void addOperation(String name, Class[] paramTypes,  
> > String returnType) {
> > +    private void addOperation(String name, Class[] paramTypes,  
> > String returnType) {
> >          addOperation(new GOperationInfo(name, paramTypes,  
> > returnType));
> >      }
> >
> >
> > Modified: geronimo/server/trunk/modules/geronimo-kernel/src/main/ 
> > java/org/apache/geronimo/gbean/GOperationInfo.java
> > URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/ 
> > geronimo-kernel/src/main/java/org/apache/geronimo/gbean/ 
> > GOperationInfo.java?view=diff&rev=499201&r1=499200&r2=499201
> >
>
======================================================================
> 
> > ========
> > ---
> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/ 
> > apache/geronimo/gbean/GOperationInfo.java (original)
> > +++
> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/ 
> > apache/geronimo/gbean/GOperationInfo.java Tue Jan 23 16:55:35 2007
> > @@ -38,7 +38,7 @@
> >      /**
> >       * The return type of this method.
> >       */
> > -    private final String type;
> > +    private final String returnType;
> >
> >      /**
> >       * Parameters of this method.
> > @@ -54,9 +54,9 @@
> >          this(name, name, Collections.EMPTY_LIST, type);
> >      }
> >
> > -    public GOperationInfo(String name, Class[] paramTypes, String 
> 
> > type) {
> > +    public GOperationInfo(String name, Class[] paramTypes, String 
> 
> > returnType) {
> >          this.name = this.methodName = name;
> > -        this.type = type;
> > +        this.returnType = returnType;
> >          String[] args = new String[paramTypes.length];
> >          for (int i = 0; i < args.length; i++) {
> >              args[i] = paramTypes[i].getName();
> > @@ -64,17 +64,17 @@
> >          this.parameters = Collections.unmodifiableList 
> > (Arrays.asList(args));
> >      }
> >
> > -    public GOperationInfo(String name, String[] paramTypes, String
>  
> > type) {
> > -        this(name, name, Arrays.asList(paramTypes), type);
> > +    public GOperationInfo(String name, String[] paramTypes, String
>  
> > returnType) {
> > +        this(name, name, Arrays.asList(paramTypes), returnType);
> >      }
> >
> > -    public GOperationInfo(String name, List parameters, String  
> > type) {
> > -        this(name, name, parameters, type);
> > +    public GOperationInfo(String name, List parameters, String  
> > returnType) {
> > +        this(name, name, parameters, returnType);
> >      }
> >
> > -    public GOperationInfo(String name, String methodName, List  
> > parameters, String type) {
> > +    public GOperationInfo(String name, String methodName, List  
> > parameters, String returnType) {
> >          this.name = name;
> > -        this.type = type;
> > +        this.returnType = returnType;
> >          this.methodName = methodName;
> >          this.parameters = Collections.unmodifiableList(new  
> > ArrayList(parameters));
> >      }
> > @@ -84,7 +84,7 @@
> >      }
> >
> >      public String getReturnType() {
> > -        return type;
> > +        return returnType;
> >      }
> >
> >      public String getMethodName() {
> > @@ -96,6 +96,6 @@
> >      }
> >
> >      public String toString() {
> > -        return "[GOperationInfo: name=" + name + " parameters=" + 
> 
> > parameters + " type =" + type + "]";
> > +        return "[GOperationInfo: name=" + name + " parameters=" + 
> 
> > parameters + " returnType =" + returnType + "]";
> >      }
> >  }
> >
> > Modified: geronimo/server/trunk/modules/geronimo-kernel/src/main/ 
> > java/org/apache/geronimo/gbean/runtime/GBeanOperation.java
> > URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/ 
> > geronimo-kernel/src/main/java/org/apache/geronimo/gbean/runtime/ 
> > GBeanOperation.java?view=diff&rev=499201&r1=499200&r2=499201
> >
>
======================================================================
> 
> > ========
> > ---
> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/ 
> > apache/geronimo/gbean/runtime/GBeanOperation.java (original)
> > +++
> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/ 
> > apache/geronimo/gbean/runtime/GBeanOperation.java Tue Jan 23  
> > 16:55:35 2007
> 
=== message truncated ===



 
____________________________________________________________________________________
Sucker-punch spam with award-winning protection. 
Try the free Yahoo! Mail Beta.
http://advision.webevents.yahoo.com/mailbeta/features_spam.html

Re: svn commit: r499201 - in /geronimo/server/trunk/modules/geronimo-kernel/src: main/java/org/apache/geronimo/gbean/ main/java/org/apache/geronimo/gbean/runtime/ test/java/org/apache/geronimo/gbean/

Posted by anita kulshreshtha <a_...@yahoo.com>.
  Could you please provide some more information?

Thanks
Anita

--- Dain Sundstrom <da...@iq80.com> wrote:

> I think this has broken some stuff.  This piece of code in  
> PersistenceUnitReference is no longer working:
> 
>          entityManagerFactory = kernel.invoke(target,  
> "getEntityManagerFactory");
> 
> I'll try to code around the problem for this instance, but you may  
> want to roll back this commit.
> 
> -dain
> 
> On Jan 23, 2007, at 4:55 PM, hogstrom@apache.org wrote:
> 
> > Author: hogstrom
> > Date: Tue Jan 23 16:55:35 2007
> > New Revision: 499201
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=499201
> > Log:
> > GERONIMO-2607 : Deprecated old addOperation methods, added private
> > addOperation methods
> >                 updated GBeanInfoTest
> >                 Modified GBeanOperation, this class is not
> serialized
> >
> > Modified:
> >    
> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/ 
> > apache/geronimo/gbean/GBeanInfoBuilder.java
> >    
> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/ 
> > apache/geronimo/gbean/GOperationInfo.java
> >    
> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/ 
> > apache/geronimo/gbean/runtime/GBeanOperation.java
> >    
> geronimo/server/trunk/modules/geronimo-kernel/src/test/java/org/ 
> > apache/geronimo/gbean/GBeanInfoTest.java
> >
> > Modified: geronimo/server/trunk/modules/geronimo-kernel/src/main/ 
> > java/org/apache/geronimo/gbean/GBeanInfoBuilder.java
> > URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/ 
> > geronimo-kernel/src/main/java/org/apache/geronimo/gbean/ 
> > GBeanInfoBuilder.java?view=diff&rev=499201&r1=499200&r2=499201
> >
>
======================================================================
> 
> > ========
> > ---
> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/ 
> > apache/geronimo/gbean/GBeanInfoBuilder.java (original)
> > +++
> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/ 
> > apache/geronimo/gbean/GBeanInfoBuilder.java Tue Jan 23 16:55:35
> 2007
> > @@ -403,23 +403,23 @@
> >
> >      /**
> >       * @deprecated
> > -     */
> > +     */
> >      public void addOperation(String name) {
> > -        addOperation(new GOperationInfo(name, NO_ARGS, ""));
> > +        //addOperation(new GOperationInfo(name, NO_ARGS, ""));
> >      }
> >
> >      /**
> >       * @deprecated
> >       */
> >      public void addOperation(String name, Class[] paramTypes) {
> > -        addOperation(new GOperationInfo(name, paramTypes, ""));
> > +        //addOperation(new GOperationInfo(name, paramTypes, ""));
> >      }
> >
> > -    public void addOperation(String name, String returnType) {
> > +    private void addOperation(String name, String returnType) {
> >          addOperation(new GOperationInfo(name, NO_ARGS,
> returnType));
> >      }
> >
> > -    public void addOperation(String name, Class[] paramTypes,  
> > String returnType) {
> > +    private void addOperation(String name, Class[] paramTypes,  
> > String returnType) {
> >          addOperation(new GOperationInfo(name, paramTypes,  
> > returnType));
> >      }
> >
> >
> > Modified: geronimo/server/trunk/modules/geronimo-kernel/src/main/ 
> > java/org/apache/geronimo/gbean/GOperationInfo.java
> > URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/ 
> > geronimo-kernel/src/main/java/org/apache/geronimo/gbean/ 
> > GOperationInfo.java?view=diff&rev=499201&r1=499200&r2=499201
> >
>
======================================================================
> 
> > ========
> > ---
> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/ 
> > apache/geronimo/gbean/GOperationInfo.java (original)
> > +++
> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/ 
> > apache/geronimo/gbean/GOperationInfo.java Tue Jan 23 16:55:35 2007
> > @@ -38,7 +38,7 @@
> >      /**
> >       * The return type of this method.
> >       */
> > -    private final String type;
> > +    private final String returnType;
> >
> >      /**
> >       * Parameters of this method.
> > @@ -54,9 +54,9 @@
> >          this(name, name, Collections.EMPTY_LIST, type);
> >      }
> >
> > -    public GOperationInfo(String name, Class[] paramTypes, String 
> 
> > type) {
> > +    public GOperationInfo(String name, Class[] paramTypes, String 
> 
> > returnType) {
> >          this.name = this.methodName = name;
> > -        this.type = type;
> > +        this.returnType = returnType;
> >          String[] args = new String[paramTypes.length];
> >          for (int i = 0; i < args.length; i++) {
> >              args[i] = paramTypes[i].getName();
> > @@ -64,17 +64,17 @@
> >          this.parameters = Collections.unmodifiableList 
> > (Arrays.asList(args));
> >      }
> >
> > -    public GOperationInfo(String name, String[] paramTypes, String
>  
> > type) {
> > -        this(name, name, Arrays.asList(paramTypes), type);
> > +    public GOperationInfo(String name, String[] paramTypes, String
>  
> > returnType) {
> > +        this(name, name, Arrays.asList(paramTypes), returnType);
> >      }
> >
> > -    public GOperationInfo(String name, List parameters, String  
> > type) {
> > -        this(name, name, parameters, type);
> > +    public GOperationInfo(String name, List parameters, String  
> > returnType) {
> > +        this(name, name, parameters, returnType);
> >      }
> >
> > -    public GOperationInfo(String name, String methodName, List  
> > parameters, String type) {
> > +    public GOperationInfo(String name, String methodName, List  
> > parameters, String returnType) {
> >          this.name = name;
> > -        this.type = type;
> > +        this.returnType = returnType;
> >          this.methodName = methodName;
> >          this.parameters = Collections.unmodifiableList(new  
> > ArrayList(parameters));
> >      }
> > @@ -84,7 +84,7 @@
> >      }
> >
> >      public String getReturnType() {
> > -        return type;
> > +        return returnType;
> >      }
> >
> >      public String getMethodName() {
> > @@ -96,6 +96,6 @@
> >      }
> >
> >      public String toString() {
> > -        return "[GOperationInfo: name=" + name + " parameters=" + 
> 
> > parameters + " type =" + type + "]";
> > +        return "[GOperationInfo: name=" + name + " parameters=" + 
> 
> > parameters + " returnType =" + returnType + "]";
> >      }
> >  }
> >
> > Modified: geronimo/server/trunk/modules/geronimo-kernel/src/main/ 
> > java/org/apache/geronimo/gbean/runtime/GBeanOperation.java
> > URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/ 
> > geronimo-kernel/src/main/java/org/apache/geronimo/gbean/runtime/ 
> > GBeanOperation.java?view=diff&rev=499201&r1=499200&r2=499201
> >
>
======================================================================
> 
> > ========
> > ---
> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/ 
> > apache/geronimo/gbean/runtime/GBeanOperation.java (original)
> > +++
> geronimo/server/trunk/modules/geronimo-kernel/src/main/java/org/ 
> > apache/geronimo/gbean/runtime/GBeanOperation.java Tue Jan 23  
> > 16:55:35 2007
> 
=== message truncated ===



 
____________________________________________________________________________________
Do you Yahoo!?
Everyone is raving about the all-new Yahoo! Mail beta.
http://new.mail.yahoo.com