You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "SAlexandru (via GitHub)" <gi...@apache.org> on 2026/10/05 18:31:24 UTC

[PR] [BP-1.20][FLINK-40657][connector-base] Release per-fetcher state in FutureCompletingBlockingQueue. [flink]

SAlexandru opened a new pull request, #29389:
URL: https://github.com/apache/flink/pull/29389

    Backport of #29218 to release-1.20.
   The production change is identical: the per-producer state map in FutureCompletingBlockingQueue and releaseProducer() in the SplitFetcherManager shutdown hook.
   Test adaptations, because release-1.20 doesn't have FLINK-35924 (no records-processed latch / shutdown synchronization batch in SplitFetcher):
     - testFetcherShutdownReleasesWakeupStateAcrossLifecycles creates the producer state with an explicit wakeUpPuttingThread instead of relying on the synchronization batch, and uses CommonTestUtils.waitUntilCondition (TestUtils.waitUntil came with FLINK-35924).
     - testFailedFetcherIsNotReapedAndIsCleanedUpOnClose is omitted: without the latch, a failed fetcher closes its reader and runs its shutdown hook immediately, so it cannot be stranded.
    - The new tests are public, since the 1.20 test classes are JUnit 4.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [BP-1.20][FLINK-40657][connector-base] Release per-fetcher state in FutureCompletingBlockingQueue. [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #29389:
URL: https://github.com/apache/flink/pull/29389#issuecomment-6000769642

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9d068ac436eeca7225f09b1ad2ea0228a14e806e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9d068ac436eeca7225f09b1ad2ea0228a14e806e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9d068ac436eeca7225f09b1ad2ea0228a14e806e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [BP-1.20][FLINK-40657][connector-base] Release per-fetcher state in FutureCompletingBlockingQueue. [flink]

Posted by "SAlexandru (via GitHub)" <gi...@apache.org>.
SAlexandru commented on PR #29389:
URL: https://github.com/apache/flink/pull/29389#issuecomment-6111615645

   > Thanks for the backport. GitHub currently reports merge conflicts with release-1.20. Could you please update the branch and resolve the conflicts? The production fix matches the master change, while the tests have been adapted for 1.20; please rerun the relevant checks after updating.
   
   cool, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [BP-1.20][FLINK-40657][connector-base] Release per-fetcher state in FutureCompletingBlockingQueue. [flink]

Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on PR #29389:
URL: https://github.com/apache/flink/pull/29389#issuecomment-6097575512

   Thanks for the backport. GitHub currently reports merge conflicts with release-1.20. Could you please update the branch and resolve the conflicts? The production fix matches the master change, while the tests have been adapted for 1.20; please rerun the relevant checks after updating.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [BP-1.20][FLINK-40657][connector-base] Release per-fetcher state in FutureCompletingBlockingQueue. [flink]

Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui merged PR #29389:
URL: https://github.com/apache/flink/pull/29389


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org