You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by ramkrish86 <gi...@git.apache.org> on 2014/09/04 08:48:51 UTC
[GitHub] phoenix pull request: Phoenix 180 1
GitHub user ramkrish86 opened a pull request:
https://github.com/apache/phoenix/pull/10
Phoenix 180 1
A new pull request with updated comments. Still trying to test the performance with these changes.
-> Test cases are not running and all the test cases are failing at the deleteTable sequence.
-> The checking of the timestamp stored in the table and avoiding concurrent update stats does not work. I am checking on it.
-> The clearing of the metadata cache should happen in a lock? If so then we need to see every where (even while reading from the cache) we should introduce a new lock.
-> Estimated byte size() is yet to be added to Ptable
-> Multi CF is not yet tested.
But this would help in getting the review done on the latest changes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ramkrish86/phoenix-1 Phoenix-180_1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/phoenix/pull/10.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10
----
commit df59996c9c0b19a44262de36e28d34de910faaaa
Author: Ramkrishna <ra...@intel.com>
Date: 2014-08-22T08:48:19Z
Phoenix-180
commit 09f8ebdcc468ac9fdce9a62ea7377d62c294d2a9
Author: Ramkrishna <ra...@intel.com>
Date: 2014-08-25T12:45:26Z
Phoenix-180
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: Phoenix 180 1
Posted by ramkrish86 <gi...@git.apache.org>.
Github user ramkrish86 commented on the pull request:
https://github.com/apache/phoenix/pull/10#issuecomment-54418748
Pls use this https://github.com/apache/phoenix/pull/11
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: Phoenix 180 1
Posted by ramkrish86 <gi...@git.apache.org>.
Github user ramkrish86 commented on the pull request:
https://github.com/apache/phoenix/pull/10#issuecomment-55114041
Closing this as the pull moved over to https://github.com/apache/phoenix/pull/12.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: Phoenix 180 1
Posted by ramkrish86 <gi...@git.apache.org>.
Github user ramkrish86 commented on the pull request:
https://github.com/apache/phoenix/pull/10#issuecomment-54417314
Why is the pull request referring to the old branch ?
commit b4c0cb1df9fc43d76c43de052f5f8007b51b4909
Author: Ramkrishna <ra...@intel.com>
Date: Thu Sep 4 12:14:13 2014 +0530
Phoenix-180
commit 3abb90bb0fa0721a333f919f4d0c734cf51028fc
Author: Rajeshbabu Chintaguntla <ra...@huawei.com>
Date: Wed Sep 3 18:16:49 2014 +0800
PHOENIX-1139 Failed to disable local index when index update fails(addendum)
commit 845888bcb58a6fe5975de4cfabbe9266407de9dc
Author: Rajeshbabu Chintaguntla <ra...@apache.org>
This is what gets displayed in my local log history. And my branch is Phoenix-180_1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: Phoenix 180 1
Posted by ramkrish86 <gi...@git.apache.org>.
Github user ramkrish86 closed the pull request at:
https://github.com/apache/phoenix/pull/10
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: Phoenix 180 1
Posted by JamesRTaylor <gi...@git.apache.org>.
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/10#issuecomment-54418091
-> Test cases are not running and all the test cases are failing at the deleteTable sequence.
Post a stack trace - not sure offhand why this would be.
-> The checking of the timestamp stored in the table and avoiding concurrent update stats does not work. I am checking on it.
-> The clearing of the metadata cache should happen in a lock? If so then we need to see every where (even while reading from the cache) we should introduce a new lock.
We shouldn't need a new lock. What's wrong with the existing lock mechanism?
-> Estimated byte size() is yet to be added to Ptable
This should be easy to add - just have your PTableStats implement a getEstimatedSize() method and estimate based on the size of the guidepost array.
-> Multi CF is not yet tested.
No problem - you can do this after your initial perf testing.
But this would help in getting the review done on the latest changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---