You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joshua Cohen <jc...@apache.org> on 2016/03/10 22:59:44 UTC
Review Request 44680: Log exceptions raised when thermos running
attempts to execute a process.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44680/
-----------------------------------------------------------
Review request for Aurora and Zameer Manji.
Repository: aurora
Description
-------
Log exceptions raised when thermos running attempts to execute a process.
Diffs
-----
src/main/python/apache/thermos/core/process.py c343b2d1f3efc39ea8c445c93a9ac73a2bed3653
Diff: https://reviews.apache.org/r/44680/diff/
Testing
-------
./pants test src/test/python/apache/thermos/core/
Thanks,
Joshua Cohen
Re: Review Request 44680: Log exceptions raised when thermos running
attempts to execute a process.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44680/#review123036
-----------------------------------------------------------
@ReviewBot retry
- Joshua Cohen
On March 10, 2016, 10:36 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44680/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 10:36 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Log exceptions raised when thermos running attempts to execute a process.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/core/process.py c343b2d1f3efc39ea8c445c93a9ac73a2bed3653
>
> Diff: https://reviews.apache.org/r/44680/diff/
>
>
> Testing
> -------
>
> ./pants test src/test/python/apache/thermos/core/
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 44680: Log exceptions raised when thermos running
attempts to execute a process.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44680/#review123039
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On March 10, 2016, 2:36 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44680/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 2:36 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Log exceptions raised when thermos running attempts to execute a process.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/core/process.py c343b2d1f3efc39ea8c445c93a9ac73a2bed3653
>
> Diff: https://reviews.apache.org/r/44680/diff/
>
>
> Testing
> -------
>
> ./pants test src/test/python/apache/thermos/core/
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 44680: Log exceptions raised when thermos running
attempts to execute a process.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44680/#review123023
-----------------------------------------------------------
Master (72bf8db) is red with this patch.
./build-support/jenkins/build.sh
[1m self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m self._clock.assert_waiting(hct.threaded_health_checker, amount=1)[0m
[1m [0m
[1m assert hct._total_latency == 0[0m
[1m assert hct.metrics.sample()['total_latency_secs'] == 0[0m
[1m [0m
[1m # start the health check (during health check it is still 0)[0m
[1m epsilon = 0.001[0m
[1m self._clock.tick(1.0 + epsilon)[0m
[1m self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m self._clock.assert_waiting(hct.threaded_health_checker, amount=0.5)[0m
[1m assert hct._total_latency == 0[0m
[1m assert hct.metrics.sample()['total_latency_secs'] == 0[0m
[1m assert hct.metrics.sample()['checks'] == 0[0m
[1m [0m
[1m # finish the health check[0m
[1m self._clock.tick(0.5 + epsilon)[0m
[1m self._clock.converge(threads=[hct.threaded_health_checker])[0m
[1m self._clock.assert_waiting(hct.threaded_health_checker, amount=1) # interval_secs[0m
[1m> assert hct._total_latency == 0.5[0m
[1m[31mE AssertionError: assert 0.5009999999999999 == 0.5[0m
[1m[31mE + where 0.5009999999999999 = <apache.aurora.executor.common.health_checker.HealthChecker object at 0x7fbe7454ea50>._total_latency[0m
src/test/python/apache/aurora/executor/common/test_health_checker.py:174: AssertionError
-------------- Captured stderr call --------------
[<twitter.common.testing.clock.ThreadedClock object at 0x7fbe7454ecd0>] Time now: 0.0
[<twitter.common.testing.clock.ThreadedClock object at 0x7fbe7454ecd0>] Time now: 0.0
[<twitter.common.testing.clock.ThreadedClock object at 0x7fbe7454ecd0>] Time now: 1.0
[<twitter.common.testing.clock.ThreadedClock object at 0x7fbe7454ecd0>] Time now: 1.001
[<twitter.common.testing.clock.ThreadedClock object at 0x7fbe7454ecd0>] Time now: 1.001
[<twitter.common.testing.clock.ThreadedClock object at 0x7fbe7454ecd0>] Time now: 1.501
[<twitter.common.testing.clock.ThreadedClock object at 0x7fbe7454ecd0>] Time now: 1.502
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 1 failed, 661 passed, 5 skipped, 1 warnings in 406.83 seconds [0m
FAILURE
22:53:26 07:55 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 10, 2016, 10:36 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44680/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 10:36 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Log exceptions raised when thermos running attempts to execute a process.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/core/process.py c343b2d1f3efc39ea8c445c93a9ac73a2bed3653
>
> Diff: https://reviews.apache.org/r/44680/diff/
>
>
> Testing
> -------
>
> ./pants test src/test/python/apache/thermos/core/
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 44680: Log exceptions raised when thermos running
attempts to execute a process.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44680/#review123051
-----------------------------------------------------------
Master (72bf8db) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 10, 2016, 10:36 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44680/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 10:36 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Log exceptions raised when thermos running attempts to execute a process.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/core/process.py c343b2d1f3efc39ea8c445c93a9ac73a2bed3653
>
> Diff: https://reviews.apache.org/r/44680/diff/
>
>
> Testing
> -------
>
> ./pants test src/test/python/apache/thermos/core/
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 44680: Log exceptions raised when thermos running
attempts to execute a process.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44680/#review123026
-----------------------------------------------------------
@ReviewBot retry
- Joshua Cohen
On March 10, 2016, 10:36 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44680/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 10:36 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Log exceptions raised when thermos running attempts to execute a process.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/core/process.py c343b2d1f3efc39ea8c445c93a9ac73a2bed3653
>
> Diff: https://reviews.apache.org/r/44680/diff/
>
>
> Testing
> -------
>
> ./pants test src/test/python/apache/thermos/core/
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 44680: Log exceptions raised when thermos running
attempts to execute a process.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44680/#review123034
-----------------------------------------------------------
Master (72bf8db) is red with this patch.
./build-support/jenkins/build.sh
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
ERROR] Could not quitquitquit runner: Cannot take control of a task in terminal state.
E0310 23:38:24.844244 5806 thermos_task_runner.py:234] Could not quitquitquit runner: Cannot take control of a task in terminal state.
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 2 failed, 660 passed, 5 skipped, 1 warnings in 354.15 seconds [0m
FAILURE
23:39:47 06:59 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 10, 2016, 10:36 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44680/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 10:36 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Log exceptions raised when thermos running attempts to execute a process.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/core/process.py c343b2d1f3efc39ea8c445c93a9ac73a2bed3653
>
> Diff: https://reviews.apache.org/r/44680/diff/
>
>
> Testing
> -------
>
> ./pants test src/test/python/apache/thermos/core/
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 44680: Log exceptions raised when thermos running
attempts to execute a process.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44680/
-----------------------------------------------------------
(Updated March 10, 2016, 10:36 p.m.)
Review request for Aurora and Zameer Manji.
Changes
-------
re-raise exception after logging.
Repository: aurora
Description
-------
Log exceptions raised when thermos running attempts to execute a process.
Diffs (updated)
-----
src/main/python/apache/thermos/core/process.py c343b2d1f3efc39ea8c445c93a9ac73a2bed3653
Diff: https://reviews.apache.org/r/44680/diff/
Testing
-------
./pants test src/test/python/apache/thermos/core/
Thanks,
Joshua Cohen
Re: Review Request 44680: Log exceptions raised when thermos running
attempts to execute a process.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44680/#review123013
-----------------------------------------------------------
Master (72bf8db) is red with this patch.
./build-support/jenkins/build.sh
[1m proxy_driver = ProxyDriver()[0m
[1m with temporary_dir() as checkpoint_root:[0m
[1m te = AuroraExecutor([0m
[1m> runner_provider=make_provider(checkpoint_root),[0m
[1m sandbox_provider=DefaultTestSandboxProvider())[0m
src/test/python/apache/aurora/executor/test_thermos_executor.py:580:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in make_provider
[1m pex_location=thermos_runner_path(),[0m
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
build = True
[1m def thermos_runner_path(build=True):[0m
[1m if not build:[0m
[1m return getattr(thermos_runner_path, 'value', None)[0m
[1m [0m
[1m if not hasattr(thermos_runner_path, 'value'):[0m
[1m pex_dir = safe_mkdtemp()[0m
[1m> assert subprocess.call(["./pants", "--pants-distdir=%s" % pex_dir, "binary",[0m
[1m "src/main/python/apache/thermos/runner:thermos_runner"]) == 0[0m
[1m[31mE assert 1 == 0[0m
[1m[31mE + where 1 = <function call at 0x7f3cf0571b18>(['./pants', '--pants-distdir=/tmp/user/10021/tmptabPnG', 'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])[0m
[1m[31mE + where <function call at 0x7f3cf0571b18> = subprocess.call[0m
src/test/python/apache/aurora/executor/test_thermos_executor.py:185: AssertionError
-------------- Captured stderr call --------------
Traceback (most recent call last):
File "/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.75/bin/pants", line 7, in <module>
from pants.bin.pants_exe import main
ImportError: No module named pants.bin.pants_exe
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 16 failed, 638 passed, 5 skipped, 1 warnings, 8 error in 238.39 seconds [0m
FAILURE
22:22:42 04:51 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 10, 2016, 9:59 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44680/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 9:59 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Log exceptions raised when thermos running attempts to execute a process.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/core/process.py c343b2d1f3efc39ea8c445c93a9ac73a2bed3653
>
> Diff: https://reviews.apache.org/r/44680/diff/
>
>
> Testing
> -------
>
> ./pants test src/test/python/apache/thermos/core/
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 44680: Log exceptions raised when thermos running
attempts to execute a process.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44680/#review123010
-----------------------------------------------------------
src/main/python/apache/thermos/core/process.py (line 289)
<https://reviews.apache.org/r/44680/#comment185134>
I'm not sure if there's anything up the call stack that also tries to catch exceptions here? Would it be wise to re-raise?
- Joshua Cohen
On March 10, 2016, 9:59 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44680/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 9:59 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Log exceptions raised when thermos running attempts to execute a process.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/core/process.py c343b2d1f3efc39ea8c445c93a9ac73a2bed3653
>
> Diff: https://reviews.apache.org/r/44680/diff/
>
>
> Testing
> -------
>
> ./pants test src/test/python/apache/thermos/core/
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 44680: Log exceptions raised when thermos running
attempts to execute a process.
Posted by Joshua Cohen <jc...@apache.org>.
> On March 10, 2016, 10:27 p.m., Stephan Erb wrote:
> > +1 for re-raising.
Thanks for confirming. Will update.
> On March 10, 2016, 10:27 p.m., Stephan Erb wrote:
> > src/main/python/apache/thermos/core/process.py, line 151
> > <https://reviews.apache.org/r/44680/diff/1/?file=1294932#file1294932line151>
> >
> > This means we would log the error as debug.
> >
> > It has always bugged me that thermos logging was set to debug by default. Now I know why :-). Unfortunate
Yeah, I agree that it's unfortunate (also unfortunate: we don't get meaningful line numbers from log entries either because of this indirection) but I didn't want to shave that yak as part of this change ;).
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44680/#review123014
-----------------------------------------------------------
On March 10, 2016, 9:59 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44680/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 9:59 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Log exceptions raised when thermos running attempts to execute a process.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/core/process.py c343b2d1f3efc39ea8c445c93a9ac73a2bed3653
>
> Diff: https://reviews.apache.org/r/44680/diff/
>
>
> Testing
> -------
>
> ./pants test src/test/python/apache/thermos/core/
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 44680: Log exceptions raised when thermos running
attempts to execute a process.
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44680/#review123014
-----------------------------------------------------------
+1 for re-raising.
src/main/python/apache/thermos/core/process.py (line 151)
<https://reviews.apache.org/r/44680/#comment185141>
This means we would log the error as debug.
It has always bugged me that thermos logging was set to debug by default. Now I know why :-). Unfortunate
- Stephan Erb
On März 10, 2016, 10:59 nachm., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44680/
> -----------------------------------------------------------
>
> (Updated März 10, 2016, 10:59 nachm.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Log exceptions raised when thermos running attempts to execute a process.
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/core/process.py c343b2d1f3efc39ea8c445c93a9ac73a2bed3653
>
> Diff: https://reviews.apache.org/r/44680/diff/
>
>
> Testing
> -------
>
> ./pants test src/test/python/apache/thermos/core/
>
>
> Thanks,
>
> Joshua Cohen
>
>