You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/03 02:52:45 UTC

[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #226: chore: change the load balancer type and enhance the value check

codecov-io edited a comment on pull request #226:
URL: https://github.com/apache/apisix-ingress-controller/pull/226#issuecomment-772176596


   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/226?src=pr&el=h1) Report
   > Merging [#226](https://codecov.io/gh/apache/apisix-ingress-controller/pull/226?src=pr&el=desc) (83f7e24) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/e1a85f165d16b6d9d2dd78270f2a45c2abf586f0?el=desc) (e1a85f1) will **increase** coverage by `0.58%`.
   > The diff coverage is `54.16%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-ingress-controller/pull/226/graphs/tree.svg?width=650&height=150&src=pr&token=WPLQXPY3V0)](https://codecov.io/gh/apache/apisix-ingress-controller/pull/226?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #226      +/-   ##
   ==========================================
   + Coverage   44.80%   45.38%   +0.58%     
   ==========================================
     Files          34       34              
     Lines        2029     2036       +7     
   ==========================================
   + Hits          909      924      +15     
   + Misses        981      974       -7     
   + Partials      139      138       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/226?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [pkg/ingress/apisix/upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/226/diff?src=pr&el=tree#diff-cGtnL2luZ3Jlc3MvYXBpc2l4L3Vwc3RyZWFtLmdv) | `72.91% <54.16%> (-14.89%)` | :arrow_down: |
   | [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/226/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `41.72% <0.00%> (+1.98%)` | :arrow_up: |
   | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/226/diff?src=pr&el=tree#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `35.07% <0.00%> (+6.16%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/226?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/226?src=pr&el=footer). Last update [e1a85f1...83f7e24](https://codecov.io/gh/apache/apisix-ingress-controller/pull/226?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org