You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by "Geir Magnusson Jr." <ge...@pobox.com> on 2006/09/07 06:33:13 UTC
[vote] HARMONY-1363 - DRLVM fixes and additions
All is in order and in SVN for Harmony-1225 wrt BCC and ACQ. I think
that this an important patch so we can get better 1.5 support et al.
Please vote to accept or reject this set of patches and fixes into the
Apache Harmony class library :
[ ] + 1 Accept
[ ] -1 Reject (provide reason below)
Lets let this run a minimum of 3 days unless a) someone states they need
more time or b) we get all committer votes before then.
geir
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [vote] HARMONY-1363 - DRLVM fixes and additions
Posted by Mikhail Fursov <mi...@gmail.com>.
+1
There are a lot of features in this JIRA that will simplify learning DRLVM
for new developers.
+ Geir's patch to EM looks reasonable. The simplest way to merge is to get
the version from this JIRA and replace the method's body
(buildDefaultLibPath) with Geir's code.
On 9/7/06, Geir Magnusson Jr. <ge...@pobox.com> wrote:
>
> thats something I just changed yesterday...
>
> Alexey Petrenko wrote:
> > Guys,
> >
> > I've tried a patch.
> > Patch failed in ./vm/em/src/DrlEMImpl.cpp. On Linux and Windows.
> > Here is a rej file:
> > === cut ===
> > ***************
> > *** 151,165 ****
> > //_____________________________________________________________________
> > // Reading and parsing configuration
> >
> >
> > - std::string buildDefaultLibPath(const std::string& dll_name) {
> > - std::string library_path =
> > vm_get_property_value("vm.boot.library.path");
> > #ifdef PLATFORM_NT
> > - std::string fullPath = library_path + "\\"+ dll_name+".dll";
> > - #else
> > - std::string fullPath = library_path + "/lib" + dll_name + ".so";
> > #endif
> > - return fullPath;
> > }
> >
> > static std::string getParam(const std::string& config, const
> > std::string& name) {
> > --- 167,198 ----
> > //_____________________________________________________________________
> > // Reading and parsing configuration
> >
> > + static bool endsWith(const std::string& str, const std::string&
> suffix) {
> > + if (str.length() < suffix.length()) {
> > + return false;
> > + }
> > + return std::equal(suffix.rbegin(), suffix.rend(), str.rbegin());
> > + }
> >
> > + std::string prepareLibPath(const std::string& origPath) {
> > #ifdef PLATFORM_NT
> > + std::string separator("\\"), libPrefix(""), libSuffix(".dll");
> > + #else
> > + std::string separator("/"), libPrefix("lib"), libSuffix(".so");
> > #endif
> > +
> > + std::string path = origPath;
> > + if (path.find('/') == path.npos && path.find('\\') == path.npos )
> {
> > + std::string dir = vm_get_property_value("vm.boot.library.path
> ");
> > + if (libPrefix.length() > 0 && !startsWith(path, libPrefix)) {
> > + path = libPrefix + path;
> > + }
> > + path = dir + separator + path;
> > + }
> > + if (!endsWith(path, libSuffix)) {
> > + path+=libSuffix;
> > + }
> > + return path;
> > }
> >
> > static std::string getParam(const std::string& config, const
> > std::string& name) {
> > === cut ===
> >
> > As a result build fails.
> >
> > Salikh, it seems that you need to provide additional patch.
> >
> > SY, Alexey
> >
> > 2006/9/7, Alexey Varlamov <al...@gmail.com>:
> >> +1
> >>
> >> 2006/9/7, Geir Magnusson Jr. <ge...@pobox.com>:
> >> > +1
> >> >
> >> > Geir Magnusson Jr. wrote:
> >> > > All is in order and in SVN for Harmony-1225 wrt BCC and ACQ. I
> think
> >> > > that this an important patch so we can get better 1.5 support et
> al.
> >> > >
> >> > > Please vote to accept or reject this set of patches and fixes into
> >> the
> >> > > Apache Harmony class library :
> >> > >
> >> > > [ ] + 1 Accept
> >> > > [ ] -1 Reject (provide reason below)
> >> > >
> >> > > Lets let this run a minimum of 3 days unless a) someone states
> >> they need
> >> > > more time or b) we get all committer votes before then.
> >> > >
> >> > > geir
> >> > >
> >> > >
> >> > >
> >> > >
> >> > >
> ---------------------------------------------------------------------
> >> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> > > To unsubscribe, e-mail:
> harmony-dev-unsubscribe@incubator.apache.org
> >> > > For additional commands, e-mail:
> >> harmony-dev-help@incubator.apache.org
> >> > >
> >> >
> >> > ---------------------------------------------------------------------
> >> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >> > For additional commands, e-mail:
> harmony-dev-help@incubator.apache.org
> >> >
> >> >
> >>
> >> ---------------------------------------------------------------------
> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> >> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >>
> >>
> >
> >
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Mikhail Fursov
Re: [vote] HARMONY-1363 - DRLVM fixes and additions
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
thats something I just changed yesterday...
Alexey Petrenko wrote:
> Guys,
>
> I've tried a patch.
> Patch failed in ./vm/em/src/DrlEMImpl.cpp. On Linux and Windows.
> Here is a rej file:
> === cut ===
> ***************
> *** 151,165 ****
> //_____________________________________________________________________
> // Reading and parsing configuration
>
>
> - std::string buildDefaultLibPath(const std::string& dll_name) {
> - std::string library_path =
> vm_get_property_value("vm.boot.library.path");
> #ifdef PLATFORM_NT
> - std::string fullPath = library_path + "\\"+ dll_name+".dll";
> - #else
> - std::string fullPath = library_path + "/lib" + dll_name + ".so";
> #endif
> - return fullPath;
> }
>
> static std::string getParam(const std::string& config, const
> std::string& name) {
> --- 167,198 ----
> //_____________________________________________________________________
> // Reading and parsing configuration
>
> + static bool endsWith(const std::string& str, const std::string& suffix) {
> + if (str.length() < suffix.length()) {
> + return false;
> + }
> + return std::equal(suffix.rbegin(), suffix.rend(), str.rbegin());
> + }
>
> + std::string prepareLibPath(const std::string& origPath) {
> #ifdef PLATFORM_NT
> + std::string separator("\\"), libPrefix(""), libSuffix(".dll");
> + #else
> + std::string separator("/"), libPrefix("lib"), libSuffix(".so");
> #endif
> +
> + std::string path = origPath;
> + if (path.find('/') == path.npos && path.find('\\') == path.npos ) {
> + std::string dir = vm_get_property_value("vm.boot.library.path");
> + if (libPrefix.length() > 0 && !startsWith(path, libPrefix)) {
> + path = libPrefix + path;
> + }
> + path = dir + separator + path;
> + }
> + if (!endsWith(path, libSuffix)) {
> + path+=libSuffix;
> + }
> + return path;
> }
>
> static std::string getParam(const std::string& config, const
> std::string& name) {
> === cut ===
>
> As a result build fails.
>
> Salikh, it seems that you need to provide additional patch.
>
> SY, Alexey
>
> 2006/9/7, Alexey Varlamov <al...@gmail.com>:
>> +1
>>
>> 2006/9/7, Geir Magnusson Jr. <ge...@pobox.com>:
>> > +1
>> >
>> > Geir Magnusson Jr. wrote:
>> > > All is in order and in SVN for Harmony-1225 wrt BCC and ACQ. I think
>> > > that this an important patch so we can get better 1.5 support et al.
>> > >
>> > > Please vote to accept or reject this set of patches and fixes into
>> the
>> > > Apache Harmony class library :
>> > >
>> > > [ ] + 1 Accept
>> > > [ ] -1 Reject (provide reason below)
>> > >
>> > > Lets let this run a minimum of 3 days unless a) someone states
>> they need
>> > > more time or b) we get all committer votes before then.
>> > >
>> > > geir
>> > >
>> > >
>> > >
>> > >
>> > > ---------------------------------------------------------------------
>> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
>> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> > > For additional commands, e-mail:
>> harmony-dev-help@incubator.apache.org
>> > >
>> >
>> > ---------------------------------------------------------------------
>> > Terms of use : http://incubator.apache.org/harmony/mailing.html
>> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>> >
>> >
>>
>> ---------------------------------------------------------------------
>> Terms of use : http://incubator.apache.org/harmony/mailing.html
>> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>>
>>
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [vote] HARMONY-1363 - DRLVM fixes and additions
Posted by Alexey Petrenko <al...@gmail.com>.
I've talked about a small patch for this exact issue of course.
SY, Alexey
2006/9/7, Alexey Varlamov <al...@gmail.com>:
> Alexey,
>
> This conflict is trivial enough and was caused by recent Geir's
> changes, see the parallel thread about launcher.
> I don't think we need to redone the whole patch for this issue -
> either commiter will resolve it by hand or minor patch for this
> particular change can be made anew.
>
> --
> Regards,
> Alexey
>
>
> 2006/9/7, Alexey Petrenko <al...@gmail.com>:
> > Guys,
> >
> > I've tried a patch.
> > Patch failed in ./vm/em/src/DrlEMImpl.cpp. On Linux and Windows.
> > Here is a rej file:
> > === cut ===
> > ***************
> > *** 151,165 ****
> > //_____________________________________________________________________
> > // Reading and parsing configuration
> >
> >
> > - std::string buildDefaultLibPath(const std::string& dll_name) {
> > - std::string library_path = vm_get_property_value("vm.boot.library.path");
> > #ifdef PLATFORM_NT
> > - std::string fullPath = library_path + "\\"+ dll_name+".dll";
> > - #else
> > - std::string fullPath = library_path + "/lib" + dll_name + ".so";
> > #endif
> > - return fullPath;
> > }
> >
> > static std::string getParam(const std::string& config, const
> > std::string& name) {
> > --- 167,198 ----
> > //_____________________________________________________________________
> > // Reading and parsing configuration
> >
> > + static bool endsWith(const std::string& str, const std::string& suffix) {
> > + if (str.length() < suffix.length()) {
> > + return false;
> > + }
> > + return std::equal(suffix.rbegin(), suffix.rend(), str.rbegin());
> > + }
> >
> > + std::string prepareLibPath(const std::string& origPath) {
> > #ifdef PLATFORM_NT
> > + std::string separator("\\"), libPrefix(""), libSuffix(".dll");
> > + #else
> > + std::string separator("/"), libPrefix("lib"), libSuffix(".so");
> > #endif
> > +
> > + std::string path = origPath;
> > + if (path.find('/') == path.npos && path.find('\\') == path.npos ) {
> > + std::string dir = vm_get_property_value("vm.boot.library.path");
> > + if (libPrefix.length() > 0 && !startsWith(path, libPrefix)) {
> > + path = libPrefix + path;
> > + }
> > + path = dir + separator + path;
> > + }
> > + if (!endsWith(path, libSuffix)) {
> > + path+=libSuffix;
> > + }
> > + return path;
> > }
> >
> > static std::string getParam(const std::string& config, const
> > std::string& name) {
> > === cut ===
> >
> > As a result build fails.
> >
> > Salikh, it seems that you need to provide additional patch.
> >
> > SY, Alexey
> >
> > 2006/9/7, Alexey Varlamov <al...@gmail.com>:
> > > +1
> > >
> > > 2006/9/7, Geir Magnusson Jr. <ge...@pobox.com>:
> > > > +1
> > > >
> > > > Geir Magnusson Jr. wrote:
> > > > > All is in order and in SVN for Harmony-1225 wrt BCC and ACQ. I think
> > > > > that this an important patch so we can get better 1.5 support et al.
> > > > >
> > > > > Please vote to accept or reject this set of patches and fixes into the
> > > > > Apache Harmony class library :
> > > > >
> > > > > [ ] + 1 Accept
> > > > > [ ] -1 Reject (provide reason below)
> > > > >
> > > > > Lets let this run a minimum of 3 days unless a) someone states they need
> > > > > more time or b) we get all committer votes before then.
> > > > >
> > > > > geir
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > ---------------------------------------------------------------------
> > > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > > >
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> > >
> >
> >
> > --
> > Alexey A. Petrenko
> > Intel Middleware Products Division
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Alexey A. Petrenko
Intel Middleware Products Division
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [vote] HARMONY-1363 - DRLVM fixes and additions
Posted by Alexey Varlamov <al...@gmail.com>.
Alexey,
This conflict is trivial enough and was caused by recent Geir's
changes, see the parallel thread about launcher.
I don't think we need to redone the whole patch for this issue -
either commiter will resolve it by hand or minor patch for this
particular change can be made anew.
--
Regards,
Alexey
2006/9/7, Alexey Petrenko <al...@gmail.com>:
> Guys,
>
> I've tried a patch.
> Patch failed in ./vm/em/src/DrlEMImpl.cpp. On Linux and Windows.
> Here is a rej file:
> === cut ===
> ***************
> *** 151,165 ****
> //_____________________________________________________________________
> // Reading and parsing configuration
>
>
> - std::string buildDefaultLibPath(const std::string& dll_name) {
> - std::string library_path = vm_get_property_value("vm.boot.library.path");
> #ifdef PLATFORM_NT
> - std::string fullPath = library_path + "\\"+ dll_name+".dll";
> - #else
> - std::string fullPath = library_path + "/lib" + dll_name + ".so";
> #endif
> - return fullPath;
> }
>
> static std::string getParam(const std::string& config, const
> std::string& name) {
> --- 167,198 ----
> //_____________________________________________________________________
> // Reading and parsing configuration
>
> + static bool endsWith(const std::string& str, const std::string& suffix) {
> + if (str.length() < suffix.length()) {
> + return false;
> + }
> + return std::equal(suffix.rbegin(), suffix.rend(), str.rbegin());
> + }
>
> + std::string prepareLibPath(const std::string& origPath) {
> #ifdef PLATFORM_NT
> + std::string separator("\\"), libPrefix(""), libSuffix(".dll");
> + #else
> + std::string separator("/"), libPrefix("lib"), libSuffix(".so");
> #endif
> +
> + std::string path = origPath;
> + if (path.find('/') == path.npos && path.find('\\') == path.npos ) {
> + std::string dir = vm_get_property_value("vm.boot.library.path");
> + if (libPrefix.length() > 0 && !startsWith(path, libPrefix)) {
> + path = libPrefix + path;
> + }
> + path = dir + separator + path;
> + }
> + if (!endsWith(path, libSuffix)) {
> + path+=libSuffix;
> + }
> + return path;
> }
>
> static std::string getParam(const std::string& config, const
> std::string& name) {
> === cut ===
>
> As a result build fails.
>
> Salikh, it seems that you need to provide additional patch.
>
> SY, Alexey
>
> 2006/9/7, Alexey Varlamov <al...@gmail.com>:
> > +1
> >
> > 2006/9/7, Geir Magnusson Jr. <ge...@pobox.com>:
> > > +1
> > >
> > > Geir Magnusson Jr. wrote:
> > > > All is in order and in SVN for Harmony-1225 wrt BCC and ACQ. I think
> > > > that this an important patch so we can get better 1.5 support et al.
> > > >
> > > > Please vote to accept or reject this set of patches and fixes into the
> > > > Apache Harmony class library :
> > > >
> > > > [ ] + 1 Accept
> > > > [ ] -1 Reject (provide reason below)
> > > >
> > > > Lets let this run a minimum of 3 days unless a) someone states they need
> > > > more time or b) we get all committer votes before then.
> > > >
> > > > geir
> > > >
> > > >
> > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
>
> --
> Alexey A. Petrenko
> Intel Middleware Products Division
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [vote] HARMONY-1363 - DRLVM fixes and additions
Posted by Alexey Petrenko <al...@gmail.com>.
Guys,
I've tried a patch.
Patch failed in ./vm/em/src/DrlEMImpl.cpp. On Linux and Windows.
Here is a rej file:
=== cut ===
***************
*** 151,165 ****
//_____________________________________________________________________
// Reading and parsing configuration
- std::string buildDefaultLibPath(const std::string& dll_name) {
- std::string library_path = vm_get_property_value("vm.boot.library.path");
#ifdef PLATFORM_NT
- std::string fullPath = library_path + "\\"+ dll_name+".dll";
- #else
- std::string fullPath = library_path + "/lib" + dll_name + ".so";
#endif
- return fullPath;
}
static std::string getParam(const std::string& config, const
std::string& name) {
--- 167,198 ----
//_____________________________________________________________________
// Reading and parsing configuration
+ static bool endsWith(const std::string& str, const std::string& suffix) {
+ if (str.length() < suffix.length()) {
+ return false;
+ }
+ return std::equal(suffix.rbegin(), suffix.rend(), str.rbegin());
+ }
+ std::string prepareLibPath(const std::string& origPath) {
#ifdef PLATFORM_NT
+ std::string separator("\\"), libPrefix(""), libSuffix(".dll");
+ #else
+ std::string separator("/"), libPrefix("lib"), libSuffix(".so");
#endif
+
+ std::string path = origPath;
+ if (path.find('/') == path.npos && path.find('\\') == path.npos ) {
+ std::string dir = vm_get_property_value("vm.boot.library.path");
+ if (libPrefix.length() > 0 && !startsWith(path, libPrefix)) {
+ path = libPrefix + path;
+ }
+ path = dir + separator + path;
+ }
+ if (!endsWith(path, libSuffix)) {
+ path+=libSuffix;
+ }
+ return path;
}
static std::string getParam(const std::string& config, const
std::string& name) {
=== cut ===
As a result build fails.
Salikh, it seems that you need to provide additional patch.
SY, Alexey
2006/9/7, Alexey Varlamov <al...@gmail.com>:
> +1
>
> 2006/9/7, Geir Magnusson Jr. <ge...@pobox.com>:
> > +1
> >
> > Geir Magnusson Jr. wrote:
> > > All is in order and in SVN for Harmony-1225 wrt BCC and ACQ. I think
> > > that this an important patch so we can get better 1.5 support et al.
> > >
> > > Please vote to accept or reject this set of patches and fixes into the
> > > Apache Harmony class library :
> > >
> > > [ ] + 1 Accept
> > > [ ] -1 Reject (provide reason below)
> > >
> > > Lets let this run a minimum of 3 days unless a) someone states they need
> > > more time or b) we get all committer votes before then.
> > >
> > > geir
> > >
> > >
> > >
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Alexey A. Petrenko
Intel Middleware Products Division
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [vote] HARMONY-1363 - DRLVM fixes and additions
Posted by Vladimir Gorr <vv...@gmail.com>.
+1 from me.
Thanks,
Vladimir.
On 9/7/06, Alexey Varlamov <al...@gmail.com> wrote:
>
> +1
>
> 2006/9/7, Geir Magnusson Jr. <ge...@pobox.com>:
> > +1
> >
> > Geir Magnusson Jr. wrote:
> > > All is in order and in SVN for Harmony-1225 wrt BCC and ACQ. I think
> > > that this an important patch so we can get better 1.5 support et al.
> > >
> > > Please vote to accept or reject this set of patches and fixes into the
> > > Apache Harmony class library :
> > >
> > > [ ] + 1 Accept
> > > [ ] -1 Reject (provide reason below)
> > >
> > > Lets let this run a minimum of 3 days unless a) someone states they
> need
> > > more time or b) we get all committer votes before then.
> > >
> > > geir
> > >
> > >
> > >
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> > >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
Re: [vote] HARMONY-1363 - DRLVM fixes and additions
Posted by Alexey Varlamov <al...@gmail.com>.
+1
2006/9/7, Geir Magnusson Jr. <ge...@pobox.com>:
> +1
>
> Geir Magnusson Jr. wrote:
> > All is in order and in SVN for Harmony-1225 wrt BCC and ACQ. I think
> > that this an important patch so we can get better 1.5 support et al.
> >
> > Please vote to accept or reject this set of patches and fixes into the
> > Apache Harmony class library :
> >
> > [ ] + 1 Accept
> > [ ] -1 Reject (provide reason below)
> >
> > Lets let this run a minimum of 3 days unless a) someone states they need
> > more time or b) we get all committer votes before then.
> >
> > geir
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [vote] HARMONY-1363 - DRLVM fixes and additions
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
+1
Geir Magnusson Jr. wrote:
> All is in order and in SVN for Harmony-1225 wrt BCC and ACQ. I think
> that this an important patch so we can get better 1.5 support et al.
>
> Please vote to accept or reject this set of patches and fixes into the
> Apache Harmony class library :
>
> [ ] + 1 Accept
> [ ] -1 Reject (provide reason below)
>
> Lets let this run a minimum of 3 days unless a) someone states they need
> more time or b) we get all committer votes before then.
>
> geir
>
>
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [vote] HARMONY-1363 - DRLVM fixes and additions
Posted by Mikhail Loenko <ml...@gmail.com>.
+1
2006/9/7, Geir Magnusson Jr. <ge...@pobox.com>:
> All is in order and in SVN for Harmony-1225 wrt BCC and ACQ. I think
> that this an important patch so we can get better 1.5 support et al.
>
> Please vote to accept or reject this set of patches and fixes into the
> Apache Harmony class library :
>
> [ ] + 1 Accept
> [ ] -1 Reject (provide reason below)
>
> Lets let this run a minimum of 3 days unless a) someone states they need
> more time or b) we get all committer votes before then.
>
> geir
>
>
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [result] Re: [vote] HARMONY-1363 - DRLVM fixes and additions
Posted by Weldon Washburn <we...@gmail.com>.
On 9/10/06, Geir Magnusson Jr. <ge...@pobox.com> wrote:
>
> +1 from Geir, Alexey V, Vladimir, Mikhail L, Mikhail F, Gregory
>
> I'd have preferred a third committer,
+1 based on a a quick scan of the source code.
I did an "svn update" about 12 hours ago. Then a " patch -p1 -i BBC.patch".
The build failed. Right now I am trying to revert to an old revision of
drlvm/trunk that will take the patch.
Sorry for responding so late. With all the traffic on harmony-dev, I
somehow overlooked this email chain.
but as it is a set of patches and
> enhancements to an existing codebase, and there was no opposition, I
> think we're ok.
>
> geir
>
>
> Geir Magnusson Jr. wrote:
> > All is in order and in SVN for Harmony-1225 wrt BCC and ACQ. I think
> > that this an important patch so we can get better 1.5 support et al.
> >
> > Please vote to accept or reject this set of patches and fixes into the
> > Apache Harmony class library :
> >
> > [ ] + 1 Accept
> > [ ] -1 Reject (provide reason below)
> >
> > Lets let this run a minimum of 3 days unless a) someone states they need
> > more time or b) we get all committer votes before then.
> >
> > geir
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: harmony-dev-help@incubator.apache.org
> >
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
>
--
Weldon Washburn
Intel Middleware Products Division
[result] Re: [vote] HARMONY-1363 - DRLVM fixes and additions
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
+1 from Geir, Alexey V, Vladimir, Mikhail L, Mikhail F, Gregory
I'd have preferred a third committer, but as it is a set of patches and
enhancements to an existing codebase, and there was no opposition, I
think we're ok.
geir
Geir Magnusson Jr. wrote:
> All is in order and in SVN for Harmony-1225 wrt BCC and ACQ. I think
> that this an important patch so we can get better 1.5 support et al.
>
> Please vote to accept or reject this set of patches and fixes into the
> Apache Harmony class library :
>
> [ ] + 1 Accept
> [ ] -1 Reject (provide reason below)
>
> Lets let this run a minimum of 3 days unless a) someone states they need
> more time or b) we get all committer votes before then.
>
> geir
>
>
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: [vote] HARMONY-1363 - DRLVM fixes and additions
Posted by Gregory Shimansky <gs...@gmail.com>.
+1
It contains JVMTI breakpoint support which I hope to use in future JVMTI
development.
On Thursday 07 September 2006 08:33 Geir Magnusson Jr. wrote:
> All is in order and in SVN for Harmony-1225 wrt BCC and ACQ. I think
> that this an important patch so we can get better 1.5 support et al.
>
> Please vote to accept or reject this set of patches and fixes into the
> Apache Harmony class library :
>
> [ ] + 1 Accept
> [ ] -1 Reject (provide reason below)
>
> Lets let this run a minimum of 3 days unless a) someone states they need
> more time or b) we get all committer votes before then.
>
> geir
>
>
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
> For additional commands, e-mail: harmony-dev-help@incubator.apache.org
--
Gregory Shimansky, Intel Middleware Products Division
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org