You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "mbautin (Mikhail Bautin)" <ph...@reviews.facebook.net> on 2011/10/31 18:44:25 UTC

[Differential] [Accepted] D111: [jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.

mbautin has accepted the revision "[jira] [HBASE-4698] Let the HFile Pretty Printer print all the key values for a specific row.".

  Looks good (a few very minor comments inline).

INLINE COMMENTS
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:71 Nit: it would be nice to use Javadoc-style comments when referring to a specific field.
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:133 Coding style: space between key and !=
  src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java:136-137 Nit: "the kv" seems to imply there is only one kv for the row, which is most often not the case

REVISION DETAIL
  https://reviews.facebook.net/D111