You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "ilikepi63 (via GitHub)" <gi...@apache.org> on 2025/03/22 03:47:11 UTC
[PR] chore(server): Zero Copy Refactor Changes [iggy]
ilikepi63 opened a new pull request, #1661:
URL: https://github.com/apache/iggy/pull/1661
# Description
This PR serves to port over the changes from branch zero-copy-no-batch commit ab12922dc460f7b0f3cf2fac7de1b55b3a157ad5.
## Issue
https://github.com/apache/iggy/issues/1658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(server): Zero Copy Refactor Changes [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on code in PR #1661:
URL: https://github.com/apache/iggy/pull/1661#discussion_r2008732798
##########
server/Cargo.toml:
##########
@@ -52,14 +52,17 @@ console-subscriber = { version = "0.4.1", optional = true }
dashmap = "6.1.0"
derive_more = "2.0.1"
dotenvy = { version = "0.15.7" }
+enum_dispatch = "0.3.13"
error_set = { version = "0.8.5", features = ["tracing"] }
figlet-rs = "0.1.5"
figment = { version = "0.10.19", features = ["toml", "env"] }
flume = "0.11.1"
futures = "0.3.31"
+gxhash = "3.5.0"
Review Comment:
remove this dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(server): Zero Copy Refactor Changes [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio commented on code in PR #1661:
URL: https://github.com/apache/iggy/pull/1661#discussion_r2008731024
##########
sdk/src/bytes_serializable.rs:
##########
@@ -29,4 +29,14 @@ pub trait BytesSerializable {
fn from_bytes(bytes: Bytes) -> Result<Self, IggyError>
where
Self: Sized;
+
+ /// Write the struct to a buffer.
+ fn write_to_buffer(&self, _buf: &mut BytesMut) {
Review Comment:
what is reason for porting this? it exist on much newer commit in `zero-copy-no-batching` branch, and the aim for this task was to port only changes related to ServerCommandHandler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(server): Zero Copy Refactor Changes [iggy]
Posted by "hubcio (via GitHub)" <gi...@apache.org>.
hubcio closed pull request #1661: chore(server): Zero Copy Refactor Changes
URL: https://github.com/apache/iggy/pull/1661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(server): Zero Copy Refactor Changes [iggy]
Posted by "ilikepi63 (via GitHub)" <gi...@apache.org>.
ilikepi63 commented on PR #1661:
URL: https://github.com/apache/iggy/pull/1661#issuecomment-2745030081
Had to add a few more files from the previous commits as there were missing dependencies @hubcio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org