You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2026/06/30 17:18:01 UTC
(superset) branch master updated: fix(embedded): show already-added allowed domains in embed modal (closes #35328) (#41399)
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 7827d43ea6e fix(embedded): show already-added allowed domains in embed modal (closes #35328) (#41399)
7827d43ea6e is described below
commit 7827d43ea6eab5989f83e747791a9e89b3c8bdc7
Author: Evan Rusackas <ev...@preset.io>
AuthorDate: Tue Jun 30 10:17:53 2026 -0700
fix(embedded): show already-added allowed domains in embed modal (closes #35328) (#41399)
Co-authored-by: Devin AI <de...@users.noreply.github.com>
---
.../components/EmbeddedModal/EmbeddedModal.test.tsx | 12 ++++++++++++
.../src/dashboard/components/EmbeddedModal/index.tsx | 2 +-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/superset-frontend/src/dashboard/components/EmbeddedModal/EmbeddedModal.test.tsx b/superset-frontend/src/dashboard/components/EmbeddedModal/EmbeddedModal.test.tsx
index 492654ede34..7c0fc78384f 100644
--- a/superset-frontend/src/dashboard/components/EmbeddedModal/EmbeddedModal.test.tsx
+++ b/superset-frontend/src/dashboard/components/EmbeddedModal/EmbeddedModal.test.tsx
@@ -139,6 +139,18 @@ test('shows and hides confirmation alert when deactivating', async () => {
});
});
+test('populates the allowed-domains input from the API response', async () => {
+ setup();
+
+ const allowedDomainsInput = (await screen.findByRole('textbox', {
+ name: /Allowed Domains/i,
+ })) as HTMLInputElement;
+
+ await waitFor(() => {
+ expect(allowedDomainsInput.value).toBe('example.com');
+ });
+});
+
test('enables Save Changes button when allowed domains are modified', async () => {
setup();
diff --git a/superset-frontend/src/dashboard/components/EmbeddedModal/index.tsx b/superset-frontend/src/dashboard/components/EmbeddedModal/index.tsx
index 6ff78d794c0..4c9c7c7d9a0 100644
--- a/superset-frontend/src/dashboard/components/EmbeddedModal/index.tsx
+++ b/superset-frontend/src/dashboard/components/EmbeddedModal/index.tsx
@@ -197,7 +197,7 @@ export const DashboardEmbedControls = ({ dashboardId, onHide }: Props) => {
<h3>{t('Settings')}</h3>
<Form layout="vertical">
<FormItem
- name="allowed-domains"
+ htmlFor="allowed-domains"
label={
<span>
{t('Allowed Domains (comma separated)')}{' '}