[GitHub] [pulsar] sijie commented on a change in pull request #8781: [issue 8337][Worker] Move initialize dlog namespace metadata to bin/pulsar

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #8781:
URL: https://github.com/apache/pulsar/pull/8781#discussion_r534005280



##########
File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/Worker.java
##########
@@ -150,15 +150,8 @@ private static URI initialize(WorkerConfig workerConfig)
             admin.close();
         }
 
-        // initialize the dlog namespace
-        // TODO: move this as part of pulsar cluster initialization later
-        try {
-            return WorkerUtils.initializeDlogNamespace(internalConf);
-        } catch (IOException ioe) {
-            log.error("Failed to initialize dlog namespace with zookeeper {} at metadata service uri {} for storing function packages",
-                internalConf.getZookeeperServers(), internalConf.getBookkeeperMetadataServiceUri(), ioe);
-            throw ioe;
-        }
+        // get the dlog namespace
+        return WorkerUtils.getDlogNamespaceURI(internalConf.getZookeeperServers());

Review comment:
       Don't remove the code immediately. Please add a flag in Function worker config to control whether do we need to initialize dlog namespace or not. By default, we can make it `true` (to initialize dlog namespace) for backward compatibility consideration and allow people to turn it off.

##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarInitialDlogNamespaceMetadataSetup.java
##########
@@ -0,0 +1,69 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar;
+
+import com.beust.jcommander.JCommander;
+import com.beust.jcommander.Parameter;
+import org.apache.pulsar.common.conf.InternalConfigurationData;
+import org.apache.pulsar.functions.worker.WorkerUtils;
+
+public class PulsarInitialDlogNamespaceMetadataSetup {
+    private static class Arguments {
+        @Parameter(names = {"-cs",
+                "--configuration-store"}, description = "Configuration Store connection string", required = true)
+        private String configurationStore;
+
+        @Parameter(names = {"--bookkeeper-metadata-service-uri"}, description = "Metadata service uri of BookKeeper", required = true)
+        private String bkMetadataServiceUri;
+
+        @Parameter(names = {"-h", "--help"}, description = "Show this help message")
+        private boolean help = false;
+    }
+
+    public static void main(String[] args) throws Exception {
+        PulsarInitialDlogNamespaceMetadataSetup.Arguments arguments = new PulsarInitialDlogNamespaceMetadataSetup.Arguments();
+        JCommander jcommander = new JCommander();
+        try {
+            jcommander.addObject(arguments);
+            jcommander.parse(args);
+            if (arguments.help) {
+                jcommander.usage();
+                return;
+            }
+        } catch (Exception e) {
+            jcommander.usage();
+            throw e;
+        }
+
+        if (arguments.configurationStore == null) {
+            System.err.println("Configuration store address argument is required (--configuration-store)");
+            jcommander.usage();
+            System.exit(1);
+        }
+        if (arguments.bkMetadataServiceUri == null) {
+            System.err.println("Metadata service uri of BookKeeper argument is required (--bookkeeper-metadata-service-uri)");
+            jcommander.usage();
+            System.exit(1);
+        }
+
+        InternalConfigurationData internalConf = new InternalConfigurationData(arguments.configurationStore, arguments.configurationStore, null, arguments.bkMetadataServiceUri, null);
+        WorkerUtils.initializeDlogNamespace(internalConf);

Review comment:
       Also initialize the dlog namespace as part of `initialize-cluster-metadata` command.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org