[GitHub] [arrow-datafusion] alamb opened a new pull request, #6620: Minor: Move `include_rank` into `BuiltInWindowFunctionExpr`

["alamb (via GitHub)" <gi...@apache.org>]

alamb opened a new pull request, #6620:
URL: https://github.com/apache/arrow-datafusion/pull/6620

   # Which issue does this PR close?
   Related to #5781 
   
   # Rationale for this change
   
   `BuiltInWindowFunctionExpr` already contains several methods that describe how to call the corresponding `PartitionEvaluator` such as `supports_bounded_execution`. 
   
   The `include_rank` function similarly controls how the `PartitionEvaluator`  is called, and therefore I think makes more sense to include on `BuiltInWindowFunctionExpr` as well
   
   As we contemplate exposing `BuiltInWindowFunctionExpr` and `PartitionEvaluator` to implement window functions, making sure the interface is consistent I think is importat
   
   # What changes are included in this PR?
   1. Move `include_rank` into `BuiltInWindowFunctionExpr`
   
   # Are these changes tested?
   Covered by existing tests
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   # Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #6620: Minor: Move `include_rank` into `BuiltInWindowFunctionExpr`

["alamb (via GitHub)" <gi...@apache.org>]

alamb merged PR #6620:
URL: https://github.com/apache/arrow-datafusion/pull/6620


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org