[GitHub] [phoenix] ankitsinghal commented on a change in pull request #959: PHOENIX-6216 Add Omid and Tephra support to create-release script

[GitBox <gi...@apache.org>]

ankitsinghal commented on a change in pull request #959:
URL: https://github.com/apache/phoenix/pull/959#discussion_r522733663



##########
File path: dev/create-release/phoenix-rm/Dockerfile
##########
@@ -52,6 +52,11 @@ RUN wget -qO- "https://www.apache.org/dyn/mirrors/mirrors.cgi?action=download&fi
         tar xvz -C /opt
 ENV YETUS_HOME /opt/apache-yetus-${YETUS_VERSION}
 
+# Install protobuf-2.5 protoc binary from maven central, as that seems to be the only binary available
+RUN mkdir /opt/protobuf-2.5.0

Review comment:
       Not particular to this change, but I hope Omid dependency on protobuf 2.5.0 doesn't conflict with the protobuf 3.0+ in Hadoop/HBase/Phoenix runtime.

##########
File path: dev/create-release/release-util.sh
##########
@@ -636,12 +637,22 @@ function kick_gpg_agent {
 # Do maven command to set version into local pom
 function maven_set_version { #input: <version_to_set>
   local this_version="$1"
-  echo "${MVN[@]}" versions:set -DnewVersion="$this_version"
-  "${MVN[@]}" versions:set -DnewVersion="$this_version" | grep -v "no value" # silence logs
-  #Hacking around nonstandard maven submodules
+  # Omid needs an hbase profile for tagging (doesn't matter which one, the shims need special handling anyway)
+  if [[ "$PROJECT" == "phoenix-omid" ]]; then
+    local variant="${OMID_VARIANTS[1]}"
+  fi
+  echo "${MVN[@]}" ${variant:+"$variant"} versions:set -DnewVersion="$this_version"
+  "${MVN[@]}" ${variant:+"$variant"} versions:set -DnewVersion="$this_version" | grep -v "no value" # silence logs
+  #Hacking around nonstandard maven submodules for phoenix only
   for i in phoenix-hbase-compat-*; do
     if [ -e "$i" ]; then
-     "${MVN[@]}" -pl $i versions:set -DnewVersion="$this_version" | grep -v "no value" # silence logs
+     "${MVN[@]}" ${variant:+"$variant"} -pl $i versions:set -DnewVersion="$this_version" | grep -v "no value" # silence logs
+    fi
+  done
+  #Omid has an even more nonstandard maven structure, and needs more hacks
+  for i in hbase-shims/hbase-*; do
+    if [ -e "$i" ]; then
+     sed -i -e "0,\#<version>.*</version>#{s##<version>${this_version}</version>#}" $i/pom.xml

Review comment:
       I tried to find the alternative with options in the version maven plugin to update multi-level parent-child relationship but it seems we have no option other than this hack




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org