You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by GitBox <gi...@apache.org> on 2020/11/11 06:33:30 UTC

[GitHub] [kafka-site] showuon opened a new pull request #311: MINOR: Fix the wrong HTML format in powered by page

showuon opened a new pull request #311:
URL: https://github.com/apache/kafka-site/pull/311


   When visiting the powered by page, I suddenly found the hyperlink text is weird in SemaText.
   ![image](https://user-images.githubusercontent.com/43372967/98776447-e63dc900-2429-11eb-9e85-1bb0929d0807.png)
   
   After investigation, I found it's because we didn't end the `<a>` tag content well. We missed some right angle bracket (>) and some single quote ('), so that some text are disappeared on the page. Ex:
   ![image](https://user-images.githubusercontent.com/43372967/98776683-65cb9800-242a-11eb-815a-9427d52fb39b.png)
   
   We should end with the text `here` with hyperlink.
   
   Fix those issues!
   example after fixed:
   ![image](https://user-images.githubusercontent.com/43372967/98776817-a4615280-242a-11eb-8a74-87912f51af8b.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka-site] showuon commented on pull request #311: MINOR: Fix the wrong HTML format in powered by page

Posted by GitBox <gi...@apache.org>.

showuon commented on pull request #311:
URL: https://github.com/apache/kafka-site/pull/311#issuecomment-729350663


   @guozhangwang @scott-confluent , please help review. Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka-site] showuon commented on pull request #311: MINOR: Fix the wrong HTML format in powered by page

Posted by GitBox <gi...@apache.org>.

showuon commented on pull request #311:
URL: https://github.com/apache/kafka-site/pull/311#issuecomment-725231532


   @guozhangwang @scott-confluent , please help review. Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka-site] guozhangwang merged pull request #311: MINOR: Fix the wrong HTML format in powered by page

Posted by GitBox <gi...@apache.org>.

guozhangwang merged pull request #311:
URL: https://github.com/apache/kafka-site/pull/311


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka-site] guozhangwang commented on pull request #311: MINOR: Fix the wrong HTML format in powered by page

Posted by GitBox <gi...@apache.org>.

guozhangwang commented on pull request #311:
URL: https://github.com/apache/kafka-site/pull/311#issuecomment-729411055


   I did a quick check and can confirm all the pointed out issues are valid on site. Great job @showuon ! Merging now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org