[GitHub] [skywalking] chenmudu commented on a change in pull request #6702: Generate the corresponding event information for the alert.

[GitBox <gi...@apache.org>]

chenmudu commented on a change in pull request #6702:
URL: https://github.com/apache/skywalking/pull/6702#discussion_r608588442



##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/AlarmModuleProvider.java
##########
@@ -91,4 +92,8 @@ public void notifyAfterCompleted() throws ServiceNotProvidedException, ModuleSta
             ConfigurationModule.NAME
         };
     }
+
+    ModuleManager getModuleManager() {
+        return getManager();
+    }
 }

Review comment:
       > This method is only for testing purpose, we don't add methods just for testing, please use `Whitebox.getInternalState(moduleProvider, "manager");` to get the `manager` field in the unit test
   
   copy that. 
   
   > Also update the `CHANGES.log` to include this feature
   
   copy that .




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org