You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2019/12/30 12:30:32 UTC
[GitHub] [dubbo] codecov-io commented on issue #5559: [Dubbo]
Refactoring to remove feature envy
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5559?src=pr&el=h1) Report
> Merging [#5559](https://codecov.io/gh/apache/dubbo/pull/5559?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo/commit/1aed3aea92c093fb55db81f99622a9f925b07939?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `85.71%`.
[](https://codecov.io/gh/apache/dubbo/pull/5559?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5559 +/- ##
============================================
+ Coverage 61.22% 61.22% +<.01%
- Complexity 422 423 +1
============================================
Files 922 922
Lines 37504 37503 -1
Branches 5432 5430 -2
============================================
+ Hits 22962 22963 +1
+ Misses 12056 12055 -1
+ Partials 2486 2485 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5559?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/apache/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/dubbo/pull/5559/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==) | `75.93% <85.71%> (+0.31%)` | `0 <0> (ø)` | :arrow_down: |
| [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/dubbo/pull/5559/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVySGFuZGxlci5qYXZh) | `65.9% <0%> (-2.28%)` | `0% <0%> (ø)` | |
| [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/dubbo/pull/5559/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `64.4% <0%> (-1.7%)` | `0% <0%> (ø)` | |
| [...rg/apache/dubbo/common/timer/HashedWheelTimer.java](https://codecov.io/gh/apache/dubbo/pull/5559/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdGltZXIvSGFzaGVkV2hlZWxUaW1lci5qYXZh) | `63.44% <0%> (+0.34%)` | `0% <0%> (ø)` | :arrow_down: |
| [...he/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/dubbo/pull/5559/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eVNlcnZlci5qYXZh) | `73.68% <0%> (+3.5%)` | `9% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/5559?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/5559?src=pr&el=footer). Last update [1aed3ae...272dfce](https://codecov.io/gh/apache/dubbo/pull/5559?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo/pull/5559 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org