You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by fhueske <gi...@git.apache.org> on 2017/11/07 17:24:13 UTC

[GitHub] flink pull request #4974: [FLINK-8012] [table] Fix TableSink config for tabl...

GitHub user fhueske opened a pull request:

    https://github.com/apache/flink/pull/4974

    [FLINK-8012] [table] Fix TableSink config for tables with time attributes.

    ## What is the purpose of the change
    
    Fix the configuration of TableSinks for Tables with time attributes (`TimeIndicatorTypeInfo`).
    Time indicators types are internal and must not be exposed to the outside (such as TableSinks).
    
    ## Brief change log
    
    * the field type of time attributes (rowtime or proctime) is changed to their publicly visible type `SQL_TIMESTAMP`.
    * an existing test is adapted to check this case.
    
    ## Verifying this change
    
    * an existing test method in `TableSinkITCase` was adapted.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): **no**
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
      - The serializers: **no**
      - The runtime per-record code paths (performance sensitive): **no**
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
      - The S3 file system connector: **no**
    
    ## Documentation
    
      - Does this pull request introduce a new feature? **no**
      - If yes, how is the feature documented? **n/a**


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fhueske/flink tableSinkConfig

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4974.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4974
    
----
commit ab8120da2e7f751da2b5760e5b17d76264dcfcab
Author: Fabian Hueske <fh...@apache.org>
Date:   2017-11-07T16:57:39Z

    [FLINK-8012] [table] Fix TableSink config for tables with time attributes.

----


---

[GitHub] flink issue #4974: [FLINK-8012] [table] Fix TableSink config for tables with...

Posted by fhueske <gi...@git.apache.org>.

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/4974
  
    merging


---

[GitHub] flink pull request #4974: [FLINK-8012] [table] Fix TableSink config for tabl...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4974


---