You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/02/25 06:26:47 UTC

Review Request: Added a libprocess environment variable for enabling the cpu profiler.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9583/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Vinod Kone.


Description
-------

The perftools profiler causes crashes on 64 bit systems with libunwind or gcc < 2.12.
This is to remove access to the profiler, unless explicitly overridden in the environment. 


Diffs
-----

  third_party/libprocess/include/process/profiler.hpp 5e32a9e8b53a63b4959fbbc0d5ed39ea53f24cf8 

Diff: https://reviews.apache.org/r/9583/diff/


Testing
-------

manually tested endpoints


Thanks,

Ben Mahler


Re: Review Request: Added a libprocess environment variable for enabling the cpu profiler.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9583/#review17021
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Feb. 25, 2013, 5:26 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9583/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2013, 5:26 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> The perftools profiler causes crashes on 64 bit systems with libunwind or gcc < 2.12.
> This is to remove access to the profiler, unless explicitly overridden in the environment. 
> 
> 
> Diffs
> -----
> 
>   third_party/libprocess/include/process/profiler.hpp 5e32a9e8b53a63b4959fbbc0d5ed39ea53f24cf8 
> 
> Diff: https://reviews.apache.org/r/9583/diff/
> 
> 
> Testing
> -------
> 
> manually tested endpoints
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>