[GitHub] janpio commented on a change in pull request #563: [Fix] better support to find Home path for window

[GitBox <gi...@apache.org>]

janpio commented on a change in pull request #563: [Fix] better support to find Home path for window
URL: https://github.com/apache/cordova-android/pull/563#discussion_r234176797
 
 

 ##########
 File path: bin/templates/cordova/lib/build.js
 ##########
 @@ -82,7 +82,9 @@ function parseOpts (options, resolvedTarget, projectRoot) {
         if (config.android && config.android[ret.buildType]) {
             var androidInfo = config.android[ret.buildType];
             if (androidInfo.keystore && !packageArgs.keystore) {
-                if (androidInfo.keystore.substr(0, 1) === '~') {
+                if (androidInfo.keystore.substr(0, 1) === '~' 
+                    || androidInfo.keystore.substr(0, 5) === '$HOME' 
+                    || androidInfo.keystore.substr(0, 10) === '%HOMEPATH%') {
                     androidInfo.keystore = process.env.HOME + androidInfo.keystore.substr(1);
 
 Review comment:
   This line is now broken as `androidInfo.keystore.substr(1)` removes the first character from the keystore string - which only works for `~`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org