You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@inlong.apache.org by GitBox <gi...@apache.org> on 2021/04/30 03:34:18 UTC
[GitHub] [incubator-inlong] gosonzhang opened a new pull request #462: [INLONG-583] Adjust BrokerConfManager class implementation
gosonzhang opened a new pull request #462:
URL: https://github.com/apache/incubator-inlong/pull/462
1. Replace BrokerConfManager with MetaDataManager;
2. Clean up useless code implementations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] gosonzhang merged pull request #462: [INLONG-583] Adjust BrokerConfManager class implementation
Posted by GitBox <gi...@apache.org>.
gosonzhang merged pull request #462:
URL: https://github.com/apache/incubator-inlong/pull/462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] codecov-commenter commented on pull request #462: [INLONG-583] Adjust BrokerConfManager class implementation
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #462:
URL: https://github.com/apache/incubator-inlong/pull/462#issuecomment-829978552
# [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/462?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#462](https://codecov.io/gh/apache/incubator-inlong/pull/462?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fd83e71) into [TUBEMQ-570](https://codecov.io/gh/apache/incubator-inlong/commit/b3e14b96c88d64f984418a4afcb40c5f021b1be4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b3e14b9) will **increase** coverage by `0.71%`.
> The diff coverage is `0.93%`.
[](https://codecov.io/gh/apache/incubator-inlong/pull/462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## TUBEMQ-570 #462 +/- ##
===============================================
+ Coverage 6.60% 7.32% +0.71%
Complexity 477 477
===============================================
Files 300 298 -2
Lines 33480 31190 -2290
Branches 5573 5045 -528
===============================================
+ Hits 2212 2284 +72
+ Misses 30795 28437 -2358
+ Partials 473 469 -4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-inlong/pull/462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...emq/server/common/paramcheck/PBParameterUtils.java](https://codecov.io/gh/apache/incubator-inlong/pull/462/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vcGFyYW1jaGVjay9QQlBhcmFtZXRlclV0aWxzLmphdmE=) | `17.32% <0.00%> (+0.49%)` | `14.00 <0.00> (ø)` | |
| [.../tubemq/server/common/utils/WebParameterUtils.java](https://codecov.io/gh/apache/incubator-inlong/pull/462/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9jb21tb24vdXRpbHMvV2ViUGFyYW1ldGVyVXRpbHMuamF2YQ==) | `0.00% <ø> (-1.49%)` | `0.00 <0.00> (-8.00)` | |
| [.../java/org/apache/tubemq/server/master/TMaster.java](https://codecov.io/gh/apache/incubator-inlong/pull/462/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvVE1hc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...emq/server/master/balance/DefaultLoadBalancer.java](https://codecov.io/gh/apache/incubator-inlong/pull/462/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvYmFsYW5jZS9EZWZhdWx0TG9hZEJhbGFuY2VyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...bemq/server/master/metamanage/MetaDataManager.java](https://codecov.io/gh/apache/incubator-inlong/pull/462/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9NZXRhRGF0YU1hbmFnZXIuamF2YQ==) | `0.35% <0.00%> (+0.35%)` | `1.00 <0.00> (+1.00)` | |
| [...amanage/metastore/dao/entity/BrokerConfEntity.java](https://codecov.io/gh/apache/incubator-inlong/pull/462/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbWV0YW1hbmFnZS9tZXRhc3RvcmUvZGFvL2VudGl0eS9Ccm9rZXJDb25mRW50aXR5LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/nodemanage/nodebroker/BrokerSyncStatusInfo.java](https://codecov.io/gh/apache/incubator-inlong/pull/462/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbm9kZW1hbmFnZS9ub2RlYnJva2VyL0Jyb2tlclN5bmNTdGF0dXNJbmZvLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...emq/server/master/web/MasterStatusCheckFilter.java](https://codecov.io/gh/apache/incubator-inlong/pull/462/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvd2ViL01hc3RlclN0YXR1c0NoZWNrRmlsdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...tubemq/server/master/web/action/screen/Master.java](https://codecov.io/gh/apache/incubator-inlong/pull/462/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvd2ViL2FjdGlvbi9zY3JlZW4vTWFzdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ubemq/server/master/web/action/screen/Tubeweb.java](https://codecov.io/gh/apache/incubator-inlong/pull/462/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvd2ViL2FjdGlvbi9zY3JlZW4vVHViZXdlYi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [14 more](https://codecov.io/gh/apache/incubator-inlong/pull/462/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/462?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/462?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b3e14b9...fd83e71](https://codecov.io/gh/apache/incubator-inlong/pull/462?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org