You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "David Jencks (JIRA)" <ji...@apache.org> on 2008/01/24 18:04:34 UTC

[jira] Created: (GERONIMO-3782) tld files may not be getting their schema upgraded correctly

tld files may not be getting their schema upgraded correctly
------------------------------------------------------------

                 Key: GERONIMO-3782
                 URL: https://issues.apache.org/jira/browse/GERONIMO-3782
             Project: Geronimo
          Issue Type: Bug
      Security Level: public (Regular issues)
          Components: deployment
    Affects Versions: 2.0
            Reporter: David Jencks
             Fix For: 2.1


A user reports that a tld file http://jakarta.apache.org/taglibs/standard/scriptfree (apparently in standard.jar) which starts out

<?xml version="1.0" encoding="ISO-8859-1" ?>
<!DOCTYPE taglib
        PUBLIC "-//Sun Microsystems, Inc.//DTD JSP Tag Library 1.2//EN"
        "http://java.sun.com/dtd/web-jsptaglibrary_1_2.dtd">
<taglib>
  <tlib-version>1.0</tlib-version>
  <jsp-version>1.2</jsp-version>
  <short-name>scriptfree</short-name>
  <uri>http://jakarta.apache.org/taglibs/standard/scriptfree</uri>


has schema info added properly but inside the validator element init-params are not getting upgraded properly, they look like:

    <init-param>
      <param-name>allowDeclarations</param-name>
      <param-value>false</param-value>
      <description>Controls whether or not declarations are considered
valid.</description>
    </init-param>

We need to investigate if this is consistent with the original dtd and if so fix the upgrade code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-3782) tld files may not be getting their schema upgraded correctly

Posted by "Joe Bohn (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joe Bohn updated GERONIMO-3782:
-------------------------------

    Affects Version/s: 2.0.1
                       2.0.2
        Fix Version/s:     (was: 2.0.x)
                       2.0.3

> tld files may not be getting their schema upgraded correctly
> ------------------------------------------------------------
>
>                 Key: GERONIMO-3782
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3782
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: deployment
>    Affects Versions: 2.0, 2.0.1, 2.0.2
>            Reporter: David Jencks
>            Assignee: Jarek Gawor
>             Fix For: 2.0.3, 2.1
>
>
> A user reports that a tld file http://jakarta.apache.org/taglibs/standard/scriptfree (apparently in standard.jar) which starts out
> <?xml version="1.0" encoding="ISO-8859-1" ?>
> <!DOCTYPE taglib
>         PUBLIC "-//Sun Microsystems, Inc.//DTD JSP Tag Library 1.2//EN"
>         "http://java.sun.com/dtd/web-jsptaglibrary_1_2.dtd">
> <taglib>
>   <tlib-version>1.0</tlib-version>
>   <jsp-version>1.2</jsp-version>
>   <short-name>scriptfree</short-name>
>   <uri>http://jakarta.apache.org/taglibs/standard/scriptfree</uri>
> has schema info added properly but inside the validator element init-params are not getting upgraded properly, they look like:
>     <init-param>
>       <param-name>allowDeclarations</param-name>
>       <param-value>false</param-value>
>       <description>Controls whether or not declarations are considered
> valid.</description>
>     </init-param>
> We need to investigate if this is consistent with the original dtd and if so fix the upgrade code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (GERONIMO-3782) tld files may not be getting their schema upgraded correctly

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor resolved GERONIMO-3782.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0.x

Yes, there was a problem with dtd->xsd translation. Sometimes some elements were skipped during the translation (if there were the last child in a list). 
I committed fixes and tests to trunk (revision 615271, 615290) and branches/2.0 (revision 615305).


> tld files may not be getting their schema upgraded correctly
> ------------------------------------------------------------
>
>                 Key: GERONIMO-3782
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3782
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: deployment
>    Affects Versions: 2.0
>            Reporter: David Jencks
>            Assignee: Jarek Gawor
>             Fix For: 2.0.x, 2.1
>
>
> A user reports that a tld file http://jakarta.apache.org/taglibs/standard/scriptfree (apparently in standard.jar) which starts out
> <?xml version="1.0" encoding="ISO-8859-1" ?>
> <!DOCTYPE taglib
>         PUBLIC "-//Sun Microsystems, Inc.//DTD JSP Tag Library 1.2//EN"
>         "http://java.sun.com/dtd/web-jsptaglibrary_1_2.dtd">
> <taglib>
>   <tlib-version>1.0</tlib-version>
>   <jsp-version>1.2</jsp-version>
>   <short-name>scriptfree</short-name>
>   <uri>http://jakarta.apache.org/taglibs/standard/scriptfree</uri>
> has schema info added properly but inside the validator element init-params are not getting upgraded properly, they look like:
>     <init-param>
>       <param-name>allowDeclarations</param-name>
>       <param-value>false</param-value>
>       <description>Controls whether or not declarations are considered
> valid.</description>
>     </init-param>
> We need to investigate if this is consistent with the original dtd and if so fix the upgrade code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (GERONIMO-3782) tld files may not be getting their schema upgraded correctly

Posted by "Jarek Gawor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Gawor reassigned GERONIMO-3782:
-------------------------------------

    Assignee: Jarek Gawor

> tld files may not be getting their schema upgraded correctly
> ------------------------------------------------------------
>
>                 Key: GERONIMO-3782
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3782
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: deployment
>    Affects Versions: 2.0
>            Reporter: David Jencks
>            Assignee: Jarek Gawor
>             Fix For: 2.1
>
>
> A user reports that a tld file http://jakarta.apache.org/taglibs/standard/scriptfree (apparently in standard.jar) which starts out
> <?xml version="1.0" encoding="ISO-8859-1" ?>
> <!DOCTYPE taglib
>         PUBLIC "-//Sun Microsystems, Inc.//DTD JSP Tag Library 1.2//EN"
>         "http://java.sun.com/dtd/web-jsptaglibrary_1_2.dtd">
> <taglib>
>   <tlib-version>1.0</tlib-version>
>   <jsp-version>1.2</jsp-version>
>   <short-name>scriptfree</short-name>
>   <uri>http://jakarta.apache.org/taglibs/standard/scriptfree</uri>
> has schema info added properly but inside the validator element init-params are not getting upgraded properly, they look like:
>     <init-param>
>       <param-name>allowDeclarations</param-name>
>       <param-value>false</param-value>
>       <description>Controls whether or not declarations are considered
> valid.</description>
>     </init-param>
> We need to investigate if this is consistent with the original dtd and if so fix the upgrade code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-3782) tld files may not be getting their schema upgraded correctly

Posted by "David Jencks (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562139#action_12562139 ] 

David Jencks commented on GERONIMO-3782:
----------------------------------------

dtd contains
<!ELEMENT init-param (param-name, param-value, description?)>
so this is consistent with the dtd and the upgrade is not working properly

> tld files may not be getting their schema upgraded correctly
> ------------------------------------------------------------
>
>                 Key: GERONIMO-3782
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3782
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: deployment
>    Affects Versions: 2.0
>            Reporter: David Jencks
>             Fix For: 2.1
>
>
> A user reports that a tld file http://jakarta.apache.org/taglibs/standard/scriptfree (apparently in standard.jar) which starts out
> <?xml version="1.0" encoding="ISO-8859-1" ?>
> <!DOCTYPE taglib
>         PUBLIC "-//Sun Microsystems, Inc.//DTD JSP Tag Library 1.2//EN"
>         "http://java.sun.com/dtd/web-jsptaglibrary_1_2.dtd">
> <taglib>
>   <tlib-version>1.0</tlib-version>
>   <jsp-version>1.2</jsp-version>
>   <short-name>scriptfree</short-name>
>   <uri>http://jakarta.apache.org/taglibs/standard/scriptfree</uri>
> has schema info added properly but inside the validator element init-params are not getting upgraded properly, they look like:
>     <init-param>
>       <param-name>allowDeclarations</param-name>
>       <param-value>false</param-value>
>       <description>Controls whether or not declarations are considered
> valid.</description>
>     </init-param>
> We need to investigate if this is consistent with the original dtd and if so fix the upgrade code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.