You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/11/01 08:24:49 UTC
[GitHub] [inlong] gosonzhang opened a new pull request, #6351: [INLONG-6329][DataProxy] Add proxy-send mode message logic
gosonzhang opened a new pull request, #6351:
URL: https://github.com/apache/inlong/pull/6351
- Fixes #6329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gosonzhang commented on a diff in pull request #6351: [INLONG-6329][DataProxy] Add proxy-send mode message logic
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on code in PR #6351:
URL: https://github.com/apache/inlong/pull/6351#discussion_r1011175125
##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/consts/AttributeConstants.java:
##########
@@ -88,6 +88,8 @@ public class AttributeConstants {
public static final String MESSAGE_SYNC_SEND = "syncSend";
+ public static final String MESSAGE_PROXY_SEND = "proxySend";
Review Comment:
ok, you're right!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gosonzhang commented on a diff in pull request #6351: [INLONG-6329][DataProxy] Add proxy-send mode message logic
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on code in PR #6351:
URL: https://github.com/apache/inlong/pull/6351#discussion_r1011172410
##########
inlong-common/src/main/java/org/apache/inlong/common/enums/DataProxyErrCode.java:
##########
@@ -27,7 +27,22 @@ public enum DataProxyErrCode {
UNSUPPORTED_EXTENDFIELD_VALUE(3,
"Unsupported extend field value"),
UNCONFIGURED_GROUPID_OR_STREAMID(4,
- "Un-configured groupId or streamId"),
+ "Unconfigured groupId or streamId"),
+ PUT_EVENT_TO_CHANNEL_FAILURE(5,
+ "Put event to Channels failure"),
+ TOPIC_IS_BLANK(6,
+ "Topic is null"),
+ NO_AVAILABLE_RPODUCERINFO(7,
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #6351: [INLONG-6329][DataProxy] Add proxy-send mode message logic
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6351:
URL: https://github.com/apache/inlong/pull/6351#discussion_r1011245325
##########
inlong-common/src/main/java/org/apache/inlong/common/enums/DataProxyErrCode.java:
##########
@@ -27,7 +27,22 @@ public enum DataProxyErrCode {
UNSUPPORTED_EXTENDFIELD_VALUE(3,
"Unsupported extend field value"),
UNCONFIGURED_GROUPID_OR_STREAMID(4,
- "Un-configured groupId or streamId"),
+ "Unconfigured groupId or streamId"),
+ PUT_EVENT_TO_CHANNEL_FAILURE(5,
+ "Put event to Channels failure"),
+ TOPIC_IS_BLANK(6,
+ "Topic is null"),
+ NO_AVAILABLE_PRODUCERINFO(7,
+ "No available producer info"),
+ PRODUCER_IS_NULL(8,
+ "Producer is null"),
+ SEND_REQUEST_TO_PULSAR_FAILURE(9,
+ "Send requet to Pulsar failure"),
+ PULSAR_RETURN_ERROR(10,
Review Comment:
I think just returning the `MQ_RETURN_ERROR` is enough, there is no need to specify the actual MQ type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] pocozh commented on a diff in pull request #6351: [INLONG-6329][DataProxy] Add proxy-send mode message logic
Posted by GitBox <gi...@apache.org>.
pocozh commented on code in PR #6351:
URL: https://github.com/apache/inlong/pull/6351#discussion_r1011110523
##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/consts/AttributeConstants.java:
##########
@@ -88,6 +88,8 @@ public class AttributeConstants {
public static final String MESSAGE_SYNC_SEND = "syncSend";
+ public static final String MESSAGE_PROXY_SEND = "proxySend";
Review Comment:
It's better move these to common module, they are also used by`dataproxy-sdk`
##########
inlong-common/src/main/java/org/apache/inlong/common/enums/DataProxyErrCode.java:
##########
@@ -27,7 +27,22 @@ public enum DataProxyErrCode {
UNSUPPORTED_EXTENDFIELD_VALUE(3,
"Unsupported extend field value"),
UNCONFIGURED_GROUPID_OR_STREAMID(4,
- "Un-configured groupId or streamId"),
+ "Unconfigured groupId or streamId"),
+ PUT_EVENT_TO_CHANNEL_FAILURE(5,
+ "Put event to Channels failure"),
+ TOPIC_IS_BLANK(6,
+ "Topic is null"),
+ NO_AVAILABLE_RPODUCERINFO(7,
Review Comment:
typo, NO_AVAILABLE_PRODUCERINFO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gosonzhang commented on a diff in pull request #6351: [INLONG-6329][DataProxy] Add proxy-send mode message logic
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on code in PR #6351:
URL: https://github.com/apache/inlong/pull/6351#discussion_r1011251431
##########
inlong-common/src/main/java/org/apache/inlong/common/enums/DataProxyErrCode.java:
##########
@@ -27,7 +27,22 @@ public enum DataProxyErrCode {
UNSUPPORTED_EXTENDFIELD_VALUE(3,
"Unsupported extend field value"),
UNCONFIGURED_GROUPID_OR_STREAMID(4,
- "Un-configured groupId or streamId"),
+ "Unconfigured groupId or streamId"),
+ PUT_EVENT_TO_CHANNEL_FAILURE(5,
+ "Put event to Channels failure"),
+ TOPIC_IS_BLANK(6,
+ "Topic is null"),
+ NO_AVAILABLE_PRODUCERINFO(7,
+ "No available producer info"),
+ PRODUCER_IS_NULL(8,
+ "Producer is null"),
+ SEND_REQUEST_TO_PULSAR_FAILURE(9,
+ "Send requet to Pulsar failure"),
+ PULSAR_RETURN_ERROR(10,
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gosonzhang merged pull request #6351: [INLONG-6329][DataProxy] Add proxy-send mode message logic
Posted by GitBox <gi...@apache.org>.
gosonzhang merged PR #6351:
URL: https://github.com/apache/inlong/pull/6351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org