You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@rya.apache.org by jdasch <gi...@git.apache.org> on 2018/02/02 14:19:52 UTC

[GitHub] incubator-rya pull request #269: RYA-459 Fixed handling of comma-separated p...

Github user jdasch commented on a diff in the pull request:

    https://github.com/apache/incubator-rya/pull/269#discussion_r165655934
  
    --- Diff: extras/indexing/src/main/java/org/apache/rya/indexing/accumulo/AccumuloIndexingConfiguration.java ---
    @@ -287,15 +286,19 @@ public void setAccumuloTemporalPredicates(String[] predicates) {
         public String[] getAccumuloTemporalPredicates() {
             return getStrings(ConfigUtils.TEMPORAL_PREDICATES_LIST);
         }
    -    
    -    private static Set<RyaURI> getPropURIFromStrings(String ... props) {
    -        Set<RyaURI> properties = new HashSet<>();
    -        for(String prop: props) {
    -            properties.add(new RyaURI(prop));
    +
    +    private static Set<RyaURI> getPropURIFromStrings(final String... props) {
    +        final Set<RyaURI> properties = new HashSet<>();
    +        if (props != null) {
    +            for(final String prop : props) {
    +                if (prop != null) {
    --- End diff --
    
    Do we want/need an empty string check here?  Do we need/have a unit test to exercise this?


---