You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/08/15 22:39:21 UTC

[GitHub] [orc] dongjoon-hyun opened a new pull request #865: Add since tag to org.apache.orc.RecordReader interface

dongjoon-hyun opened a new pull request #865:
URL: https://github.com/apache/orc/pull/865


   ### What changes were proposed in this pull request?
   
   This PR aims to add `since` tag to `org.apache.orc.Reader` interface.
   
   ### Why are the changes needed?
   
   To help ORC developers to check the API availability easily by improving code and Javadoc.
   
   ### How was this patch tested?
   
   Manual


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #865: ORC-952: Add `since` tag to `org.apache.orc.RecordReader` interface

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #865:
URL: https://github.com/apache/orc/pull/865#issuecomment-899135921


   Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] williamhyun merged pull request #865: ORC-952: Add `since` tag to `org.apache.orc.RecordReader` interface

Posted by GitBox <gi...@apache.org>.
williamhyun merged pull request #865:
URL: https://github.com/apache/orc/pull/865


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] williamhyun commented on a change in pull request #865: ORC-952: Add `since` tag to `org.apache.orc.RecordReader` interface

Posted by GitBox <gi...@apache.org>.
williamhyun commented on a change in pull request #865:
URL: https://github.com/apache/orc/pull/865#discussion_r689162093



##########
File path: java/core/src/java/org/apache/orc/RecordReader.java
##########
@@ -42,19 +44,22 @@
    * call to next().
    * @return the row number from 0 to the number of rows in the file
    * @throws java.io.IOException
+   * @since 1.1.0
    */
   long getRowNumber() throws IOException;
 
   /**
    * Get the progress of the reader through the rows.
    * @return a fraction between 0.0 and 1.0 of rows read
    * @throws java.io.IOException
+   * @since 1.1.0
    */
   float getProgress() throws IOException;
 
   /**
    * Release the resources associated with the given reader.
    * @throws java.io.IOException
+   * @since 1.1.0
    */
   @Override
   void close() throws IOException;

Review comment:
       Could you add the tag to `seekToRow`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org