[jira] [Commented] (THRIFT-2926) JavaScript: binary protocol implementation

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14263111#comment-14263111 ] 

ASF GitHub Bot commented on THRIFT-2926:
----------------------------------------

GitHub user radekg opened a pull request:

    https://github.com/apache/thrift/pull/345

    THRIFT-2926: JS: Binary protocol with unit tests.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/radekg/thrift js-binary-protocol

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/345.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #345
    
----
commit 14f0f6b1a3989af01fea1a1de44f5d602665e719
Author: radekg <ra...@gruchalski.com>
Date:   2015-01-02T16:12:45Z

    JS: Binary protocol with unit tests.

----


> JavaScript: binary protocol implementation
> ------------------------------------------
>
>                 Key: THRIFT-2926
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2926
>             Project: Thrift
>          Issue Type: New Feature
>          Components: JavaScript - Library
>    Affects Versions: 0.9.2
>            Reporter: Radoslaw Gruchalski
>              Labels: features, javascript
>
> I have implemented BinaryProtocol for the JS library. Implementation provided with unit tests. Looking for feedback.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)