You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/09/09 16:59:26 UTC
[GitHub] [hive] mustafaiman opened a new pull request #1481: HIVE-24139: VectorGroupByOperator is not flushing hash table entries …
mustafaiman opened a new pull request #1481:
URL: https://github.com/apache/hive/pull/1481
…as needed
Change-Id: Idf25882ac6bef0db63ce08f67e8abcbc9fc60712
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] rbalamohan edited a comment on pull request #1481: HIVE-24139: VectorGroupByOperator is not flushing hash table entries …
Posted by GitBox <gi...@apache.org>.
rbalamohan edited a comment on pull request #1481:
URL: https://github.com/apache/hive/pull/1481#issuecomment-691824652
LGTM. +1 (pending tests)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #1481: HIVE-24139: VectorGroupByOperator is not flushing hash table entries …
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1481:
URL: https://github.com/apache/hive/pull/1481
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] rbalamohan commented on pull request #1481: HIVE-24139: VectorGroupByOperator is not flushing hash table entries …
Posted by GitBox <gi...@apache.org>.
rbalamohan commented on pull request #1481:
URL: https://github.com/apache/hive/pull/1481#issuecomment-691824652
LGTM. +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] rbalamohan commented on a change in pull request #1481: HIVE-24139: VectorGroupByOperator is not flushing hash table entries …
Posted by GitBox <gi...@apache.org>.
rbalamohan commented on a change in pull request #1481:
URL: https://github.com/apache/hive/pull/1481#discussion_r486285233
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java
##########
@@ -427,8 +428,12 @@ public void initialize(Configuration hconf) throws HiveException {
computeMemoryLimits();
LOG.debug("using hash aggregation processing mode");
+ reusableBufferSize = (int) (maxHtEntries * percentEntriesToFlush);
+
+ reusableAggregationBufferRows = new ArrayDeque<>(reusableBufferSize);
+
if (keyWrappersBatch.getVectorHashKeyWrappers()[0] instanceof VectorHashKeyWrapperGeneral) {
Review comment:
This decision is made purely based on first item in the hashKeyWrapper. Would there be issue if there are different wrappers (e.g VectorHashKeyWrapperSingleLong) in other indices? Or would there be a miss if the first index isn't VectorHashKeyWrapperGeneral?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] mustafaiman commented on a change in pull request #1481: HIVE-24139: VectorGroupByOperator is not flushing hash table entries …
Posted by GitBox <gi...@apache.org>.
mustafaiman commented on a change in pull request #1481:
URL: https://github.com/apache/hive/pull/1481#discussion_r486463497
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java
##########
@@ -427,8 +428,12 @@ public void initialize(Configuration hconf) throws HiveException {
computeMemoryLimits();
LOG.debug("using hash aggregation processing mode");
+ reusableBufferSize = (int) (maxHtEntries * percentEntriesToFlush);
+
+ reusableAggregationBufferRows = new ArrayDeque<>(reusableBufferSize);
+
if (keyWrappersBatch.getVectorHashKeyWrappers()[0] instanceof VectorHashKeyWrapperGeneral) {
Review comment:
@rbalamohan
The array that is returned from `keyWrappersBatch.getVectorHashKeyWrappers()` consists of only one type of wrappers, isn't it? So the first element is representative of all the elements in that array.
We resort to this optimization only when the batch consists of VectorHashKeyWrapperGeneral. The other wrapper types have only one two primitive types. If needed, only thing we need to do is just override their copyKey(KeyWrapper) method and generalize this `instanceOf` check to cover them too. Right now, I dont think that is very important.
So when the first element is not VectorHashKeyWrapperGeneral, the rest of the array are not either. In that case, we just skip reusing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #1481: HIVE-24139: VectorGroupByOperator is not flushing hash table entries …
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1481:
URL: https://github.com/apache/hive/pull/1481#issuecomment-743539618
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org