You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltaspike.apache.org by "Gerhard Petracek (Created) (JIRA)" <ji...@apache.org> on 2011/12/27 23:20:30 UTC
[jira] [Created] (DELTASPIKE-36) config-service
config-service
--------------
Key: DELTASPIKE-36
URL: https://issues.apache.org/jira/browse/DELTASPIKE-36
Project: DeltaSpike
Issue Type: New Feature
Components: Core
Reporter: Gerhard Petracek
Assignee: Gerhard Petracek
for several features we need a pluggable config-service which has to be independent of cdi because it's needed e.g. during the bootstrapping process of a cdi container.
an implementation is aware of a config source like property-files or xml files or jndi values and has to return 1-n configured values for a given key.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (DELTASPIKE-36) review and discuss ConfiguredValueResolver
Posted by Gerhard Petracek <ge...@gmail.com>.
np :)
regards,
gerhard
2011/12/28 John D. Ament <jo...@gmail.com>
> Gerhard,
>
> Apologies for jumping the gun. didn't read right and thought this was the
> discuss.
>
> John
>
>
> On Tue, Dec 27, 2011 at 6:36 PM, Gerhard Petracek <
> gerhard.petracek@gmail.com> wrote:
>
> > hi john,
> >
> > thx for the question. i added the link to the jira issue.
> > i'll start a thread about it (similar to the other feature threads) as
> soon
> > as the jira issue is ready for the discussion.
> >
> > regards,
> > gerhard
> >
> >
> >
> > 2011/12/28 John D. Ament <jo...@gmail.com>
> >
> > > Do you have a link to where this is in OWB? example maybe?
> > >
> > >
> > > On Tue, Dec 27, 2011 at 6:04 PM, Gerhard Petracek (Commented) (JIRA) <
> > > jira@apache.org> wrote:
> > >
> > > >
> > > > [
> > > >
> > >
> >
> https://issues.apache.org/jira/browse/DELTASPIKE-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176350#comment-13176350
> > > ]
> > > >
> > > > Gerhard Petracek commented on DELTASPIKE-36:
> > > > --------------------------------------------
> > > >
> > > > if we agree on a manual implementation, we can fix the first
> > > disadvantage.
> > > >
> > > > e.g .
> > > >
> > > > public class CustomConfiguredValueResolver implements
> > > > ConfiguredValueResolver
> > > > {
> > > > @Delegate //gets injected manually as soon as it is needed during
> the
> > > > bootstrapping process of the cdi container
> > > > private ConfiguredValueResolver defaultConfiguredValueResolver;
> > > >
> > > > //...
> > > > }
> > > >
> > > > -> a custom implementation can delegate to the default implementation
> > > > without knowing it
> > > >
> > > > > review and discuss ConfiguredValueResolver
> > > > > ------------------------------------------
> > > > >
> > > > > Key: DELTASPIKE-36
> > > > > URL:
> > > https://issues.apache.org/jira/browse/DELTASPIKE-36
> > > > > Project: DeltaSpike
> > > > > Issue Type: Task
> > > > > Components: Core
> > > > > Reporter: Gerhard Petracek
> > > > > Assignee: Gerhard Petracek
> > > > >
> > > > > for several features we need a pluggable config-service which has
> to
> > be
> > > > independent of cdi because it's needed e.g. during the bootstrapping
> > > > process of a cdi container.
> > > > > an implementation is aware of a config source like property-files
> or
> > > xml
> > > > files or jndi values and has to return 1-n configured values for a
> > given
> > > > key.
> > > >
> > > > --
> > > > This message is automatically generated by JIRA.
> > > > If you think it was sent incorrectly, please contact your JIRA
> > > > administrators:
> > > >
> > https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> > > > For more information on JIRA, see:
> > > http://www.atlassian.com/software/jira
> > > >
> > > >
> > > >
> > >
> >
>
Re: [jira] [Commented] (DELTASPIKE-36) review and discuss ConfiguredValueResolver
Posted by "John D. Ament" <jo...@gmail.com>.
Gerhard,
Apologies for jumping the gun. didn't read right and thought this was the
discuss.
John
On Tue, Dec 27, 2011 at 6:36 PM, Gerhard Petracek <
gerhard.petracek@gmail.com> wrote:
> hi john,
>
> thx for the question. i added the link to the jira issue.
> i'll start a thread about it (similar to the other feature threads) as soon
> as the jira issue is ready for the discussion.
>
> regards,
> gerhard
>
>
>
> 2011/12/28 John D. Ament <jo...@gmail.com>
>
> > Do you have a link to where this is in OWB? example maybe?
> >
> >
> > On Tue, Dec 27, 2011 at 6:04 PM, Gerhard Petracek (Commented) (JIRA) <
> > jira@apache.org> wrote:
> >
> > >
> > > [
> > >
> >
> https://issues.apache.org/jira/browse/DELTASPIKE-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176350#comment-13176350
> > ]
> > >
> > > Gerhard Petracek commented on DELTASPIKE-36:
> > > --------------------------------------------
> > >
> > > if we agree on a manual implementation, we can fix the first
> > disadvantage.
> > >
> > > e.g .
> > >
> > > public class CustomConfiguredValueResolver implements
> > > ConfiguredValueResolver
> > > {
> > > @Delegate //gets injected manually as soon as it is needed during the
> > > bootstrapping process of the cdi container
> > > private ConfiguredValueResolver defaultConfiguredValueResolver;
> > >
> > > //...
> > > }
> > >
> > > -> a custom implementation can delegate to the default implementation
> > > without knowing it
> > >
> > > > review and discuss ConfiguredValueResolver
> > > > ------------------------------------------
> > > >
> > > > Key: DELTASPIKE-36
> > > > URL:
> > https://issues.apache.org/jira/browse/DELTASPIKE-36
> > > > Project: DeltaSpike
> > > > Issue Type: Task
> > > > Components: Core
> > > > Reporter: Gerhard Petracek
> > > > Assignee: Gerhard Petracek
> > > >
> > > > for several features we need a pluggable config-service which has to
> be
> > > independent of cdi because it's needed e.g. during the bootstrapping
> > > process of a cdi container.
> > > > an implementation is aware of a config source like property-files or
> > xml
> > > files or jndi values and has to return 1-n configured values for a
> given
> > > key.
> > >
> > > --
> > > This message is automatically generated by JIRA.
> > > If you think it was sent incorrectly, please contact your JIRA
> > > administrators:
> > >
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> > > For more information on JIRA, see:
> > http://www.atlassian.com/software/jira
> > >
> > >
> > >
> >
>
Re: [jira] [Commented] (DELTASPIKE-36) review and discuss ConfiguredValueResolver
Posted by Gerhard Petracek <ge...@gmail.com>.
hi john,
thx for the question. i added the link to the jira issue.
i'll start a thread about it (similar to the other feature threads) as soon
as the jira issue is ready for the discussion.
regards,
gerhard
2011/12/28 John D. Ament <jo...@gmail.com>
> Do you have a link to where this is in OWB? example maybe?
>
>
> On Tue, Dec 27, 2011 at 6:04 PM, Gerhard Petracek (Commented) (JIRA) <
> jira@apache.org> wrote:
>
> >
> > [
> >
> https://issues.apache.org/jira/browse/DELTASPIKE-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176350#comment-13176350
> ]
> >
> > Gerhard Petracek commented on DELTASPIKE-36:
> > --------------------------------------------
> >
> > if we agree on a manual implementation, we can fix the first
> disadvantage.
> >
> > e.g .
> >
> > public class CustomConfiguredValueResolver implements
> > ConfiguredValueResolver
> > {
> > @Delegate //gets injected manually as soon as it is needed during the
> > bootstrapping process of the cdi container
> > private ConfiguredValueResolver defaultConfiguredValueResolver;
> >
> > //...
> > }
> >
> > -> a custom implementation can delegate to the default implementation
> > without knowing it
> >
> > > review and discuss ConfiguredValueResolver
> > > ------------------------------------------
> > >
> > > Key: DELTASPIKE-36
> > > URL:
> https://issues.apache.org/jira/browse/DELTASPIKE-36
> > > Project: DeltaSpike
> > > Issue Type: Task
> > > Components: Core
> > > Reporter: Gerhard Petracek
> > > Assignee: Gerhard Petracek
> > >
> > > for several features we need a pluggable config-service which has to be
> > independent of cdi because it's needed e.g. during the bootstrapping
> > process of a cdi container.
> > > an implementation is aware of a config source like property-files or
> xml
> > files or jndi values and has to return 1-n configured values for a given
> > key.
> >
> > --
> > This message is automatically generated by JIRA.
> > If you think it was sent incorrectly, please contact your JIRA
> > administrators:
> > https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> > For more information on JIRA, see:
> http://www.atlassian.com/software/jira
> >
> >
> >
>
Re: [jira] [Commented] (DELTASPIKE-36) review and discuss ConfiguredValueResolver
Posted by "John D. Ament" <jo...@gmail.com>.
Do you have a link to where this is in OWB? example maybe?
On Tue, Dec 27, 2011 at 6:04 PM, Gerhard Petracek (Commented) (JIRA) <
jira@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/DELTASPIKE-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176350#comment-13176350]
>
> Gerhard Petracek commented on DELTASPIKE-36:
> --------------------------------------------
>
> if we agree on a manual implementation, we can fix the first disadvantage.
>
> e.g .
>
> public class CustomConfiguredValueResolver implements
> ConfiguredValueResolver
> {
> @Delegate //gets injected manually as soon as it is needed during the
> bootstrapping process of the cdi container
> private ConfiguredValueResolver defaultConfiguredValueResolver;
>
> //...
> }
>
> -> a custom implementation can delegate to the default implementation
> without knowing it
>
> > review and discuss ConfiguredValueResolver
> > ------------------------------------------
> >
> > Key: DELTASPIKE-36
> > URL: https://issues.apache.org/jira/browse/DELTASPIKE-36
> > Project: DeltaSpike
> > Issue Type: Task
> > Components: Core
> > Reporter: Gerhard Petracek
> > Assignee: Gerhard Petracek
> >
> > for several features we need a pluggable config-service which has to be
> independent of cdi because it's needed e.g. during the bootstrapping
> process of a cdi container.
> > an implementation is aware of a config source like property-files or xml
> files or jndi values and has to return 1-n configured values for a given
> key.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators:
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
[jira] [Updated] (DELTASPIKE-36) ConfiguredValueResolver
Posted by "Gerhard Petracek (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-36?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gerhard Petracek updated DELTASPIKE-36:
---------------------------------------
Summary: ConfiguredValueResolver (was: config-service)
> ConfiguredValueResolver
> -----------------------
>
> Key: DELTASPIKE-36
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-36
> Project: DeltaSpike
> Issue Type: New Feature
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
>
> for several features we need a pluggable config-service which has to be independent of cdi because it's needed e.g. during the bootstrapping process of a cdi container.
> an implementation is aware of a config source like property-files or xml files or jndi values and has to return 1-n configured values for a given key.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-36) review and discuss
ConfiguredValueResolver
Posted by "Gerhard Petracek (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176347#comment-13176347 ]
Gerhard Petracek commented on DELTASPIKE-36:
--------------------------------------------
we could think about using the config approach used by owb.
instead of using Deactivatable and @InvocationOrder for 1-n implementations of ConfiguredValueResolver, there would be only one implementation which has to be configured via a properties file and with configuration.ordinal a custom config can overrule the default impl.
advantage:
+ there is only one active impl of the service
+ no need to aggregate the result of multiple service implementations
disadvantage:
- the default impl. can't be re-used easily if a custom impl. is only responsible for some but not all configured values or a custom impl. allows to overrule the default config-source if there are configured values in a custom config-source
- configuration.ordinal isn't type-safe
- configuration.ordinal is an additional mechanism (@InvocationOrder is also used for ordering other artifacts like phase-listeners,...)
> review and discuss ConfiguredValueResolver
> ------------------------------------------
>
> Key: DELTASPIKE-36
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-36
> Project: DeltaSpike
> Issue Type: Task
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
>
> for several features we need a pluggable config-service which has to be independent of cdi because it's needed e.g. during the bootstrapping process of a cdi container.
> an implementation is aware of a config source like property-files or xml files or jndi values and has to return 1-n configured values for a given key.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DELTASPIKE-36) review and discuss ConfigResolver
Posted by "Gerhard Petracek (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-36?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gerhard Petracek resolved DELTASPIKE-36.
----------------------------------------
Resolution: Fixed
Fix Version/s: 0.1-SNAPSHOT
> review and discuss ConfigResolver
> ---------------------------------
>
> Key: DELTASPIKE-36
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-36
> Project: DeltaSpike
> Issue Type: Sub-task
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
> Fix For: 0.1-SNAPSHOT
>
>
> for several features we need a pluggable config-service which has to be independent of cdi because it's needed e.g. during the bootstrapping process of a cdi container.
> an implementation is aware of a config source like property-files or xml files or jndi values and has to return 1-n configured values for a given key.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DELTASPIKE-36) review and discuss ConfigResolver
Posted by "Gerhard Petracek (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-36?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gerhard Petracek updated DELTASPIKE-36:
---------------------------------------
Summary: review and discuss ConfigResolver (was: review and discuss ConfiguredValueResolver)
> review and discuss ConfigResolver
> ---------------------------------
>
> Key: DELTASPIKE-36
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-36
> Project: DeltaSpike
> Issue Type: Sub-task
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
>
> for several features we need a pluggable config-service which has to be independent of cdi because it's needed e.g. during the bootstrapping process of a cdi container.
> an implementation is aware of a config source like property-files or xml files or jndi values and has to return 1-n configured values for a given key.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (DELTASPIKE-36) review and discuss
ConfiguredValueResolver
Posted by "Gerhard Petracek (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176347#comment-13176347 ]
Gerhard Petracek edited comment on DELTASPIKE-36 at 12/27/11 11:27 PM:
-----------------------------------------------------------------------
we could think about using the config approach used by owb [1].
instead of using Deactivatable and @InvocationOrder for 1-n implementations of ConfiguredValueResolver, there would be only one implementation which has to be configured via a properties file and with configuration.ordinal a custom config can overrule the default impl.
advantage:
+ there is only one active impl of the service
+ no need to aggregate the result of multiple service implementations
disadvantage:
- the default impl. can't be re-used easily if a custom impl. is only responsible for some but not all configured values or a custom impl. allows to overrule the default config-source if there are configured values in a custom config-source
- configuration.ordinal isn't type-safe
- configuration.ordinal is an additional mechanism (@InvocationOrder is also used for ordering other artifacts like phase-listeners,...)
[1] https://svn.apache.org/repos/asf/openwebbeans/tags/openwebbeans-1.1.3/webbeans-impl/src/main/java/org/apache/webbeans/config/PropertyLoader.java
was (Author: gpetracek):
we could think about using the config approach used by owb.
instead of using Deactivatable and @InvocationOrder for 1-n implementations of ConfiguredValueResolver, there would be only one implementation which has to be configured via a properties file and with configuration.ordinal a custom config can overrule the default impl.
advantage:
+ there is only one active impl of the service
+ no need to aggregate the result of multiple service implementations
disadvantage:
- the default impl. can't be re-used easily if a custom impl. is only responsible for some but not all configured values or a custom impl. allows to overrule the default config-source if there are configured values in a custom config-source
- configuration.ordinal isn't type-safe
- configuration.ordinal is an additional mechanism (@InvocationOrder is also used for ordering other artifacts like phase-listeners,...)
> review and discuss ConfiguredValueResolver
> ------------------------------------------
>
> Key: DELTASPIKE-36
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-36
> Project: DeltaSpike
> Issue Type: Task
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
>
> for several features we need a pluggable config-service which has to be independent of cdi because it's needed e.g. during the bootstrapping process of a cdi container.
> an implementation is aware of a config source like property-files or xml files or jndi values and has to return 1-n configured values for a given key.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (DELTASPIKE-36) review and discuss ConfigResolver
Posted by "Gerhard Petracek (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-36?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gerhard Petracek closed DELTASPIKE-36.
--------------------------------------
> review and discuss ConfigResolver
> ---------------------------------
>
> Key: DELTASPIKE-36
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-36
> Project: DeltaSpike
> Issue Type: Sub-task
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
> Fix For: 0.1-incubating
>
>
> for several features we need a pluggable config-service which has to be independent of cdi because it's needed e.g. during the bootstrapping process of a cdi container.
> an implementation is aware of a config source like property-files or xml files or jndi values and has to return 1-n configured values for a given key.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-36) review and discuss
ConfiguredValueResolver
Posted by "Gerhard Petracek (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176957#comment-13176957 ]
Gerhard Petracek commented on DELTASPIKE-36:
--------------------------------------------
https://git-wip-us.apache.org/repos/asf?p=incubator-deltaspike.git;a=commit;h=fb0131106481f0b9a8fdc13b9879a5482219c736
https://git-wip-us.apache.org/repos/asf?p=incubator-deltaspike.git;a=commit;h=81170a8b0e72eb7d3a45ace61b0443503bce9333
... is a completely new and simple but flexible implementation which illustrates an easier but very pluggable approach which allows different config-sources as well as re-ordering existing config-sources.
> review and discuss ConfiguredValueResolver
> ------------------------------------------
>
> Key: DELTASPIKE-36
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-36
> Project: DeltaSpike
> Issue Type: Sub-task
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
>
> for several features we need a pluggable config-service which has to be independent of cdi because it's needed e.g. during the bootstrapping process of a cdi container.
> an implementation is aware of a config source like property-files or xml files or jndi values and has to return 1-n configured values for a given key.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (DELTASPIKE-36) review and discuss
ConfiguredValueResolver
Posted by "Gerhard Petracek (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176347#comment-13176347 ]
Gerhard Petracek edited comment on DELTASPIKE-36 at 12/27/11 11:41 PM:
-----------------------------------------------------------------------
we could think about using the config approach used by owb [1].
instead of using Deactivatable and @InvocationOrder for 1-n implementations of ConfiguredValueResolver, there would be only one implementation which has to be configured via a properties file and with configuration.ordinal [2] a custom config can overrule the default impl.
advantage:
+ there is only one active impl of the service
+ no need to aggregate the result of multiple service implementations
disadvantage:
- the default impl. can't be re-used easily if a custom impl. is only responsible for some but not all configured values or a custom impl. allows to overrule the default config-source if there are configured values in a custom config-source
- configuration.ordinal isn't type-safe
- configuration.ordinal is an additional mechanism (@InvocationOrder is also used for ordering other artifacts like phase-listeners,...)
[1] https://svn.apache.org/repos/asf/openwebbeans/tags/openwebbeans-1.1.3/webbeans-impl/src/main/java/org/apache/webbeans/config/PropertyLoader.java
[2] https://svn.apache.org/repos/asf/openwebbeans/tags/openwebbeans-1.1.3/webbeans-test/cditest-owb/src/main/resources/META-INF/openwebbeans/openwebbeans.properties
was (Author: gpetracek):
we could think about using the config approach used by owb [1].
instead of using Deactivatable and @InvocationOrder for 1-n implementations of ConfiguredValueResolver, there would be only one implementation which has to be configured via a properties file and with configuration.ordinal a custom config can overrule the default impl.
advantage:
+ there is only one active impl of the service
+ no need to aggregate the result of multiple service implementations
disadvantage:
- the default impl. can't be re-used easily if a custom impl. is only responsible for some but not all configured values or a custom impl. allows to overrule the default config-source if there are configured values in a custom config-source
- configuration.ordinal isn't type-safe
- configuration.ordinal is an additional mechanism (@InvocationOrder is also used for ordering other artifacts like phase-listeners,...)
[1] https://svn.apache.org/repos/asf/openwebbeans/tags/openwebbeans-1.1.3/webbeans-impl/src/main/java/org/apache/webbeans/config/PropertyLoader.java
> review and discuss ConfiguredValueResolver
> ------------------------------------------
>
> Key: DELTASPIKE-36
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-36
> Project: DeltaSpike
> Issue Type: Task
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
>
> for several features we need a pluggable config-service which has to be independent of cdi because it's needed e.g. during the bootstrapping process of a cdi container.
> an implementation is aware of a config source like property-files or xml files or jndi values and has to return 1-n configured values for a given key.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-36) config-service
Posted by "Gerhard Petracek (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176342#comment-13176342 ]
Gerhard Petracek commented on DELTASPIKE-36:
--------------------------------------------
in myfaces codi it's handled via:
ConfiguredValueResolver, ConfiguredValueDescriptor and internally it uses the Aggregatable api to support multiple values.
a ConfiguredValueResolver can be configured via the std. spi mechanism provided by java1.6+. (with @InvocationOrder it's possible to define an order)
> config-service
> --------------
>
> Key: DELTASPIKE-36
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-36
> Project: DeltaSpike
> Issue Type: New Feature
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
>
> for several features we need a pluggable config-service which has to be independent of cdi because it's needed e.g. during the bootstrapping process of a cdi container.
> an implementation is aware of a config source like property-files or xml files or jndi values and has to return 1-n configured values for a given key.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (DELTASPIKE-36) review and discuss
ConfiguredValueResolver
Posted by "Gerhard Petracek (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176957#comment-13176957 ]
Gerhard Petracek edited comment on DELTASPIKE-36 at 12/29/11 2:47 AM:
----------------------------------------------------------------------
https://git-wip-us.apache.org/repos/asf?p=incubator-deltaspike.git;a=commit;h=fb0131106481f0b9a8fdc13b9879a5482219c736
https://git-wip-us.apache.org/repos/asf?p=incubator-deltaspike.git;a=commit;h=81170a8b0e72eb7d3a45ace61b0443503bce9333
... is a completely new and simple but flexible implementation which illustrates an easier but very pluggable approach which allows different config-sources as well as re-ordering existing config-sources.
(it will be discussed as soon as it is ready for a review)
was (Author: gpetracek):
https://git-wip-us.apache.org/repos/asf?p=incubator-deltaspike.git;a=commit;h=fb0131106481f0b9a8fdc13b9879a5482219c736
https://git-wip-us.apache.org/repos/asf?p=incubator-deltaspike.git;a=commit;h=81170a8b0e72eb7d3a45ace61b0443503bce9333
... is a completely new and simple but flexible implementation which illustrates an easier but very pluggable approach which allows different config-sources as well as re-ordering existing config-sources.
> review and discuss ConfiguredValueResolver
> ------------------------------------------
>
> Key: DELTASPIKE-36
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-36
> Project: DeltaSpike
> Issue Type: Sub-task
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
>
> for several features we need a pluggable config-service which has to be independent of cdi because it's needed e.g. during the bootstrapping process of a cdi container.
> an implementation is aware of a config source like property-files or xml files or jndi values and has to return 1-n configured values for a given key.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (DELTASPIKE-36) review and discuss
ConfiguredValueResolver
Posted by "Gerhard Petracek (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176350#comment-13176350 ]
Gerhard Petracek edited comment on DELTASPIKE-36 at 12/28/11 1:16 AM:
----------------------------------------------------------------------
if we agree on a manual implementation, we can fix the first disadvantage.
e.g .
public class CustomConfiguredValueResolver implements ConfiguredValueResolver
{
@Delegate //gets injected manually as soon as it is needed during the bootstrapping process of the cdi container
private ConfiguredValueResolver defaultConfiguredValueResolver;
//...
}
-> a custom implementation can delegate to the default implementation without knowing it
or
instead of using an own config for it (in combination with "configuration.ordinal"), we can use the std. spi mechanism provided by java1.6+ for custom implementations (>not< for the default implementations).
disadvantage: 3rd party add-ons can't provide the zero-config approach, if the final application needs to overrule an implementation provided the add-on (or they have to provide it as separated config jar file).
was (Author: gpetracek):
if we agree on a manual implementation, we can fix the first disadvantage.
e.g .
public class CustomConfiguredValueResolver implements ConfiguredValueResolver
{
@Delegate //gets injected manually as soon as it is needed during the bootstrapping process of the cdi container
private ConfiguredValueResolver defaultConfiguredValueResolver;
//...
}
-> a custom implementation can delegate to the default implementation without knowing it
> review and discuss ConfiguredValueResolver
> ------------------------------------------
>
> Key: DELTASPIKE-36
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-36
> Project: DeltaSpike
> Issue Type: Task
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
>
> for several features we need a pluggable config-service which has to be independent of cdi because it's needed e.g. during the bootstrapping process of a cdi container.
> an implementation is aware of a config source like property-files or xml files or jndi values and has to return 1-n configured values for a given key.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DELTASPIKE-36) review and discuss
ConfiguredValueResolver
Posted by "Gerhard Petracek (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-36?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gerhard Petracek updated DELTASPIKE-36:
---------------------------------------
Issue Type: Task (was: New Feature)
Summary: review and discuss ConfiguredValueResolver (was: ConfiguredValueResolver)
> review and discuss ConfiguredValueResolver
> ------------------------------------------
>
> Key: DELTASPIKE-36
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-36
> Project: DeltaSpike
> Issue Type: Task
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
>
> for several features we need a pluggable config-service which has to be independent of cdi because it's needed e.g. during the bootstrapping process of a cdi container.
> an implementation is aware of a config source like property-files or xml files or jndi values and has to return 1-n configured values for a given key.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DELTASPIKE-36) review and discuss
ConfiguredValueResolver
Posted by "Gerhard Petracek (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-36?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gerhard Petracek updated DELTASPIKE-36:
---------------------------------------
Issue Type: Sub-task (was: Task)
Parent: DELTASPIKE-2
> review and discuss ConfiguredValueResolver
> ------------------------------------------
>
> Key: DELTASPIKE-36
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-36
> Project: DeltaSpike
> Issue Type: Sub-task
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
>
> for several features we need a pluggable config-service which has to be independent of cdi because it's needed e.g. during the bootstrapping process of a cdi container.
> an implementation is aware of a config source like property-files or xml files or jndi values and has to return 1-n configured values for a given key.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-36) review and discuss
ConfiguredValueResolver
Posted by "Gerhard Petracek (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176350#comment-13176350 ]
Gerhard Petracek commented on DELTASPIKE-36:
--------------------------------------------
if we agree on a manual implementation, we can fix the first disadvantage.
e.g .
public class CustomConfiguredValueResolver implements ConfiguredValueResolver
{
@Delegate //gets injected manually as soon as it is needed during the bootstrapping process of the cdi container
private ConfiguredValueResolver defaultConfiguredValueResolver;
//...
}
-> a custom implementation can delegate to the default implementation without knowing it
> review and discuss ConfiguredValueResolver
> ------------------------------------------
>
> Key: DELTASPIKE-36
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-36
> Project: DeltaSpike
> Issue Type: Task
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
>
> for several features we need a pluggable config-service which has to be independent of cdi because it's needed e.g. during the bootstrapping process of a cdi container.
> an implementation is aware of a config source like property-files or xml files or jndi values and has to return 1-n configured values for a given key.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (DELTASPIKE-36) review and discuss
ConfiguredValueResolver
Posted by "Gerhard Petracek (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176342#comment-13176342 ]
Gerhard Petracek edited comment on DELTASPIKE-36 at 12/27/11 11:30 PM:
-----------------------------------------------------------------------
in myfaces codi it's handled via:
ConfiguredValueResolver [1], ConfiguredValueDescriptor [2] and internally it uses the Aggregatable api to support multiple values.
a ConfiguredValueResolver can be configured via the std. spi mechanism provided by java1.6+. (with @InvocationOrder it's possible to define an order)
[1] http://s.apache.org/ht
[2] http://s.apache.org/ZaL
was (Author: gpetracek):
in myfaces codi it's handled via:
ConfiguredValueResolver, ConfiguredValueDescriptor and internally it uses the Aggregatable api to support multiple values.
a ConfiguredValueResolver can be configured via the std. spi mechanism provided by java1.6+. (with @InvocationOrder it's possible to define an order)
> review and discuss ConfiguredValueResolver
> ------------------------------------------
>
> Key: DELTASPIKE-36
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-36
> Project: DeltaSpike
> Issue Type: Task
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
>
> for several features we need a pluggable config-service which has to be independent of cdi because it's needed e.g. during the bootstrapping process of a cdi container.
> an implementation is aware of a config source like property-files or xml files or jndi values and has to return 1-n configured values for a given key.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira