[GitHub] michellethomas opened a new pull request #6236: Dashboard filter box default

[GitBox <gi...@apache.org>]

michellethomas opened a new pull request #6236: Dashboard filter box default
URL: https://github.com/apache/incubator-superset/pull/6236
 
 
   If there's no selectedValue for the DateFilterControl, we should set the default to 'No filter'. In the filter box, the date filter doesn't get applied until some value has been selected in the dropdown, so it's a little confusing to have the default filter say "Last week" (DateFilterControl defaultProp for value), when there is no filter that's applied.
   
   Added a test for filter box to go along with this. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org