You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/09/09 17:02:58 UTC

[GitHub] [arrow-datafusion] rdettai commented on a change in pull request #965: Move CBOs to physical plan

rdettai commented on a change in pull request #965:
URL: https://github.com/apache/arrow-datafusion/pull/965#discussion_r705533805



##########
File path: datafusion/src/datasource/mod.rs
##########
@@ -193,9 +192,13 @@ pub fn get_statistics_with_limit(
 
     let mut num_rows = 0;
     let mut num_files = 0;
+    let mut is_exact = true;
     for file in &all_files {
         num_files += 1;
         let file_stats = &file.statistics;
+        if !file_stats.is_exact {

Review comment:
       nice optim! bit harder to read for people like me who don't have a compiler in their head, but I like it 😉 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org