You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "Shawn Jiang (JIRA)" <ji...@apache.org> on 2011/06/10 10:04:59 UTC

[jira] [Created] (OPENEJB-1574) Check if a AVAILABLE state entry is in cache before throwing out the IllegalStateException.

Check if a AVAILABLE state entry is in cache before throwing out the IllegalStateException.
-------------------------------------------------------------------------------------------

                 Key: OPENEJB-1574
                 URL: https://issues.apache.org/jira/browse/OPENEJB-1574
             Project: OpenEJB
          Issue Type: Bug
          Components: container system
    Affects Versions: (trunk/openejb3)
            Reporter: Shawn Jiang


org.apache.openejb.core.managed.SimpleCache.checkIn(K) {
...

            switch (entry.getState()) {
                case AVAILABLE:
                    throw new IllegalStateException("The entry " + key + " is not checked-out");
..


}

In some mutiple thread  cases,   I noticed that  a checked entry was checked in again by other thread.   then we will get a invalid illegalStateException. 





--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (OPENEJB-1574) Check if a AVAILABLE state entry is in cache before throwing out the IllegalStateException.

Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shawn Jiang updated OPENEJB-1574:
---------------------------------

    Attachment: 0001-OPENEJB-1574-Check-if-a-AVAILABLE-state-entry-is-in-.patch

This patch will check if the entry has been checked in, if was checked in.   Just reset it's time.

if not checked in,  throw the exception.  Please help to review.

> Check if a AVAILABLE state entry is in cache before throwing out the IllegalStateException.
> -------------------------------------------------------------------------------------------
>
>                 Key: OPENEJB-1574
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1574
>             Project: OpenEJB
>          Issue Type: Bug
>          Components: container system
>    Affects Versions: (trunk/openejb3)
>            Reporter: Shawn Jiang
>         Attachments: 0001-OPENEJB-1574-Check-if-a-AVAILABLE-state-entry-is-in-.patch
>
>
> org.apache.openejb.core.managed.SimpleCache.checkIn(K) {
> ...
>             switch (entry.getState()) {
>                 case AVAILABLE:
>                     throw new IllegalStateException("The entry " + key + " is not checked-out");
> ..
> }
> In some mutiple thread  cases,   I noticed that  a checked entry was checked in again by other thread.   then we will get a invalid illegalStateException. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OPENEJB-1574) Check if a AVAILABLE state entry is in cache before throwing out the IllegalStateException.

Posted by "David Blevins (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENEJB-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047513#comment-13047513 ] 

David Blevins commented on OPENEJB-1574:
----------------------------------------

I think that's as good as it gets.  The concurrency of the Stateful container in general has been needing a rewrite.  So if this works, that's good enough.

> Check if a AVAILABLE state entry is in cache before throwing out the IllegalStateException.
> -------------------------------------------------------------------------------------------
>
>                 Key: OPENEJB-1574
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1574
>             Project: OpenEJB
>          Issue Type: Bug
>          Components: container system
>    Affects Versions: (trunk/openejb3)
>            Reporter: Shawn Jiang
>         Attachments: 0001-OPENEJB-1574-Check-if-a-AVAILABLE-state-entry-is-in-.patch
>
>
> org.apache.openejb.core.managed.SimpleCache.checkIn(K) {
> ...
>             switch (entry.getState()) {
>                 case AVAILABLE:
>                     throw new IllegalStateException("The entry " + key + " is not checked-out");
> ..
> }
> In some mutiple thread  cases,   I noticed that  a checked entry was checked in again by other thread.   then we will get a invalid illegalStateException. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (OPENEJB-1574) Check if a AVAILABLE state entry is in cache before throwing out the IllegalStateException.

Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shawn Jiang reassigned OPENEJB-1574:
------------------------------------

    Assignee: Shawn Jiang

> Check if a AVAILABLE state entry is in cache before throwing out the IllegalStateException.
> -------------------------------------------------------------------------------------------
>
>                 Key: OPENEJB-1574
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1574
>             Project: OpenEJB
>          Issue Type: Bug
>          Components: container system
>    Affects Versions: (trunk/openejb3)
>            Reporter: Shawn Jiang
>            Assignee: Shawn Jiang
>         Attachments: 0001-OPENEJB-1574-Check-if-a-AVAILABLE-state-entry-is-in-.patch
>
>
> org.apache.openejb.core.managed.SimpleCache.checkIn(K) {
> ...
>             switch (entry.getState()) {
>                 case AVAILABLE:
>                     throw new IllegalStateException("The entry " + key + " is not checked-out");
> ..
> }
> In some mutiple thread  cases,   I noticed that  a checked entry was checked in again by other thread.   then we will get a invalid illegalStateException. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (OPENEJB-1574) Check if a AVAILABLE state entry is in cache before throwing out the IllegalStateException.

Posted by "Shawn Jiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shawn Jiang resolved OPENEJB-1574.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 4.0

fixed.

> Check if a AVAILABLE state entry is in cache before throwing out the IllegalStateException.
> -------------------------------------------------------------------------------------------
>
>                 Key: OPENEJB-1574
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1574
>             Project: OpenEJB
>          Issue Type: Bug
>          Components: container system
>    Affects Versions: (trunk/openejb3)
>            Reporter: Shawn Jiang
>            Assignee: Shawn Jiang
>             Fix For: 4.0
>
>         Attachments: 0001-OPENEJB-1574-Check-if-a-AVAILABLE-state-entry-is-in-.patch
>
>
> org.apache.openejb.core.managed.SimpleCache.checkIn(K) {
> ...
>             switch (entry.getState()) {
>                 case AVAILABLE:
>                     throw new IllegalStateException("The entry " + key + " is not checked-out");
> ..
> }
> In some mutiple thread  cases,   I noticed that  a checked entry was checked in again by other thread.   then we will get a invalid illegalStateException. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira