You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by mi...@apache.org on 2015/02/28 00:07:33 UTC

svn commit: r1662853 - /lucene/dev/branches/lucene_solr_4_10/dev-tools/scripts/smokeTestRelease.py

Author: mikemccand
Date: Fri Feb 27 23:07:33 2015
New Revision: 1662853

URL: http://svn.apache.org/r1662853
Log:
it's OK that 4.10.x back compat test fails to test 5.x indices :)

Modified:
    lucene/dev/branches/lucene_solr_4_10/dev-tools/scripts/smokeTestRelease.py

Modified: lucene/dev/branches/lucene_solr_4_10/dev-tools/scripts/smokeTestRelease.py
URL: http://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_4_10/dev-tools/scripts/smokeTestRelease.py?rev=1662853&r1=1662852&r2=1662853&view=diff
==============================================================================
--- lucene/dev/branches/lucene_solr_4_10/dev-tools/scripts/smokeTestRelease.py (original)
+++ lucene/dev/branches/lucene_solr_4_10/dev-tools/scripts/smokeTestRelease.py Fri Feb 27 23:07:33 2015
@@ -1395,9 +1395,13 @@ def confirmAllReleasesAreTestedForBackCo
   notTested = []
   for x in allReleases:
     if x not in testedIndices:
-      if '.'.join(str(y) for y in x) in ('1.4.3', '1.9.1', '2.3.1', '2.3.2'):
+      version = '.'.join(str(y) for y in x)
+      if version in ('1.4.3', '1.9.1', '2.3.1', '2.3.2'):
         # Exempt the dark ages indices
         continue
+      if version.startswith('5.'):
+        # 4.10.x only!: exempt the future indices
+        continue
       notTested.append(x)
 
   if len(notTested) > 0:



Re: svn commit: r1662853 - /lucene/dev/branches/lucene_solr_4_10/dev-tools/scripts/smokeTestRelease.p y

Posted by Chris Hostetter <ho...@fucit.org>.
: it's OK that 4.10.x back compat test fails to test 5.x indices :)

FWIW: using something like python's distutils.version.StrictVersion to 
compare the current RC version with each of hte items in allReleases might 
help make this less tedious down the road...

(is distutils a standard python lib?)

: 
: Modified:
:     lucene/dev/branches/lucene_solr_4_10/dev-tools/scripts/smokeTestRelease.py
: 
: Modified: lucene/dev/branches/lucene_solr_4_10/dev-tools/scripts/smokeTestRelease.py
: URL: http://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_4_10/dev-tools/scripts/smokeTestRelease.py?rev=1662853&r1=1662852&r2=1662853&view=diff
: ==============================================================================
: --- lucene/dev/branches/lucene_solr_4_10/dev-tools/scripts/smokeTestRelease.py (original)
: +++ lucene/dev/branches/lucene_solr_4_10/dev-tools/scripts/smokeTestRelease.py Fri Feb 27 23:07:33 2015
: @@ -1395,9 +1395,13 @@ def confirmAllReleasesAreTestedForBackCo
:    notTested = []
:    for x in allReleases:
:      if x not in testedIndices:
: -      if '.'.join(str(y) for y in x) in ('1.4.3', '1.9.1', '2.3.1', '2.3.2'):
: +      version = '.'.join(str(y) for y in x)
: +      if version in ('1.4.3', '1.9.1', '2.3.1', '2.3.2'):
:          # Exempt the dark ages indices
:          continue
: +      if version.startswith('5.'):
: +        # 4.10.x only!: exempt the future indices
: +        continue
:        notTested.append(x)
:  
:    if len(notTested) > 0:
: 
: 
: 

-Hoss
http://www.lucidworks.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org