You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/09/07 16:39:24 UTC

[GitHub] [beam] y1chi commented on a change in pull request #15460: Add display data for JdbcIO.write

y1chi commented on a change in pull request #15460:
URL: https://github.com/apache/beam/pull/15460#discussion_r703669198



##########
File path: sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##########
@@ -1638,6 +1638,17 @@ public void setup() {
                 .withMaxRetries(retryConfiguration.getMaxAttempts());
       }
 
+      @Override
+      public void populateDisplayData(DisplayData.Builder builder) {
+        spec.populateDisplayData(builder);
+        builder.addIfNotNull(

Review comment:
       why not just `builder.add()`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org