You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "majin1102 (via GitHub)" <gi...@apache.org> on 2026/01/28 16:09:04 UTC

[PR] [Fix] fix [amoro]

majin1102 opened a new pull request, #4065:
URL: https://github.com/apache/amoro/pull/4065

   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://amoro.apache.org/how-to-contribute/
     2. If the PR is related to an issue in https://github.com/apache/amoro/issues, add '[AMORO-XXXX]' in your PR title, e.g., '[AMORO-XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][AMORO-XXXX] Your PR title ...'.
   -->
   
   ## Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about its use case.
     2. If you fix a bug, you can clarify why it is a bug.
     3. Use Fix/Resolve/Close #{ISSUE_NUMBER} to link this PR to its related issue
   -->
   
   This PR tightens the Tables page UX around URL-driven selection and sidebar navigation.
   
   ## Brief change log
   <!--
   Clearly describe the changes made in modules, classes, methods, etc.
   -->
   
   1. Treat blank /tables as a fresh entry: no auto-selection of the last table; content only appears after a user-selected table or an explicit catalog/db/table in the URL.
   2. Make the URL the single source of truth: when catalog/db/table are present, Table Explorer expands to that path and selects the table, and the right panel shows its details.
   3. When returning to Tables via the sidebar in the same tab, restore the last selected table by reading localStorage and navigating with catalog/db/table; if no last selection exists, open a blank /tables.
   4. Keep other modules navigating to /tables with explicit query params when a table is known; otherwise navigate without params.
   5. Preserve session-expanded tree state and disable auto-expand-parent to avoid inconsistent expansion after refresh.
   **6. No backend changes.**
   
   
   ## How was this patch tested?
   
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [x] Run test locally before making a pull request
   
   ## Documentation
   
   - Does this pull request introduce a new feature? (yes / no)
   - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [UI] Refine Tables page selection and navigation UX [amoro]

Posted by "majin1102 (via GitHub)" <gi...@apache.org>.
majin1102 merged PR #4065:
URL: https://github.com/apache/amoro/pull/4065


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org