You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/11/28 03:13:37 UTC

[kudu-CR] java build: Add script to verify output of generated JARs 

Hello Dan Burkert,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/8662

to review the following change.


Change subject: java build: Add script to verify output of generated JARs
......................................................................

java build: Add script to verify output of generated JARs

This script reports any files included in packaging JARs that do not
match a set of patterns in the script. This allows us to define certain
dependencies that we will ship (shaded or otherwise) and, if this is
incorporated into the build process, will immediately alert us as things
change over time.

Change-Id: Ie16bca12dfe2d0267e559c91abe1178d906e3122
---
A java/verify_jars.pl
1 file changed, 98 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/8662/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8662
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie16bca12dfe2d0267e559c91abe1178d906e3122
Gerrit-Change-Number: 8662
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>

[kudu-CR] java build: Add script to verify output of generated JARs

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has uploaded a new patch set (#3) to the change originally created by Mike Percy. ( http://gerrit.cloudera.org:8080/8662 )

Change subject: java build: Add script to verify output of generated JARs
......................................................................

java build: Add script to verify output of generated JARs

This script reports any files included in packaging JARs that do not
match a set of patterns in the script. This allows us to define certain
dependencies that we will ship (shaded or otherwise) and, if this is
incorporated into the build process, will immediately alert us as things
change over time.

Change-Id: Ie16bca12dfe2d0267e559c91abe1178d906e3122
---
A java/verify_jars.pl
1 file changed, 98 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/8662/3
-- 
To view, visit http://gerrit.cloudera.org:8080/8662
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie16bca12dfe2d0267e559c91abe1178d906e3122
Gerrit-Change-Number: 8662
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] java build: Add script to verify output of generated JARs

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8662 )

Change subject: java build: Add script to verify output of generated JARs
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8662/4/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

http://gerrit.cloudera.org:8080/#/c/8662/4/build-support/jenkins/build-and-test.sh@402
PS4, Line 402:     $SOURCE_ROOT/build-support/verify_jars.pl .
> yeah, maven artifacts go in target/ and gradle goes in build/libs/.
Thanks, done



-- 
To view, visit http://gerrit.cloudera.org:8080/8662
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie16bca12dfe2d0267e559c91abe1178d906e3122
Gerrit-Change-Number: 8662
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 29 Nov 2017 04:19:00 +0000
Gerrit-HasComments: Yes

[kudu-CR] java build: Add script to verify output of generated JARs

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8662

to look at the new patch set (#4).

Change subject: java build: Add script to verify output of generated JARs
......................................................................

java build: Add script to verify output of generated JARs

This script reports any files included in packaging JARs that do not
match a set of patterns in the script. This allows us to define certain
dependencies that we will ship (shaded or otherwise) and, if this is
incorporated into the build process, will immediately alert us as things
change over time.

The script runs automatically as part of the regular CI build.

Change-Id: Ie16bca12dfe2d0267e559c91abe1178d906e3122
---
M build-support/jenkins/build-and-test.sh
A build-support/verify_jars.pl
2 files changed, 112 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/8662/4
-- 
To view, visit http://gerrit.cloudera.org:8080/8662
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie16bca12dfe2d0267e559c91abe1178d906e3122
Gerrit-Change-Number: 8662
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] java build: Add script to verify output of generated JARs

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8662 )

Change subject: java build: Add script to verify output of generated JARs
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8662/4/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

http://gerrit.cloudera.org:8080/#/c/8662/4/build-support/jenkins/build-and-test.sh@402
PS4, Line 402:     $SOURCE_ROOT/build-support/verify_jars.pl .
> I think you could run the script just once if you move it below the gradle 
I'm concerned that it will mask issues that only occur in the Maven build. Or do the Gradle artifacts get dropped elsewhere?



-- 
To view, visit http://gerrit.cloudera.org:8080/8662
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie16bca12dfe2d0267e559c91abe1178d906e3122
Gerrit-Change-Number: 8662
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 28 Nov 2017 20:42:43 +0000
Gerrit-HasComments: Yes

[kudu-CR] java build: Add script to verify output of generated JARs

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8662 )

Change subject: java build: Add script to verify output of generated JARs
......................................................................

java build: Add script to verify output of generated JARs

This script reports any files included in packaging JARs that do not
match a set of patterns in the script. This allows us to define certain
dependencies that we will ship (shaded or otherwise) and, if this is
incorporated into the build process, will immediately alert us as things
change over time.

The script runs automatically as part of the regular CI build.

Change-Id: Ie16bca12dfe2d0267e559c91abe1178d906e3122
Reviewed-on: http://gerrit.cloudera.org:8080/8662
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M build-support/jenkins/build-and-test.sh
A build-support/verify_jars.pl
2 files changed, 109 insertions(+), 0 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Dan Burkert: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/8662
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie16bca12dfe2d0267e559c91abe1178d906e3122
Gerrit-Change-Number: 8662
Gerrit-PatchSet: 7
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] java build: Add script to verify output of generated JARs

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8662 )

Change subject: java build: Add script to verify output of generated JARs
......................................................................


Patch Set 6:

rev 5 puts the verification step right after the gradle guild and rev 6 is just a rebase onto master


-- 
To view, visit http://gerrit.cloudera.org:8080/8662
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie16bca12dfe2d0267e559c91abe1178d906e3122
Gerrit-Change-Number: 8662
Gerrit-PatchSet: 6
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 29 Nov 2017 04:21:03 +0000
Gerrit-HasComments: No

[kudu-CR] java build: Add script to verify output of generated JARs

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8662 )

Change subject: java build: Add script to verify output of generated JARs
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8662/4/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

http://gerrit.cloudera.org:8080/#/c/8662/4/build-support/jenkins/build-and-test.sh@402
PS4, Line 402:     $SOURCE_ROOT/build-support/verify_jars.pl .
I think you could run the script just once if you move it below the gradle build if block.



-- 
To view, visit http://gerrit.cloudera.org:8080/8662
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie16bca12dfe2d0267e559c91abe1178d906e3122
Gerrit-Change-Number: 8662
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 28 Nov 2017 18:35:10 +0000
Gerrit-HasComments: Yes

[kudu-CR] java build: Add script to verify output of generated JARs

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8662 )

Change subject: java build: Add script to verify output of generated JARs
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8662/4/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

http://gerrit.cloudera.org:8080/#/c/8662/4/build-support/jenkins/build-and-test.sh@402
PS4, Line 402:     $SOURCE_ROOT/build-support/verify_jars.pl .
> I'm concerned that it will mask issues that only occur in the Maven build. 
yeah, maven artifacts go in target/ and gradle goes in build/libs/.



-- 
To view, visit http://gerrit.cloudera.org:8080/8662
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie16bca12dfe2d0267e559c91abe1178d906e3122
Gerrit-Change-Number: 8662
Gerrit-PatchSet: 4
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 28 Nov 2017 21:13:53 +0000
Gerrit-HasComments: Yes

[kudu-CR] java build: Add script to verify output of generated JARs

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8662

to look at the new patch set (#5).

Change subject: java build: Add script to verify output of generated JARs
......................................................................

java build: Add script to verify output of generated JARs

This script reports any files included in packaging JARs that do not
match a set of patterns in the script. This allows us to define certain
dependencies that we will ship (shaded or otherwise) and, if this is
incorporated into the build process, will immediately alert us as things
change over time.

The script runs automatically as part of the regular CI build.

Change-Id: Ie16bca12dfe2d0267e559c91abe1178d906e3122
---
M build-support/jenkins/build-and-test.sh
A build-support/verify_jars.pl
2 files changed, 109 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/8662/5
-- 
To view, visit http://gerrit.cloudera.org:8080/8662
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie16bca12dfe2d0267e559c91abe1178d906e3122
Gerrit-Change-Number: 8662
Gerrit-PatchSet: 5
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] java build: Add script to verify output of generated JARs

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8662 )

Change subject: java build: Add script to verify output of generated JARs
......................................................................


Patch Set 3:

Should we hook this up to CI?


-- 
To view, visit http://gerrit.cloudera.org:8080/8662
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie16bca12dfe2d0267e559c91abe1178d906e3122
Gerrit-Change-Number: 8662
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 28 Nov 2017 04:30:18 +0000
Gerrit-HasComments: No

[kudu-CR] java build: Add script to verify output of generated JARs

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/8662 )

Change subject: java build: Add script to verify output of generated JARs
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/8662
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie16bca12dfe2d0267e559c91abe1178d906e3122
Gerrit-Change-Number: 8662
Gerrit-PatchSet: 6
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 29 Nov 2017 04:51:29 +0000
Gerrit-HasComments: No

[kudu-CR] java build: Add script to verify output of generated JARs

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8662

to look at the new patch set (#2).

Change subject: java build: Add script to verify output of generated JARs
......................................................................

java build: Add script to verify output of generated JARs

This script reports any files included in packaging JARs that do not
match a set of patterns in the script. This allows us to define certain
dependencies that we will ship (shaded or otherwise) and, if this is
incorporated into the build process, will immediately alert us as things
change over time.

Change-Id: Ie16bca12dfe2d0267e559c91abe1178d906e3122
---
A java/verify_jars.pl
1 file changed, 97 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/8662/2
-- 
To view, visit http://gerrit.cloudera.org:8080/8662
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie16bca12dfe2d0267e559c91abe1178d906e3122
Gerrit-Change-Number: 8662
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins