[GitHub] [incubator-pegasus] hycdong commented on pull request #1099: refactor(build): remove 'rdsn' from build and test commands

[GitBox <gi...@apache.org>]

hycdong commented on PR #1099:
URL: https://github.com/apache/incubator-pegasus/pull/1099#issuecomment-1211473855

   LGTM~
   Besides, I have following suggestions:
   1. I recommend checking if `pack_server.sh`, `pack_client.sh`, `pack_tools.sh` can work well. In our previous build refactor, those script may have problems after build refactor.
   2. I recommend refactoring pegasus_function_test in future. Restrict with test time, some long-time function tests are not running if `on_travis` is set as true.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org