RE: Submitting patch

["Hou, GuoboX" <gu...@intel.com>]

@ Tsuyoshi
Thx.

-------------
Best Regards
Guobo
-----Original Message-----
From: Tsuyoshi OZAWA [mailto:ozawa.tsuyoshi@gmail.com] 
Sent: Tuesday, July 01, 2014 5:07 AM
To: yarn-dev@hadoop.apache.org
Subject: Re: Submitting patch

Hi Hou,

In this case, we cannot use Jenkins CI provided by Apache Foundation.
We should run tests locally on branch-2.2.0.

Thanks,
- Tsuyoshi

On Mon, Jun 30, 2014 at 5:36 PM, Hou, GuoboX <gu...@intel.com> wrote:
> But my code cannot apply the trunk, are there any solution? Can you give me some advice.
>
> -----Original Message-----
> From: Vinayakumar B [mailto:vinayakumarb@apache.org]
> Sent: Monday, June 30, 2014 4:31 PM
> To: yarn-dev@hadoop.apache.org
> Subject: Re: Submitting patch
>
> yes, explicit mention is only for the help of reviewers and committers. QA will always test on trunk.
>
> Regards,
> Vinay
>
> Regards,
> Vinay
>
>
> On Mon, Jun 30, 2014 at 1:13 PM, Hou, GuoboX <gu...@intel.com> wrote:
>
>> I have mentioned explicitly in the issue on the branck-2.2.0 , but QA 
>> test my code still one the trunk.
>>
>> -------------
>> Best Regards
>> Guobo
>>
>> -----Original Message-----
>> From: Vinayakumar B [mailto:vinayakumarb@apache.org]
>> Sent: Monday, June 30, 2014 1:11 PM
>> To: yarn-dev@hadoop.apache.org
>> Subject: Re: Submitting patch
>>
>> Hi
>> Hou, GuoboX,
>>
>> You can submit the patches for the trunk, and QA also will verify for 
>> the same.
>>
>> If the patch applies for the trunk, then it would automatically( In 
>> most cases unless there are some differences from trunk to branch) 
>> apply to branch-2.
>>
>> If in case, whatever issue you are facing is only in branch-2 but not 
>> in trunk, then you can mention explicitly in the issue. You can run 
>> the QA test locally on branch code by using 
>> *dev-support/test-patch.sh *present in Hadoop code and post results in Jira.
>>
>> Later committer will also review changes and commit to specific branch.
>>
>> Regards,
>> Vinay
>>
>> Regards,
>> Vinay
>>
>>
>> On Mon, Jun 30, 2014 at 8:10 AM, Hou, GuoboX <gu...@intel.com> wrote:
>>
>> > This is just one of my attempt for testing, not a normal patch.
>> >
>> > -------------
>> > Best Regards
>> > Guobo
>> >
>> > -----Original Message-----
>> > From: Ted Yu [mailto:yuzhihong@gmail.com]
>> > Sent: Monday, June 30, 2014 10:27 AM
>> > To: yarn-dev@hadoop.apache.org
>> > Subject: Re: Submitting patch
>> >
>> > There is no QA run for non-trunk branches.
>> >
>> > Please attach re-generated patch for trunk.
>> > trust001.patch
>> > <http://issues.apache.org/jira/secure/attachment/12652788/trust001.
>> > p
>> > at
>> > ch> can be applied to trunk but that seems to be just a test.
>> >
>> >
>> >
>> > On Sun, Jun 29, 2014 at 7:21 PM, Hou, GuoboX <gu...@intel.com>
>> wrote:
>> >
>> > > My patch is based on the branch-2.2.0,this branch is stable version.
>> > >
>> > > -------------
>> > > Best Regards
>> > > Guobo
>> > >
>> > > -----Original Message-----
>> > > From: Tsuyoshi OZAWA [mailto:ozawa.tsuyoshi@gmail.com]
>> > > Sent: Monday, June 30, 2014 10:06 AM
>> > > To: yarn-dev@hadoop.apache.org
>> > > Subject: Re: Submitting patch
>> > >
>> > > Hi, I think you need to rebase a patch on trunk code because 
>> > > trunk code by subversion or by git is changed.
>> > >
>> > > Thanks,
>> > > - Tsuyoshi
>> > >
>> > > On Mon, Jun 30, 2014 at 11:00 AM, Hou, GuoboX 
>> > > <gu...@intel.com>
>> > > wrote:
>> > > > This is my patch:
>> > > > https://issues.apache.org/jira/secure/attachment/12651387/trust.
>> > > > pa
>> > > > tc
>> > > > h
>> > > > This is the output:
>> > > > https://builds.apache.org/job/PreCommit-YARN-Build/4025//consol
>> > > > e
>> > > >
>> > > > -------------
>> > > > Best Regards
>> > > > Guobo
>> > > >
>> > > > -----Original Message-----
>> > > > From: haosdent [mailto:haosdent@gmail.com]
>> > > > Sent: Monday, June 30, 2014 9:53 AM
>> > > > To: yarn-dev@hadoop.apache.org
>> > > > Subject: Re: Submitting patch
>> > > >
>> > > > Could you provide more details about this? What's your failure 
>> > > > log in
>> > > apache QA?
>> > > >
>> > > >
>> > > > On Mon, Jun 30, 2014 at 9:46 AM, Hou, GuoboX 
>> > > > <gu...@intel.com>
>> > > wrote:
>> > > >
>> > > >> Hi guys,
>> > > >> I have a question about submitting patch, firstly the patch 
>> > > >> can be applied on my machine and the format of patch is OK, 
>> > > >> but it cannot pass the apache QA.
>> > > >>
>> > > >> Can you give me some advice.
>> > > >>
>> > > >> -------------
>> > > >> Best Regards
>> > > >> Guobo
>> > > >>
>> > > >
>> > > >
>> > > >
>> > > > --
>> > > > Best Regards,
>> > > > Haosdent Huang
>> > >
>> > >
>> > >
>> > > --
>> > > - Tsuyoshi
>> > >
>> >
>>



--
- Tsuyoshi