You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2021/02/18 18:13:24 UTC
[superset] branch hugh/change-sqla-doc-text created (now 2f297c5)
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a change to branch hugh/change-sqla-doc-text
in repository https://gitbox.apache.org/repos/asf/superset.git.
at 2f297c5 fix text whenever link isnt sqla based
This branch includes the following new commits:
new 2f297c5 fix text whenever link isnt sqla based
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
[superset] 01/01: fix text whenever link isnt sqla based
Posted by hu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a commit to branch hugh/change-sqla-doc-text
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 2f297c5a28dcf0688aa0db76a5f974720e016899
Author: hughhhh <hu...@gmail.com>
AuthorDate: Thu Feb 18 13:12:33 2021 -0500
fix text whenever link isnt sqla based
---
superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
index f2467de..966bc87 100644
--- a/superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
+++ b/superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx
@@ -143,6 +143,7 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
const [isHidden, setIsHidden] = useState<boolean>(true);
const [tabKey, setTabKey] = useState<string>(DEFAULT_TAB_KEY);
const conf = useSelector((state: RootState) => state.common.conf);
+ const documentationLink = conf?.SQLALCHEMY_DOCS_URL ?? '';
const isEditMode = database !== null;
const defaultExtra =
@@ -413,11 +414,13 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
<div className="helper">
{t('Refer to the ')}
<a
- href={conf?.SQLALCHEMY_DOCS_URL ?? ''}
+ href={documentationLink}
target="_blank"
rel="noopener noreferrer"
>
- {t('SQLAlchemy docs')}
+ {documentationLink.includes('sqlalchemy')
+ ? t('SQLAlchemy docs')
+ : t('Connection Strings documentation')}
</a>
{t(' for more information on how to structure your URI.')}
</div>