[GitHub] merlimat commented on issue #2526: [dev] provide a python merge script for merging pull requests

[GitBox <gi...@apache.org>]

merlimat commented on issue #2526: [dev] provide a python merge script for merging pull requests
URL: https://github.com/apache/incubator-pulsar/pull/2526#issuecomment-419171912
 
 
    >  Second, manage the commit message. when you click 'squash and merge' button, if you don't pay attention to copying the description in the PR to the merge text box, you will end up with a commit without description or with a mixed of random commits
   
   agree with commit message that is not uniformly enforced. Also most people (myself included) only fill the longer description in the PR but not on the commit log. 
   
   > or with a mixed of random commits 
   
   The current setting in github is to only allow the option to do "squash & rebase", so at least this is already enforced.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services